react-joyride - npm Package Compare versions

Comparing version 3.0.0-6 to 3.0.0-7

dist/index.d.ts

@@ -85,3 +85,3 @@ import * as react_jsx_runtime from 'react/jsx-runtime';
     /**
-     * Label for the next button with `showProgress.
+     * Label for the next button with `showProgress`.
      * Use the `{step}` and `{steps}` placeholders to display the current step and the total steps.
@@ -88,0 +88,0 @@ * @default 'Next (Step {step} of {steps})'

package.json

 {
   "name": "react-joyride",
-  "version": "3.0.0-6",
+  "version": "3.0.0-7",
   "description": "Create guided tours for your apps",
@@ -42,2 +42,3 @@ "author": "Gil Barbara <[e-mail]>",
     "@gilbarbara/hooks": "^0.8.2",
+    "@gilbarbara/types": "^0.2.2",
     "deepmerge": "^4.3.1",
@@ -52,41 +53,40 @@ "is-lite": "^1.2.1",
   "devDependencies": {
-    "@arethetypeswrong/cli": "^0.16.1",
-    "@gilbarbara/eslint-config": "^0.8.1",
+    "@arethetypeswrong/cli": "^0.17.0",
+    "@gilbarbara/eslint-config": "^0.8.2",
     "@gilbarbara/node-helpers": "^0.1.0",
     "@gilbarbara/prettier-config": "^1.0.0",
     "@gilbarbara/tsconfig": "^0.2.3",
-    "@gilbarbara/types": "^0.2.2",
-    "@playwright/experimental-ct-react": "^1.47.0",
-    "@size-limit/preset-big-lib": "^11.1.5",
-    "@swc/core": "^1.7.24",
+    "@playwright/experimental-ct-react": "^1.49.0",
+    "@size-limit/preset-big-lib": "^11.1.6",
+    "@swc/core": "^1.9.2",
     "@testing-library/dom": "^10.4.0",
-    "@testing-library/jest-dom": "^6.5.0",
+    "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.0.1",
     "@total-typescript/shoehorn": "^0.1.2",
     "@types/exenv": "^1.2.2",
-    "@types/node": "^20.12.13",
-    "@types/react": "^18.3.5",
-    "@types/react-dom": "^18.3.0",
+    "@types/node": "^22.9.0",
+    "@types/react": "^18.3.12",
+    "@types/react-dom": "^18.3.1",
     "@types/scroll": "^3.0.3",
     "@types/scrollparent": "^2.0.3",
-    "@vitejs/plugin-react-swc": "^3.7.0",
-    "@vitest/coverage-v8": "^2.0.5",
-    "caniuse-lite": "^1.0.30001659",
+    "@vitejs/plugin-react-swc": "^3.7.1",
+    "@vitest/coverage-v8": "^2.1.5",
+    "caniuse-lite": "^1.0.30001680",
     "chalk": "^5.3.0",
     "cross-env": "^7.0.3",
     "csstype": "^3.1.3",
-    "del-cli": "^5.1.0",
-    "husky": "^9.1.5",
+    "del-cli": "^6.0.0",
+    "husky": "^9.1.7",
     "is-ci-cli": "^2.2.0",
     "jest-extended": "^4.0.2",
-    "jsdom": "^25.0.0",
+    "jsdom": "^25.0.1",
     "react": "^18.3.1",
     "react-dom": "^18.3.1",
     "repo-tools": "^0.3.1",
-    "size-limit": "^11.1.5",
+    "size-limit": "^11.1.6",
     "ts-node": "^10.9.2",
-    "tsup": "^8.2.4",
-    "typescript": "^5.5.4",
-    "vite-tsconfig-paths": "^5.0.1",
-    "vitest": "^2.0.5"
+    "tsup": "^8.3.5",
+    "typescript": "^5.6.3",
+    "vite-tsconfig-paths": "^5.1.2",
+    "vitest": "^2.1.5"
   },
@@ -93,0 +93,0 @@ "scripts": {

src/modules/dom.ts

@@ -211,6 +211,12 @@ import scroll from 'scroll';
   const hasScrollParent = hasCustomScrollParent(element, skipFix);
+  const isFixedTarget = hasPosition(element);
   let parentTop = 0;
   let top = elementRect?.top ?? 0;
 
-  if (parent instanceof HTMLElement) {
+  if (hasScrollParent && isFixedTarget) {
+    const offsetTop = element?.offsetTop ?? 0;
+    const parentScrollTop = (parent as HTMLElement)?.scrollTop ?? 0;
+
+    top = offsetTop - parentScrollTop;
+  } else if (parent instanceof HTMLElement) {
     parentTop = parent.scrollTop;
@@ -217,0 +223,0 @@

src/types/common.ts

@@ -43,3 +43,3 @@ import { CSSProperties, ReactNode } from 'react';
   /**
-   * Label for the next button with `showProgress.
+   * Label for the next button with `showProgress`.
    * Use the `{step}` and `{steps}` placeholders to display the current step and the total steps.
@@ -46,0 +46,0 @@ * @default 'Next (Step {step} of {steps})'

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

505907

increased by2.4%

Dev dependency count

38

decreased by-2.56%

Lines of code

7923

increased by1.49%

Worsened metrics

Dependency count

12

increased by9.09%

Dependency changes

• + Added@gilbarbara/types@^0.2.2

• + Added@gilbarbara/types@0.2.2(transitive)

• + Addedtype-fest@4.30.1(transitive)