react-moment-proptypes - npm Package Compare versions

Comparing version 1.4.0 to 1.5.0

package.json

 {
   "name": "react-moment-proptypes",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "description": "React proptype for moment module",
@@ -19,6 +19,7 @@ "keywords": [
     "coveralls": "cat ./coverage/lcov.info | coveralls",
-    "test": "./node_modules/.bin/mocha --recursive --compilers js:babel/register --require ./test/setup.js",
-    "test-all": "npm run test-1.6 && npm run test-1.7 && rm -Rf ./node_modules/moment/ && npm i && npm test",
+    "test": "./node_modules/.bin/mocha --recursive --compilers js:babel/register",
+    "test-all": "npm run test-1.6 && npm run test-1.7 && npm run test-latest",
     "test-1.6": "rm -Rf ./node_modules/moment/ && npm i moment@1.6.0 && npm test",
     "test-1.7": "rm -Rf ./node_modules/moment/ && npm i moment@1.7.0 && npm test",
+    "test-latest": "rm -Rf ./node_modules/moment/ && npm i moment@latest && npm test",
     "lint": "./node_modules/.bin/eslint --ext .js .",
@@ -44,9 +45,11 @@ "lint-quiet": "./node_modules/.bin/eslint --ext .js --quiet .",
     "coveralls": "^2.11.6",
+    "enzyme": "^2.9.1",
     "eslint": "^0.24.0",
     "istanbul": "^0.3.13",
-    "jsdom": "^6.5.1",
-    "mocha": "^2.2.1",
-    "react": "^0.14.6",
-    "react-addons-test-utils": "^0.14.6"
+    "mocha": "^3.4.2",
+    "react": "^15.6.1",
+    "react-dom": "^15.6.1",
+    "react-test-renderer": "^15.6.1",
+    "sinon": "^2.3.6"
   }
 }

README.md

@@ -41,5 +41,5 @@ # react-moment-proptypes
 
-Tests were approached with `jsdom` and React's test utility renderer
+Tests were approached with `enzyme` and React's test utility renderer
 
-- `npm test` for running unit tests
+- `npm test` for running unit and integration tests
 - `npm run coverage` for current test coverage
@@ -46,0 +46,0 @@

src/index.js

 var moment = require('moment');
 var momentValidationWrapper = require('./moment-validation-wrapper');
+var core = require('./core');
 
@@ -8,92 +9,5 @@ moment.createFromInputFallback = function(config) {
 
-var ANONYMOUS = '<<anonymous>>';
-
-var ReactPropTypeLocationNames = {
-  prop : 'prop',
-  context : 'context',
-  childContext : 'child context',
-};
-
-function createInvalidRequiredErrorMessage(propName, componentName, value) {
-  return new Error(
-    'The prop `' + propName + '` is marked as required in `' + componentName + '`, but its value is `' + value + '`.'
-  );
-}
-
-function createMomentChecker(type, typeValidator, validator, momentType) {
-
-  function propValidator(
-    isRequired, // Bound parameter to indicate with the propType is required
-    predicate, // Bound parameter to allow user to add dynamic validation
-    props,
-    propName,
-    componentName,
-    location,
-    propFullName
-  ) {
-    var propValue = props[ propName ];
-    var propType = typeof propValue;
-
-    var isPropValueUndefined = typeof propValue === 'undefined';
-    var isPropValueNull = propValue === null;
-
-    if (isRequired) {
-      componentName = componentName || ANONYMOUS;
-      propFullName = propFullName || propName;
-      if (isPropValueUndefined) {
-        return createInvalidRequiredErrorMessage(propFullName, componentName, 'undefined');
-      } else if (isPropValueNull) {
-        return createInvalidRequiredErrorMessage(propFullName, componentName, 'null');
-      }
-    }
-
-    if (isPropValueUndefined || isPropValueNull) {
-      return null;
-    }
-
-    if (typeValidator && !typeValidator(propValue)) {
-      return new Error(
-        'Invalid input type: `' + propName + '` of type `' + propType + '` ' +
-        'supplied to `' + componentName + '`, expected `' + type + '`.'
-      );
-    }
-
-    if (! validator(propValue)) {
-      return new Error(
-        'Invalid ' + location + ' `' + propName + '` of type `' + propType + '` ' +
-        'supplied to `' + componentName + '`, expected `' + momentType + '`.'
-      );
-    }
-
-    if (predicate && ! predicate(propValue)) {
-      var predicateName = predicate.name || ANONYMOUS;
-      return new Error(
-        'Invalid ' + location + ' `' + propName + '` of type `' + propType + '` ' +
-        'supplied to `' + componentName + '`. Failed to succeed with predicate `' +
-        predicateName + '`.'
-      );
-    }
-
-    return null;
-
-  }
-
-  var requiredPropValidator = propValidator.bind(null, false, null);
-  requiredPropValidator.isRequired = propValidator.bind(null, true, null);
-  requiredPropValidator.withPredicate = function predicateApplication(predicate) {
-    if (typeof predicate !== 'function') {
-      throw new Error('`predicate` must be a function');
-    }
-    var basePropValidator = propValidator.bind(null, false, predicate);
-    basePropValidator.isRequired = propValidator.bind(null, true, predicate);
-    return basePropValidator;
-  };
-
-  return requiredPropValidator;
-
-}
-
 module.exports = {
 
-  momentObj : createMomentChecker(
+  momentObj : core.createMomentChecker(
     'object',
@@ -109,3 +23,3 @@ function(obj) {
 
-  momentString : createMomentChecker(
+  momentString : core.createMomentChecker(
     'string',
@@ -121,3 +35,3 @@ function(str) {
 
-  momentDurationObj : createMomentChecker(
+  momentDurationObj : core.createMomentChecker(
     'object',
@@ -124,0 +38,0 @@ function(obj) {

src/moment-validation-wrapper.js

 var moment = require('moment');
 
 function isValidMoment(testMoment) {
+  if (typeof moment.isMoment === 'function' && !moment.isMoment(testMoment)) {
+    return false;
+  }
+
+  /* istanbul ignore else  */
   if (typeof testMoment.isValid === 'function') {
@@ -9,3 +14,4 @@ // moment 1.7.0+
 
-  return ! isNaN(testMoment);
+  /* istanbul ignore next */
+  return !isNaN(testMoment);
 }
@@ -15,2 +21,2 @@
   isValidMoment : isValidMoment,
-}
+};

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Improved metrics

Number of package files

18

increased by28.57%

Number of low supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

49176

decreased by-69.82%

Dev dependency count

12

increased by20%

Lines of code

999

decreased by-77.55%

No dependency changes