remark-lint-no-duplicate-defined-urls - npm Package Compare versions

Comparing version 1.0.1 to 2.0.0

index.js

@@ -9,3 +9,4 @@ /**
  *
- * @example {"name": "ok.md"}
+ * @example
+ *   {"name": "ok.md"}
  *
@@ -15,3 +16,4 @@ *   [alpha]: alpha.com
  *
- * @example {"name": "not-ok.md", "label": "input"}
+ * @example
+ *   {"name": "not-ok.md", "label": "input"}
  *
@@ -21,3 +23,4 @@ *   [alpha]: alpha.com
  *
- * @example {"name": "not-ok.md", "label": "output"}
+ * @example
+ *   {"name": "not-ok.md", "label": "output"}
  *
@@ -27,40 +30,39 @@ *   2:1-2:19: Do not use different definitions with the same URL (1:1)
 
-'use strict'
+/**
+ * @typedef {import('mdast').Root} Root
+ */
 
-var rule = require('unified-lint-rule')
-var position = require('unist-util-position')
-var generated = require('unist-util-generated')
-var stringify = require('unist-util-stringify-position')
-var visit = require('unist-util-visit')
+import {lintRule} from 'unified-lint-rule'
+import {pointStart} from 'unist-util-position'
+import {generated} from 'unist-util-generated'
+import {stringifyPosition} from 'unist-util-stringify-position'
+import {visit} from 'unist-util-visit'
 
-module.exports = rule(
+const remarkLintNoDuplicateDefinedUrls = lintRule(
   'remark-lint:no-duplicate-defined-urls',
-  noDuplicateDefinedUrls
-)
+  /** @type {import('unified-lint-rule').Rule<Root, void>} */
+  (tree, file) => {
+    /** @type {Record<string, string>} */
+    const map = Object.create(null)
 
-var reason = 'Do not use different definitions with the same URL'
+    visit(tree, 'definition', (node) => {
+      if (!generated(node) && node.url) {
+        const url = String(node.url).toUpperCase()
+        const duplicate = map[url]
 
-function noDuplicateDefinedUrls(tree, file) {
-  var map = {}
+        if (duplicate) {
+          file.message(
+            'Do not use different definitions with the same URL (' +
+              duplicate +
+              ')',
+            node
+          )
+        }
 
-  visit(tree, 'definition', check)
-
-  function check(node) {
-    var url
-    var duplicate
-
-    if (!generated(node) && node.url) {
-      url = String(node.url).toUpperCase()
-      duplicate = map[url]
-
-      if (duplicate && duplicate.type) {
-        file.message(
-          reason + ' (' + stringify(position.start(duplicate)) + ')',
-          node
-        )
+        map[url] = stringifyPosition(pointStart(node))
       }
+    })
+  }
+)
 
-      map[url] = node
-    }
-  }
-}
+export default remarkLintNoDuplicateDefinedUrls

package.json

 {
   "name": "remark-lint-no-duplicate-defined-urls",
-  "version": "1.0.1",
+  "version": "2.0.0",
   "description": "remark-lint rule to warn on definitions that define the same urls",
@@ -25,13 +25,29 @@ "license": "MIT",
   ],
+  "sideEffects": false,
+  "type": "module",
+  "main": "index.js",
+  "types": "index.d.ts",
   "files": [
+    "index.d.ts",
     "index.js"
   ],
   "dependencies": {
-    "unified-lint-rule": "^1.0.0",
-    "unist-util-generated": "^1.0.0",
-    "unist-util-position": "^3.0.0",
-    "unist-util-stringify-position": "^2.0.0",
-    "unist-util-visit": "^2.0.0"
+    "@types/mdast": "^3.0.0",
+    "unified": "^10.0.0",
+    "unified-lint-rule": "^2.0.0",
+    "unist-util-generated": "^2.0.0",
+    "unist-util-position": "^4.0.0",
+    "unist-util-stringify-position": "^3.0.0",
+    "unist-util-visit": "^4.0.0"
   },
-  "xo": false
+  "scripts": {
+    "build": "rimraf \"*.d.ts\" && tsc && type-coverage"
+  },
+  "xo": false,
+  "typeCoverage": {
+    "atLeast": 100,
+    "detail": true,
+    "strict": true,
+    "ignoreCatch": true
+  }
 }

readme.md

@@ -51,2 +51,5 @@ <!--This file is generated-->
 
+This package is [ESM only][esm]:
+Node 12+ is needed to use it and it must be `imported`ed instead of `required`d.
+
 [npm][]:
@@ -58,2 +61,5 @@
 
+This package exports no identifiers.
+The default export is `remarkLintNoDuplicateDefinedUrls`.
+
 ## Use
@@ -85,10 +91,13 @@
 ```diff
- var remark = require('remark')
- var report = require('vfile-reporter')
+ import {remark} from 'remark'
+ import {reporter} from 'vfile-reporter'
+ import remarkLint from 'remark-lint'
+ import remarkLintNoDuplicateDefinedUrls from 'remark-lint-no-duplicate-defined-urls'
 
  remark()
-   .use(require('remark-lint'))
-+  .use(require('remark-lint-no-duplicate-defined-urls'))
-   .process('_Emphasis_ and **importance**', function (err, file) {
-     console.error(report(err || file))
+   .use(remarkLint)
++  .use(remarkLintNoDuplicateDefinedUrls)
+   .process('_Emphasis_ and **importance**')
+   .then((file) => {
+     console.error(reporter(file))
    })
@@ -111,5 +120,5 @@ ```
 
-[build-badge]: https://img.shields.io/travis/remarkjs/remark-lint/main.svg
+[build-badge]: https://github.com/remarkjs/remark-lint/workflows/main/badge.svg
 
-[build]: https://travis-ci.org/remarkjs/remark-lint
+[build]: https://github.com/remarkjs/remark-lint/actions
 
@@ -134,6 +143,8 @@ [coverage-badge]: https://img.shields.io/codecov/c/github/remarkjs/remark-lint.svg
 
-[chat-badge]: https://img.shields.io/badge/chat-spectrum.svg
+[chat-badge]: https://img.shields.io/badge/chat-discussions-success.svg
 
-[chat]: https://spectrum.chat/unified/remark
+[chat]: https://github.com/remarkjs/remark/discussions
 
+[esm]: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c
+
 [npm]: https://docs.npmjs.com/cli/install
@@ -140,0 +151,0 @@

No alert changes

Improved metrics

Total package byte prevSize

6890

24.73%

Number of package files

4

33.33%

Lines of code

73

40.38%

Number of lines in readme file

158

7.48%

Is type module

Yes

NaN

Worsened metrics

Dependency count

7

40%

Dependency changes

• + Added

  @types/mdast@^3.0.0

• + Added

  unified@^10.0.0

• + Added

  @types/mdast@3.0.15
  (transitive)

• + Added

  bail@2.0.2
  (transitive)

• + Added

  extend@3.0.2
  (transitive)

• + Added

  is-buffer@2.0.5
  (transitive)

• + Added

  is-plain-obj@4.1.0
  (transitive)

• + Added

  trough@2.2.0
  (transitive)

• + Added

  unified@10.1.2
  (transitive)

• + Added

  unified-lint-rule@2.1.2
  (transitive)

• + Added

  unist-util-generated@2.0.1
  (transitive)

• + Added

  unist-util-is@5.2.1
  (transitive)

• + Added

  unist-util-position@4.0.4
  (transitive)

• + Added

  unist-util-stringify-position@3.0.3
  (transitive)

• + Added

  unist-util-visit@4.1.2
  (transitive)

• + Added

  unist-util-visit-parents@5.1.3
  (transitive)

• + Added

  vfile@5.3.7
  (transitive)

• + Added

  vfile-message@3.1.4
  (transitive)

• - Removed

  co@3.1.0
  (transitive)

• - Removed

  sliced@1.0.1
  (transitive)

• - Removed

  unified-lint-rule@1.0.6
  (transitive)

• - Removed

  unist-util-generated@1.1.6
  (transitive)

• - Removed

  unist-util-is@4.1.0
  (transitive)

• - Removed

  unist-util-position@3.1.0
  (transitive)

• - Removed

  unist-util-stringify-position@2.0.3
  (transitive)

• - Removed

  unist-util-visit@2.0.3
  (transitive)

• - Removed

  unist-util-visit-parents@3.1.1
  (transitive)

• - Removed

  wrapped@1.0.1
  (transitive)

• Updated

  unified-lint-rule@^2.0.0

• Updated

  unist-util-generated@^2.0.0

• Updated

  unist-util-position@^4.0.0

• Updated

  unist-util-stringify-position@^3.0.0

• Updated

  unist-util-visit@^4.0.0