remult - npm Package Compare versions

Comparing version 0.26.10 to 0.26.11-next.0

esm/remult-sqlite-core.js

@@ -25,3 +25,3 @@ import { SqlDatabase } from './src/data-providers/sql-database.js';
             addColumn: async (entity, field) => {
-                let e = await dbNamesOf(entity);
+                let e = await dbNamesOf(entity, this.wrapIdentifier);
                 let sql = `alter table ${e.$entityName} add column ${self.addColumnSqlSyntax(field, e.$dbNameOf(field))}`;
@@ -50,3 +50,3 @@ builder.addSql(sql);
     async dropTable(entity) {
-        let e = await dbNamesOf(entity);
+        let e = await dbNamesOf(entity, this.wrapIdentifier);
         let sql = 'drop  table if exists ' + e.$entityName;
@@ -83,3 +83,3 @@ if (SqlDatabase.LogToConsole)
         let result = '';
-        let e = await dbNamesOf(entity);
+        let e = await dbNamesOf(entity, this.wrapIdentifier);
         for (const x of entity.fields) {
@@ -107,4 +107,5 @@ if (!shouldNotCreateField(x, e) || isAutoIncrement(x)) {
     wrapIdentifier(name) {
-        return name;
+        //return name
+        return '`' + name + '`';
     }
 }

esm/src/remult3/remult3.js

 export {};
 //y2 - soft-delete-discussion https://discord.com/channels/975754286384418847/1230386433093533698/1230386433093533698
 //y1 - In the esm version of our tutorial - the imports are automatically .ts and not .js in react and not in vue
+/*y1 - The retry on server error is too wide (error 500, basically any server error) 50 retries is annoying
+  - vite doesn't say proxy error, so we can't listen to that to know that we are in dev
+  - Our SSE has it's own separate retry every 500 ms that is also problematic
+  - when using concurrently - on any server error - the terminal is flooded by the error messages
 //y1 - consider id to also support keyof (id:['company','index']) - had problem with | (keyof Partial<entityType>)[] & `entity`
 //y2 - readonly key: keyof MembersOnly<entityType> & string
+//y1 TODO - In the esm version of our tutorial - the imports are automatically .ts and not .js in react and not in vue
+//y1 TODO - consider id to also support keyof (id:['company','index']) - had problem with | (keyof Partial<entityType>)[] & `entity`
+//y1 TODO -  readonly key: keyof MembersOnly<entityType> & string
+
 //y1 - talk about insert / update / delete with relations
@@ -28,3 +36,2 @@ /*
 //p2 -fix remult admin not to load the html into memory until used
-//y2 - JY suggestion of having generate as part of the ensure schema - not sure
 //y2 - currently for string fields we default for 255 in knex (which is their default) why not just use text (varchar max) - and only use exact length when one is provided?
@@ -31,0 +38,0 @@ //p2 - create foreign key constraints in user code - https://codesandbox.io/p/devbox/fk-validator-tdshcs

package.json

 {
     "name": "remult",
-    "version": "0.26.10",
+    "version": "0.26.11-next.0",
     "description": "A CRUD framework for full-stack TypeScript",
@@ -5,0 +5,0 @@ "homepage": "https://remult.dev",

remult-sqlite-core.d.ts

@@ -21,3 +21,3 @@ import type { EntityMetadata } from './src/remult3/remult3.js';
     private getCreateTableSql;
-    wrapIdentifier?(name: string): string;
+    wrapIdentifier(name: string): string;
 }

remult-sqlite-core.js

@@ -39,3 +39,3 @@ "use strict";
                     switch (_a.label) {
-                        case 0: return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity)];
+                        case 0: return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity, this.wrapIdentifier)];
                         case 1:
@@ -121,3 +121,3 @@ e = _a.sent();
                 switch (_a.label) {
-                    case 0: return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity)];
+                    case 0: return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity, this.wrapIdentifier)];
                     case 1:
@@ -179,3 +179,3 @@ e = _a.sent();
                         result = '';
-                        return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity)];
+                        return [4 /*yield*/, (0, filter_consumer_bridge_to_sql_request_js_1.dbNamesOf)(entity, this.wrapIdentifier)];
                     case 1:
@@ -218,3 +218,4 @@ e = _d.sent();
     SqliteCoreDataProvider.prototype.wrapIdentifier = function (name) {
-        return name;
+        //return name
+        return '`' + name + '`';
     };
@@ -221,0 +222,0 @@ return SqliteCoreDataProvider;

src/remult3/remult3.js

@@ -5,4 +5,12 @@ "use strict";
 //y1 - In the esm version of our tutorial - the imports are automatically .ts and not .js in react and not in vue
+/*y1 - The retry on server error is too wide (error 500, basically any server error) 50 retries is annoying
+  - vite doesn't say proxy error, so we can't listen to that to know that we are in dev
+  - Our SSE has it's own separate retry every 500 ms that is also problematic
+  - when using concurrently - on any server error - the terminal is flooded by the error messages
 //y1 - consider id to also support keyof (id:['company','index']) - had problem with | (keyof Partial<entityType>)[] & `entity`
 //y2 - readonly key: keyof MembersOnly<entityType> & string
+//y1 TODO - In the esm version of our tutorial - the imports are automatically .ts and not .js in react and not in vue
+//y1 TODO - consider id to also support keyof (id:['company','index']) - had problem with | (keyof Partial<entityType>)[] & `entity`
+//y1 TODO -  readonly key: keyof MembersOnly<entityType> & string
+
 //y1 - talk about insert / update / delete with relations
@@ -30,3 +38,2 @@ /*
 //p2 -fix remult admin not to load the html into memory until used
-//y2 - JY suggestion of having generate as part of the ensure schema - not sure
 //y2 - currently for string fields we default for 255 in knex (which is their default) why not just use text (varchar max) - and only use exact length when one is provided?
@@ -33,0 +40,0 @@ //p2 - create foreign key constraints in user code - https://codesandbox.io/p/devbox/fk-validator-tdshcs

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

5057299

increased by0.05%

Lines of code

51898

increased by0.09%

No dependency changes