rox-base - npm Package Compare versions

Comparing version 1.2.1 to 1.2.2

package.json

 {
   "name": "rox-base",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Rollout.io ROX JS SDK Base",
@@ -5,0 +5,0 @@ "author": "Rollout.io <[e-mail]>",

src/lib/RequestConfiguration.js

@@ -15,7 +15,4 @@ import { get } from 'axios';
 
-const fetchFromCDN = function(cache_miss_url) {
-  if (!cache_miss_url) {
-    return Promise.reject();
-  }
-  return get(cache_miss_url).then(({ data, status }) => {
+const fetchFromCDN = function(cache_url) {
+  return get(cache_url).then(({ data, status }) => {
     if (status === 200 && data && data.constructor === Object) {
@@ -29,4 +26,5 @@ RoxLogger.debug('succeed fetch from CDN');
 
-export function fetchRemoteConfiguration(properties = {}) {
-  return fetchFromCDN(properties.cache_miss_url)
+export function fetchRemoteConfiguration(properties) {
+  const cache_url = `${properties.cache_miss_url}?distinct_id=${properties.distinct_id}`;
+  return fetchFromCDN(cache_url)
     .catch(() => fetchFromAPI(buildAPIURL(properties)))
@@ -33,0 +31,0 @@ .catch(err => {

src/lib/RequestConfigurationBuilder.js

@@ -27,4 +27,4 @@ import Config from '../config';
   properties.buid_generators_list = BUID.GENERATOR_LIST.join(',');
-  properties.cache_miss_url = `${Config.get('CD_S3_ENDPOINT')}${properties.buid}?distinct_id=${properties.distinct_id}`;
+  properties.cache_miss_url = `${Config.get('CD_S3_ENDPOINT')}${properties.buid}`;
   return properties;
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

1523223

decreased by-0.04%

Lines of code

10586

decreased by-0.05%

No dependency changes