scribe-editor - npm Package Compare versions

Comparing version 1.2.3 to 1.2.4

CHANGELOG.md

@@ -0,1 +1,5 @@
+# 1.2.4
+
+Changes the way that root nodes are detected, the code now uses the element that the Scribe instance is bound to rather than looking for contenteditable attributes.
+
 # 1.2.3
@@ -2,0 +6,0 @@

package.json

 {
   "name": "scribe-editor",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "main": "src/scribe.js",
@@ -5,0 +5,0 @@ "dependencies": {

src/api/node.js

@@ -12,6 +12,5 @@ define(function () {
   // TODO: write tests. unit or integration?
-  Node.prototype.getAncestor = function (nodeFilter) {
+  Node.prototype.getAncestor = function (rootElement, nodeFilter) {
     var isTopContainerElement = function (element) {
-      return element && element.attributes
-        && element.attributes.getNamedItem('contenteditable');
+      return rootElement === element;
     };
@@ -18,0 +17,0 @@ // TODO: should this happen here?

src/api/selection.js

@@ -28,6 +28,5 @@ define([
       var node = new scribe.api.Node(this.range.commonAncestorContainer);
-      var isTopContainerElement = node.node && node.node.attributes
-         && node.node.attributes.getNamedItem('contenteditable');
+      var isTopContainerElement = node.node && scribe.el === node.node;
 
-      return ! isTopContainerElement && nodeFilter(node.node) ? node.node : node.getAncestor(nodeFilter);
+      return ! isTopContainerElement && nodeFilter(node.node) ? node.node : node.getAncestor(scribe.el, nodeFilter);
     };
@@ -34,0 +33,0 @@

No alert changes

Improved metrics

Total package byte prevSize

179902

increased by0.04%

Worsened metrics

Lines of code

3785

decreased by-0.05%

No dependency changes