scribe-editor - npm Package Compare versions

Comparing version 1.2.5 to 1.2.7

BROWSERINCONSISTENCIES.md

@@ -101,1 +101,12 @@ ## List of `contenteditable` Browser Inconsistencies
   http://jsbin.com/xoqul/1/edit?js,console,output
+
+### `Selection.getRangeAt`
+* Chrome (< 42): Selection.getRangeAt() returns an incorrect range when in shadow DOM
+  https://code.google.com/p/chromium/issues/detail?id=380690
+
+### `Selection.isCollapsed`
+* Chrome: Selection.isCollapsed is incorrect when in shadow DOM
+  https://code.google.com/p/chromium/issues/detail?id=447523
+  http://jsfiddle.net/7zgegoda/2/
+
+

CHANGELOG.md

@@ -0,1 +1,5 @@
+# 1.2.7
+
+ShadowDOM fixes for Chrome from [ShaunNetherby](https://github.com/shaunnetherby), thanks
+
 # 1.2.5
@@ -2,0 +6,0 @@

package.json

 {
   "name": "scribe-editor",
-  "version": "1.2.5",
+  "version": "1.2.7",
   "main": "src/scribe.js",
@@ -5,0 +5,0 @@ "dependencies": {

src/api/selection.js

@@ -13,6 +13,22 @@ define([
     function Selection() {
-      this.selection = window.getSelection();
+      var rootDoc = document;
 
+      // find the parent document or document fragment
+      var currentElement = scribe.el.parentNode;
+      while(currentElement && currentElement.nodeType !== Node.DOCUMENT_FRAGMENT_NODE && currentElement.nodeType !== Node.DOCUMENT_NODE) {
+        currentElement = currentElement.parentNode;
+      }
+
+      // if we found a document fragment and it has a getSelection method, set it to the root doc
+      if (currentElement && currentElement.nodeType === Node.DOCUMENT_FRAGMENT_NODE && currentElement.getSelection) {
+        rootDoc = currentElement;
+      }
+
+      this.selection = rootDoc.getSelection();
       if (this.selection.rangeCount) {
-        this.range = this.selection.getRangeAt(0);
+        // create the range to avoid chrome bug from getRangeAt / window.getSelection()
+        // https://code.google.com/p/chromium/issues/detail?id=380690
+        this.range = document.createRange();
+        this.range.setStart(this.selection.anchorNode, this.selection.anchorOffset);
+        this.range.setEnd(this.selection.focusNode, this.selection.focusOffset);
       }
@@ -136,4 +152,4 @@ }
 
-
-        if (! this.selection.isCollapsed) {
+        // using range.collapsed vs selection.isCollapsed - https://code.google.com/p/chromium/issues/detail?id=447523
+        if (! this.range.collapsed) {
           // Start marker
@@ -140,0 +156,0 @@ var rangeStart = this.range.cloneRange();

src/plugins/core/patches/commands/create-link.js

@@ -17,3 +17,4 @@ define(function () {
          */
-        if (selection.selection.isCollapsed) {
+        // using range.collapsed vs selection.isCollapsed - https://code.google.com/p/chromium/issues/detail?id=447523
+        if (selection.range.collapsed) {
           var aElement = document.createElement('a');
@@ -20,0 +21,0 @@ aElement.setAttribute('href', value);

No alert changes

Improved metrics

Total package byte prevSize

181839

increased by0.89%

Lines of code

3804

increased by0.42%

No dependency changes