scribe-editor - npm Package Compare versions

Comparing version 1.3.0 to 1.3.1

CHANGELOG.md

@@ -0,1 +1,5 @@
+# 1.3.1
+
+Adds a null check to selection.js to help with issues when Scribe is being run in ShadowDOM. Thanks [Shaun Netherby](https://github.com/shaunnetherby)
+
 # 1.3.0
@@ -2,0 +6,0 @@

CONTRIBUTING.md

 # Contributing
 
-These steps also apply to plugins.
+This advice also applies to Scribe plugins.
 
+## Finding an issue to work on
+
+See the [wiki page on labels](https://github.com/guardian/scribe/wiki/Project-labels) for an explanation about how we categorise the project issues.
+
+Assign yourself to the issue or comment on it to indicate that you are going to work on it.
+
+## Fixing an issue
+
 * Add a failing test
@@ -6,0 +14,0 @@ * Create isolated cases for browser inconsistencies (see https://github.com/guardian/scribe/blob/master/BROWSERINCONSISTENCIES.md)

package.json

 {
   "name": "scribe-editor",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "main": "src/scribe.js",
@@ -18,9 +18,9 @@ "dependencies": {
     "npm": "^2.5.0",
-    "plumber": "~0.3.0",
-    "plumber-all": "~0.3.0",
-    "plumber-cli": "~0.3.0",
-    "plumber-glob": "~0.3.0",
-    "plumber-requirejs": "~0.3.0",
-    "plumber-uglifyjs": "~0.3.0",
-    "plumber-write": "~0.3.0",
+    "plumber": "~0.4.0",
+    "plumber-all": "~0.4.0",
+    "plumber-cli": "~0.4.0",
+    "plumber-glob": "~0.4.0",
+    "plumber-requirejs": "~0.4.0",
+    "plumber-uglifyjs": "~0.4.0",
+    "plumber-write": "~0.4.0",
     "q": "~1.0.0",
@@ -27,0 +27,0 @@ "request": "~2.33.0",

src/api/selection.js

@@ -27,3 +27,3 @@ define([
       this.selection = rootDoc.getSelection();
-      if (this.selection.rangeCount) {
+      if (this.selection.rangeCount && this.selection.anchorNode) {
         // create the range to avoid chrome bug from getRangeAt / window.getSelection()
@@ -30,0 +30,0 @@ // https://code.google.com/p/chromium/issues/detail?id=380690

No alert changes

Improved metrics

Total package byte prevSize

191657

increased by0.26%

No dependency changes