scribe-editor - npm Package Compare versions

Comparing version 1.3.4 to 1.3.5

bower.json

 {
   "name": "scribe",
   "dependencies": {
-    "lodash-amd": "2.4.1",
+    "lodash-amd": "3.5.0",
     "immutable" : "3.6.2"
@@ -6,0 +6,0 @@ },

CHANGELOG.md

@@ -0,1 +1,5 @@
+# 1.3.5
+
+Fixes `event-emitter` off behaviour when un-binding events
+
 # 1.3.4
@@ -2,0 +6,0 @@

package.json

 {
   "name": "scribe-editor",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "main": "src/scribe.js",
@@ -5,0 +5,0 @@ "dependencies": {

src/config.js

 define([
-  'lodash-amd/modern/objects/defaults'
+  'lodash-amd/modern/object/defaults'
 ], function (defaults) {
@@ -4,0 +4,0 @@

src/dom-observer.js

 define([
-  'lodash-amd/modern/arrays/flatten',
-  'lodash-amd/modern/collections/toArray',
+  'lodash-amd/modern/array/flatten',
+  'lodash-amd/modern/lang/toArray',
   './element',
@@ -29,3 +29,3 @@ './node'
     var MutationObserver = window.MutationObserver || window.WebKitMutationObserver || window.MozMutationObserver;
-    
+
     // Flag to avoid running recursively
@@ -32,0 +32,0 @@ var runningPostMutation = false;

src/element.js

@@ -1,2 +0,2 @@
-define(['lodash-amd/modern/collections/contains'], function (contains) {
+define(['lodash-amd/modern/collection/contains'], function (contains) {
 
@@ -3,0 +3,0 @@ 'use strict';

src/event-emitter.js

@@ -1,2 +0,2 @@
-define(['lodash-amd/modern/arrays/pull',
+define(['lodash-amd/modern/array/pull',
   'immutable/dist/immutable'], function (pull, Immutable) {
@@ -22,5 +22,5 @@
     if (fn) {
-      listeners = listeners.delete(fn);
+      this._listeners = listeners.delete(fn);
     } else {
-      listeners = listeners.clear();
+      this._listeners = listeners.clear();
     }
@@ -27,0 +27,0 @@ };

src/plugins/core/events.js

 define([
-  'lodash-amd/modern/collections/contains',
+  'lodash-amd/modern/collection/contains',
   '../../dom-observer'
@@ -4,0 +4,0 @@ ], function (

src/plugins/core/formatters/html/enforce-p-elements.js

 define([
-  'lodash-amd/modern/arrays/last'
+  'lodash-amd/modern/array/last'
 ], function (
@@ -4,0 +4,0 @@ last

src/plugins/core/formatters/html/ensure-selectable-containers.js

 define([
     '../../../../element',
-    'lodash-amd/modern/collections/contains'
+    'lodash-amd/modern/collection/contains'
   ], function (
@@ -5,0 +5,0 @@ element,

src/plugins/core/formatters/plain-text/escape-html-characters.js

 define([
-  'lodash-amd/modern/utilities/escape'
+  'lodash-amd/modern/string/escape'
 ], function (
@@ -4,0 +4,0 @@ escape

src/transaction-manager.js

@@ -1,2 +0,2 @@
-define(['lodash-amd/modern/objects/assign'], function (assign) {
+define(['lodash-amd/modern/object/assign'], function (assign) {
 
@@ -3,0 +3,0 @@ 'use strict';

test/unit/event-emitter.spec.js

@@ -41,2 +41,12 @@ require('node-amd-require')({
   });
+
+  it('should remove listeners when off is called', function(){
+    var handle = sinon.spy();
+    emitter.on('event', handle);
+    emitter.trigger('event');
+    emitter.off('event', handle);
+    emitter.trigger('event');
+
+    expect(handle.callCount).to.equal(1);
+  })
 });

No alert changes

Improved metrics

Total package byte prevSize

198145

increased by0.17%

Lines of code

4125

increased by0.19%

No dependency changes