sling-framework - npm Package Compare versions

Comparing version 1.12.0 to 1.12.2

dist/cjs/es5/framework/withEventDispatch.js

@@ -48,2 +48,3 @@ "use strict";
         value: function dispatchEventAndMethod(evtName, detail) {
+          var target = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : this;
           var event = new CustomEvent(evtName, {
@@ -53,4 +54,4 @@ bubbles: true,
           });
-          var method = this["on".concat(evtName)];
-          this.dispatchEvent(event);
+          var method = target["on".concat(evtName)];
+          target.dispatchEvent(event);
 
@@ -57,0 +58,0 @@ if ((0, _slingHelpers.isFunction)(method)) {

dist/cjs/es5/v1/src/basic/withEventDispatch.js

@@ -30,2 +30,3 @@ "use strict";
   var Base = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : HTMLElement;
+  var CusEvent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : CustomEvent;
   return (
@@ -49,8 +50,9 @@ /*#__PURE__*/
         value: function dispatchEventAndMethod(evtName, detail) {
-          var event = new CustomEvent(evtName, {
+          var target = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : this;
+          var event = new CusEvent(evtName, {
             bubbles: true,
             detail: detail
           });
-          var method = this["on".concat(evtName)];
-          this.dispatchEvent(event);
+          var method = target["on".concat(evtName)];
+          target.dispatchEvent(event);
 
@@ -57,0 +59,0 @@ if ((0, _slingHelpers.isFunction)(method)) {

dist/cjs/es5/v1/src/business/withLoadingAndErrorHandling.js

@@ -74,3 +74,3 @@ "use strict";
           }).catch(function (err) {
-            _this2.requestErrors = _toConsumableArray(_this2.requestErrors).concat([err]);
+            _this2.requestErrors = [].concat(_toConsumableArray(_this2.requestErrors), [err]);
 
@@ -109,2 +109,3 @@ _this2.dispatchEventAndMethod('requesterror', {
         value: function request(oneOrManyRequests) {
+          this.requestErrors = [];
           var requestSingle = this.requestSingle.bind(this);
@@ -111,0 +112,0 @@

dist/cjs/es5/v1/src/business/withRequestParams.js

@@ -89,3 +89,3 @@ "use strict";
         get: function get() {
-          return _toConsumableArray(_get(_getPrototypeOf(_class2), "observedAttributes", this) || []).concat(_toConsumableArray(this.requestAttrNames));
+          return [].concat(_toConsumableArray(_get(_getPrototypeOf(_class2), "observedAttributes", this) || []), _toConsumableArray(this.requestAttrNames));
         }
@@ -92,0 +92,0 @@ }]);

dist/cjs/es6/framework/withEventDispatch.js

@@ -16,3 +16,3 @@ "use strict";
 
-  dispatchEventAndMethod(evtName, detail) {
+  dispatchEventAndMethod(evtName, detail, target = this) {
     const event = new CustomEvent(evtName, {
@@ -22,4 +22,4 @@ bubbles: true,
     });
-    const method = this[`on${evtName}`];
-    this.dispatchEvent(event);
+    const method = target[`on${evtName}`];
+    target.dispatchEvent(event);
 
@@ -26,0 +26,0 @@ if ((0, _slingHelpers.isFunction)(method)) {

dist/cjs/es6/v1/src/basic/withEventDispatch.js

@@ -10,3 +10,3 @@ "use strict";
 
-const withEventDispatch = (Base = HTMLElement) => class extends Base {
+const withEventDispatch = (Base = HTMLElement, CusEvent = CustomEvent) => class extends Base {
   constructor() {
@@ -17,9 +17,9 @@ super();
 
-  dispatchEventAndMethod(evtName, detail) {
-    const event = new CustomEvent(evtName, {
+  dispatchEventAndMethod(evtName, detail, target = this) {
+    const event = new CusEvent(evtName, {
       bubbles: true,
       detail
     });
-    const method = this[`on${evtName}`];
-    this.dispatchEvent(event);
+    const method = target[`on${evtName}`];
+    target.dispatchEvent(event);
 
@@ -26,0 +26,0 @@ if ((0, _slingHelpers.isFunction)(method)) {

dist/cjs/es6/v1/src/business/withLoadingAndErrorHandling.js

@@ -51,2 +51,3 @@ "use strict";
   request(oneOrManyRequests) {
+    this.requestErrors = [];
     const requestSingle = this.requestSingle.bind(this);
@@ -53,0 +54,0 @@

dist/es/es5/framework/withEventDispatch.js

@@ -40,2 +40,3 @@ function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
         value: function dispatchEventAndMethod(evtName, detail) {
+          var target = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : this;
           var event = new CustomEvent(evtName, {
@@ -45,4 +46,4 @@ bubbles: true,
           });
-          var method = this["on".concat(evtName)];
-          this.dispatchEvent(event);
+          var method = target["on".concat(evtName)];
+          target.dispatchEvent(event);
 
@@ -49,0 +50,0 @@ if (isFunction(method)) {

dist/es/es5/v1/src/basic/withEventDispatch.js

@@ -22,2 +22,3 @@ function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
   var Base = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : HTMLElement;
+  var CusEvent = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : CustomEvent;
   return (
@@ -41,8 +42,9 @@ /*#__PURE__*/
         value: function dispatchEventAndMethod(evtName, detail) {
-          var event = new CustomEvent(evtName, {
+          var target = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : this;
+          var event = new CusEvent(evtName, {
             bubbles: true,
             detail: detail
           });
-          var method = this["on".concat(evtName)];
-          this.dispatchEvent(event);
+          var method = target["on".concat(evtName)];
+          target.dispatchEvent(event);
 
@@ -49,0 +51,0 @@ if (isFunction(method)) {

dist/es/es5/v1/src/business/withLoadingAndErrorHandling.js

@@ -67,3 +67,3 @@ function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
           }).catch(function (err) {
-            _this2.requestErrors = _toConsumableArray(_this2.requestErrors).concat([err]);
+            _this2.requestErrors = [].concat(_toConsumableArray(_this2.requestErrors), [err]);
 
@@ -102,2 +102,3 @@ _this2.dispatchEventAndMethod('requesterror', {
         value: function request(oneOrManyRequests) {
+          this.requestErrors = [];
           var requestSingle = this.requestSingle.bind(this);
@@ -104,0 +105,0 @@

dist/es/es5/v1/src/business/withRequestParams.js

@@ -82,3 +82,3 @@ function _typeof(obj) { if (typeof Symbol === "function" && typeof Symbol.iterator === "symbol") { _typeof = function _typeof(obj) { return typeof obj; }; } else { _typeof = function _typeof(obj) { return obj && typeof Symbol === "function" && obj.constructor === Symbol && obj !== Symbol.prototype ? "symbol" : typeof obj; }; } return _typeof(obj); }
         get: function get() {
-          return _toConsumableArray(_get(_getPrototypeOf(_class2), "observedAttributes", this) || []).concat(_toConsumableArray(this.requestAttrNames));
+          return [].concat(_toConsumableArray(_get(_getPrototypeOf(_class2), "observedAttributes", this) || []), _toConsumableArray(this.requestAttrNames));
         }
@@ -85,0 +85,0 @@ }]);

dist/es/es6/framework/withEventDispatch.js

@@ -11,3 +11,3 @@ import { isFunction } from 'sling-helpers';
 
-    dispatchEventAndMethod(evtName, detail) {
+    dispatchEventAndMethod(evtName, detail, target = this) {
       const event = new CustomEvent(evtName, {
@@ -18,5 +18,5 @@ bubbles: true,
 
-      const method = this[`on${evtName}`];
+      const method = target[`on${evtName}`];
 
-      this.dispatchEvent(event);
+      target.dispatchEvent(event);
 
@@ -23,0 +23,0 @@ if (isFunction(method)) {

dist/es/es6/v1/src/basic/withEventDispatch.js

 import { isFunction } from 'sling-helpers';
 
-export const withEventDispatch = (Base = HTMLElement) =>
+export const withEventDispatch = (Base = HTMLElement, CusEvent = CustomEvent) =>
   class extends Base {
@@ -11,4 +11,4 @@ constructor() {
 
-    dispatchEventAndMethod(evtName, detail) {
-      const event = new CustomEvent(evtName, {
+    dispatchEventAndMethod(evtName, detail, target = this) {
+      const event = new CusEvent(evtName, {
         bubbles: true,
@@ -18,5 +18,5 @@ detail,
 
-      const method = this[`on${evtName}`];
+      const method = target[`on${evtName}`];
 
-      this.dispatchEvent(event);
+      target.dispatchEvent(event);
 
@@ -23,0 +23,0 @@ if (isFunction(method)) {

dist/es/es6/v1/src/business/withLoadingAndErrorHandling.js

@@ -46,2 +46,3 @@ export const withLoadingAndErrorHandling = (Base = class {}) =>
     request(oneOrManyRequests) {
+      this.requestErrors = [];
       const requestSingle = this.requestSingle.bind(this);
@@ -48,0 +49,0 @@

package.json

 {
   "name": "sling-framework",
-  "version": "1.12.0",
+  "version": "1.12.2",
   "description": "Sling Framework",
@@ -10,4 +10,4 @@ "module": "src/index.js",
   "dependencies": {
-    "sling-helpers": "^1.12.0"
+    "sling-helpers": "^1.12.2"
   }
 }

src/framework/withEventDispatch.js

@@ -11,3 +11,3 @@ import { isFunction } from 'sling-helpers';
 
-    dispatchEventAndMethod(evtName, detail) {
+    dispatchEventAndMethod(evtName, detail, target = this) {
       const event = new CustomEvent(evtName, {
@@ -18,5 +18,5 @@ bubbles: true,
 
-      const method = this[`on${evtName}`];
+      const method = target[`on${evtName}`];
 
-      this.dispatchEvent(event);
+      target.dispatchEvent(event);
 
@@ -23,0 +23,0 @@ if (isFunction(method)) {

src/v1/src/basic/withEventDispatch.js

 import { isFunction } from 'sling-helpers';
 
-export const withEventDispatch = (Base = HTMLElement) =>
+export const withEventDispatch = (Base = HTMLElement, CusEvent = CustomEvent) =>
   class extends Base {
@@ -11,4 +11,4 @@ constructor() {
 
-    dispatchEventAndMethod(evtName, detail) {
-      const event = new CustomEvent(evtName, {
+    dispatchEventAndMethod(evtName, detail, target = this) {
+      const event = new CusEvent(evtName, {
         bubbles: true,
@@ -18,5 +18,5 @@ detail,
 
-      const method = this[`on${evtName}`];
+      const method = target[`on${evtName}`];
 
-      this.dispatchEvent(event);
+      target.dispatchEvent(event);
 
@@ -23,0 +23,0 @@ if (isFunction(method)) {

src/v1/src/business/withLoadingAndErrorHandling.js

@@ -46,2 +46,3 @@ export const withLoadingAndErrorHandling = (Base = class {}) =>
     request(oneOrManyRequests) {
+      this.requestErrors = [];
       const requestSingle = this.requestSingle.bind(this);
@@ -48,0 +49,0 @@

src/v1/src/business/withLoadingAndErrorHandling.spec.js

@@ -11,3 +11,3 @@ import chai from 'chai';
 
-describe('withLoading', () => {
+describe('withLoadingAndErrorHandling', () => {
   describe('#requestSingle()', () => {
@@ -14,0 +14,0 @@ let dummy;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1278213

increased by0.15%

Number of downloads

11

increased by120%

Lines of code

31133

increased by0.08%

Dependency changes

• Updatedsling-helpers@^1.12.2