undertaker-registry - npm Package Compare versions

Comparing version 0.0.3 to 0.0.4

index.js

 'use strict';
 
-function DefaultRegistry(){
-  if(this instanceof DefaultRegistry === false){
+function DefaultRegistry() {
+  if (this instanceof DefaultRegistry === false) {
     return new DefaultRegistry();
@@ -11,16 +11,16 @@ }
 
-DefaultRegistry.prototype.init = function init(taker){};
+DefaultRegistry.prototype.init = function init(taker) {};
 
-DefaultRegistry.prototype.get = function get(name){
+DefaultRegistry.prototype.get = function get(name) {
   return this._tasks[name];
 };
 
-DefaultRegistry.prototype.set = function set(name, fn){
-  this._tasks[name] = fn;
+DefaultRegistry.prototype.set = function set(name, fn) {
+  return this._tasks[name] = fn;
 };
 
-DefaultRegistry.prototype.tasks = function tasks(){
+DefaultRegistry.prototype.tasks = function tasks() {
   var self = this;
 
-  return Object.keys(this._tasks).reduce(function(tasks, name){
+  return Object.keys(this._tasks).reduce(function(tasks, name) {
     tasks[name] = self.get(name);
@@ -27,0 +27,0 @@ return tasks;

package.json

 {
   "name": "undertaker-registry",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "undertaker-registry ===================",
   "main": "index.js",
   "scripts": {
+    "lint": "eslint . && jscs index.js test/",
+    "pretest": "npm run lint",
     "test": "lab -cv"
@@ -11,3 +13,3 @@ },
     "type": "git",
-    "url": "https://github.com/phated/undertaker-registry"
+    "url": "https://github.com/gulpjs/undertaker-registry"
   },
@@ -23,9 +25,13 @@ "keywords": [
   "bugs": {
-    "url": "https://github.com/phated/undertaker-registry/issues"
+    "url": "https://github.com/gulpjs/undertaker-registry/issues"
   },
-  "homepage": "https://github.com/phated/undertaker-registry",
+  "homepage": "https://github.com/gulpjs/undertaker-registry",
   "devDependencies": {
     "code": "^1.2.1",
-    "lab": "^5.2.0"
+    "eslint": "^1.7.3",
+    "eslint-config-gulp": "^2.0.0",
+    "jscs": "^2.4.0",
+    "jscs-preset-gulp": "^1.0.0",
+    "lab": "^6.2.0"
   }
 }

test/index.js

@@ -11,9 +11,9 @@ 'use strict';
 
-function noop(){}
+function noop() {}
 
-describe('undertaker-registry', function(){
+describe('undertaker-registry', function() {
 
-  describe('constructor', function(){
+  describe('constructor', function() {
 
-    it('can be constructed with new', function(done){
+    it('can be constructed with new', function(done) {
       var reg = new Registry();
@@ -26,3 +26,3 @@ expect(reg.get).to.be.a.function();
 
-    it('can be constructed without new', function(done){
+    it('can be constructed without new', function(done) {
       var reg = Registry();
@@ -36,5 +36,5 @@ expect(reg.get).to.be.a.function();
 
-  describe('init', function(){
+  describe('init', function() {
 
-    it('is a noop', function(done){
+    it('is a noop', function(done) {
       var reg = new Registry();
@@ -46,5 +46,5 @@ expect(reg.init).to.be.a.function();
 
-  describe('get', function(){
+  describe('get', function() {
 
-    it('returns a task from the registry', function(done){
+    it('returns a task from the registry', function(done) {
       var reg = new Registry();
@@ -57,5 +57,5 @@ reg._tasks.test = noop;
 
-  describe('set', function(){
+  describe('set', function() {
 
-    it('registers a task', function(done){
+    it('registers a task', function(done) {
       var reg = new Registry();
@@ -66,7 +66,14 @@ reg.set('test', noop);
     });
+
+    it('returns the task (useful for inheriting)', function(done) {
+      var reg = new Registry();
+      var task = reg.set('test', noop);
+      expect(task).to.equal(noop);
+      done();
+    });
   });
 
-  describe('tasks', function(){
+  describe('tasks', function() {
 
-    it('returns an object of task name->functions', function(done){
+    it('returns an object of task name->functions', function(done) {
       var reg = new Registry();
@@ -73,0 +80,0 @@ reg.set('test1', noop);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

5185

increased by11.48%

Number of package files

10

increased by42.86%

Lines of code

85

increased by7.59%

Worsened metrics

Dev dependency count

6

increased by200%

No dependency changes