victory-pie - npm Package Compare versions

Comparing version 11.4.1 to 11.4.2

CHANGELOG.md

 # VictoryPie Changelog
 
+## 11.4.2 (2017-08-14)
+
+- [153](https://github.com/FormidableLabs/victory-pie/pull/153) Bugfix for axymmetric padding
+
 ## 11.4.1 (2017-08-07)
@@ -4,0 +8,0 @@

es/components/helper-methods.js

@@ -97,8 +97,5 @@ import _omit from "lodash/omit";
     var radius = this.getRadius(props, padding);
-    var offsetWidth = width / 2 + padding.left - padding.right;
-    var offsetHeight = height / 2 + padding.top - padding.bottom;
-    var origin = {
-      x: offsetWidth + radius > width ? radius + padding.left - padding.right : offsetWidth,
-      y: offsetHeight + radius > height ? radius + padding.top - padding.bottom : offsetHeight
-    };
+    var offsetWidth = (radius + padding.left + (width - radius - padding.right)) / 2;
+    var offsetHeight = (radius + padding.top + (height - radius - padding.bottom)) / 2;
+    var origin = { x: offsetWidth, y: offsetHeight };
     var data = Data.getData(props);
@@ -105,0 +102,0 @@ var slices = this.getSlices(props, data);

lib/components/helper-methods.js

@@ -119,8 +119,5 @@ Object.defineProperty(exports, "__esModule", {
     var radius = this.getRadius(props, padding);
-    var offsetWidth = width / 2 + padding.left - padding.right;
-    var offsetHeight = height / 2 + padding.top - padding.bottom;
-    var origin = {
-      x: offsetWidth + radius > width ? radius + padding.left - padding.right : offsetWidth,
-      y: offsetHeight + radius > height ? radius + padding.top - padding.bottom : offsetHeight
-    };
+    var offsetWidth = (radius + padding.left + (width - radius - padding.right)) / 2;
+    var offsetHeight = (radius + padding.top + (height - radius - padding.bottom)) / 2;
+    var origin = { x: offsetWidth, y: offsetHeight };
     var data = _victoryCore.Data.getData(props);
@@ -127,0 +124,0 @@ var slices = this.getSlices(props, data);

package.json

 {
   "name": "victory-pie",
-  "version": "11.4.1",
+  "version": "11.4.2",
   "description": "D3 pie & donut chart component for React",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/components/helper-methods.js

@@ -84,8 +84,5 @@ /*eslint no-magic-numbers: ["error", { "ignore": [-1, 0, 1, 2, 45, 135, 180, 225, 315] }]*/
     const radius = this.getRadius(props, padding);
-    const offsetWidth = width / 2 + padding.left - padding.right;
-    const offsetHeight = height / 2 + padding.top - padding.bottom;
-    const origin = {
-      x: offsetWidth + radius > width ? radius + padding.left - padding.right : offsetWidth,
-      y: offsetHeight + radius > height ? radius + padding.top - padding.bottom : offsetHeight
-    };
+    const offsetWidth = ((radius + padding.left) + (width - radius - padding.right)) / 2;
+    const offsetHeight = ((radius + padding.top) + (height - radius - padding.bottom)) / 2;
+    const origin = { x: offsetWidth, y: offsetHeight };
     const data = Data.getData(props);
@@ -92,0 +89,0 @@ const slices = this.getSlices(props, data);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1325278

increased by0.15%

Lines of code

24011

increased by0.15%

No dependency changes