vizabi-barrankchart - npm Package Compare versions

Comparing version 3.3.1 to 3.3.2

build/barrankchart.js

@@ -8,3 +8,3 @@ // https://github.com/kuguarpwnz/vizabi-tool-bundler#readme v1.0.0 Copyright 2021 undefined
 
-  const {ICON_WARN, ICON_QUESTION} = VizabiSharedComponents.Icons;
+  const {ICON_QUESTION} = VizabiSharedComponents.Icons;
   const COLOR_BLACKISH = "rgb(51, 51, 51)";
@@ -95,10 +95,4 @@ const COLOR_WHITEISH = "rgb(253, 253, 253)";
 
-      <svg class="vzb-data-warning-svg">
-        <g class="vzb-data-warning vzb-noexport">
-          <svg></svg>
-          <text></text>
-        </g>
-        <g class="vzb-data-warning vzb-data-warning-missed-positions">
-          <text></text>
-        </g>
+      <svg class="vzb-br-footer">
+        <g class="vzb-datawarning-button vzb-noexport"></g>
       </svg>
@@ -137,5 +131,3 @@
     
-        footer: this.element.select(".vzb-data-warning-svg"),
-        dataWarning: this.element.select(".vzb-data-warning"),
-        missedPositionsWarning: this.element.select(".vzb-data-warning-missed-positions"),
+        footer: this.element.select(".vzb-br-footer"),
     
@@ -146,6 +138,2 @@ tooltipSvg: this.element.select(".vzb-br-tooltip-svg"),
 
-      this.wScale = d3.scaleLinear()
-        .domain(this.ui.datawarning.doubtDomain)
-        .range(this.ui.datawarning.doubtRange);
-
       this._cache = {};
@@ -191,4 +179,4 @@ }
 
+      this.addReaction(this._drawForecastOverlay);
       this.addReaction(this._updateFrameDisplay);
-      this.addReaction(this.updateDoubtOpacity);
     }
@@ -206,5 +194,6 @@
       this.DOM.forecastOverlay.classed("vzb-hidden", 
-        !this.MDL.frame.endBeforeForecast || 
-        !this.ui.showForecastOverlay || 
-        (this.MDL.frame.value <= this.MDL.frame.endBeforeForecast)
+      !this.ui.showForecast || 
+      !this.ui.showForecastOverlay || 
+      !this.ui.endBeforeForecast || 
+        (this.MDL.frame.value <= this.MDL.frame.parseValue(this.ui.endBeforeForecast))
       );
@@ -344,2 +333,4 @@ }
       const { margin } = this.profileConstants;
+      this.services.layout.size;
+      this.services.layout.projector;
 
@@ -349,32 +340,12 @@ this.DOM.footer
 
-      const warningBBox = this.DOM.dataWarning.select("text").node().getBBox();
-      this.DOM.dataWarning
-        .attr("transform", `translate(${this.width - margin.right - warningBBox.width}, ${warningBBox.height})`);
+      this.root.findChild({type: "_DataWarning"}).setOptions({
+        width: this.width,
+        height: this.height,
+        vertical: "top", 
+        horizontal: "right", 
+        right: margin.right
+      });
 
-      this.DOM.dataWarning
-        .select("svg")
-        .attr("width", warningBBox.height)
-        .attr("height", warningBBox.height)
-        .attr("x", -warningBBox.height - 5)
-        .attr("y", -warningBBox.height + 1);    
-
-      this.DOM.dataWarning.html(ICON_WARN)
-        .select("svg")
-        .attr("width", 0).attr("height", 0);
-
-      this.DOM.dataWarning.append("text")
-        .text(this.localise("hints/dataWarning"));
-
-      this.DOM.dataWarning
-        .on("click", () => this.parent.findChild({name: "datawarning"}).toggle())
-        .on("mouseover", () => this.updateDoubtOpacity(1))
-        .on("mouseout", () => this.updateDoubtOpacity());
     }
 
-    updateDoubtOpacity(opacity) {
-      if (opacity == null) opacity = this.wScale(this.MDL.frame.value.getUTCFullYear());
-      if (this.MDL.selected.any()) opacity = 1;
-      this.DOM.dataWarning.style("opacity", opacity);
-    }
-
     _getLabelText(d) {
@@ -729,7 +700,3 @@ const longestLabelLength = this.profileConstants.longestLabelLength;
     opacitySelectDim: 0.5,
-    opacityRegular: 1.0,
-    datawarning: {
-      doubtDomain: [1800, 1950, 2020],
-      doubtRange: [1.0, 0.8, 0.5]
-    },
+    opacityRegular: 1.0
   };
@@ -772,6 +739,7 @@
       },{
-        name: "datawarning",
         type: VizabiSharedComponents.DataWarning,
         placeholder: ".vzb-datawarning",
-        model: marker
+        options: {button: ".vzb-datawarning-button"},
+        model: marker,
+        name: "data-warning"
       },{
@@ -853,3 +821,3 @@ type: VizabiSharedComponents.DataNotes,
 
-  BarRankChart.versionInfo = { version: "1.0.0", build: 1618341355608 };
+  BarRankChart.versionInfo = { version: "1.0.0", build: 1618753336210 };
 
@@ -856,0 +824,0 @@ return BarRankChart;

package.json

 {
   "name": "vizabi-barrankchart",
-  "version": "3.3.1",
+  "version": "3.3.2",
   "description": "Bar rank chart tool for Vizabi 📊",
@@ -5,0 +5,0 @@ "scripts": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

88613

decreased by-4.63%

Lines of code

902

decreased by-3.22%

No dependency changes