vsm-dictionary-ensembl - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

package.json

 {
   "name": "vsm-dictionary-ensembl",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "description": "Implementation of a VSM-dictionary that uses the EBI search RESTful Web Services to interact with the Ensembl genome database",
@@ -5,0 +5,0 @@ "main": "src/DictionaryEnsembl.js",

README.md

@@ -84,3 +84,3 @@ # vsm-dictionary-ensembl
 ```
- https://www.ebi.ac.uk/ebisearch/ws/rest/ensembl_gene/entry/ENSG00000142208,ENSG00000185686,ENSG00000141510?fields=id%2Cname%2Cdescription%2Cgene_name%2Cgene_synonym%2Ctranscript_count%2Cspecies&format=json
+https://www.ebi.ac.uk/ebisearch/ws/rest/ensembl_gene/entry/ENSG00000142208,ENSG00000185686,ENSG00000141510?fields=id%2Cname%2Cdescription%2Cgene_name%2Cgene_synonym%2Ctranscript_count%2Cspecies&format=json
 ```
@@ -105,5 +105,5 @@
 
-Otherwise, we ask for all ids (no particular sorting offered) with this query:
+Otherwise, we ask for all ids (by default **id sorted**) with this query:
 ```
-https://www.ebi.ac.uk/ebisearch/ws/rest/ensembl_gene?query=domain_source:ensembl_gene&fields=id%2Cname%2Cdescription%2Cgene_name%2Cgene_synonym%2Ctranscript_count%2Cspecies&size=50&start=0&format=json
+https://www.ebi.ac.uk/ebisearch/ws/rest/ensembl_gene?query=domain_source:ensembl_gene&fields=id%2Cname%2Cdescription%2Cgene_name%2Cgene_synonym%2Ctranscript_count%2Cspecies&sort=id&size=50&start=0&format=json
 ```
@@ -110,0 +110,0 @@

src/DictionaryEnsembl.js

@@ -165,3 +165,3 @@ const Dictionary = require('vsm-dictionary');
         .replace('/entry/$ids', '?query=domain_source:' + this.ebiSearchDomain)
-        + '&fields=' + fixedEncodeURIComponent(this.ensemblFields);
+        + '&fields=' + fixedEncodeURIComponent(this.ensemblFields) + '&sort=id';
 
@@ -168,0 +168,0 @@ // add size and start URL parameters

src/DictionaryEnsembl.test.js

@@ -160,17 +160,18 @@ const DictionaryEnsembl = require('./DictionaryEnsembl');
       const formatURLPart = '&format=json';
+      const sortURLPart = '&sort=id';
       const URLfields = 'fields=id%2Cname%2Cdescription%2Cgene_name%2Cgene_synonym%2Ctranscript_count%2Cspecies';
       const expectedURL1 = testURLBase + '?query=' + getAllIDsURLPart
-        + '&' + URLfields + '&size=50&start=0' + formatURLPart;
+        + '&' + URLfields + sortURLPart + '&size=50&start=0' + formatURLPart;
       const expectedURL2 = testURLBase + '?query=' + getAllIDsURLPart
-        + '&' + URLfields + '&size=2&start=0' + formatURLPart;
+        + '&' + URLfields + sortURLPart + '&size=2&start=0' + formatURLPart;
       const expectedURL3 = testURLBase + '?query=' + getAllIDsURLPart
-        + '&' + URLfields + '&size=2&start=0' + formatURLPart;
+        + '&' + URLfields + sortURLPart + '&size=2&start=0' + formatURLPart;
       const expectedURL4 = testURLBase + '?query=' + getAllIDsURLPart
-        + '&' + URLfields + '&size=50&start=50' + formatURLPart;
+        + '&' + URLfields + sortURLPart + '&size=50&start=50' + formatURLPart;
       const expectedURL5 = testURLBase + '?query=' + getAllIDsURLPart
-        + '&' + URLfields + '&size=50&start=5000' + formatURLPart;
+        + '&' + URLfields + sortURLPart + '&size=50&start=5000' + formatURLPart;
       const expectedURL6 = testURLBase + '?query=' + getAllIDsURLPart
-        + '&' + URLfields + '&size=100&start=10000' + formatURLPart;
+        + '&' + URLfields + sortURLPart + '&size=100&start=10000' + formatURLPart;
       const expectedURL7 = testURLBase + '?query=' + getAllIDsURLPart
-        + '&' + URLfields + '&size=100&start=999999' + formatURLPart;
+        + '&' + URLfields + sortURLPart + '&size=100&start=999999' + formatURLPart;
       const expectedURL8 = testURLBase + '/entry/ENSG00000141510'
@@ -177,0 +178,0 @@ + '?' + URLfields + formatURLPart;

No alert changes

Improved metrics

Total package byte prevSize

143814

increased by0.11%

Lines of code

1113

increased by0.09%

No dependency changes