vuetify - npm Package Compare versions

Comparing version 0.6.9 to 0.6.11

package.json

 {
   "name": "vuetify",
-  "version": "0.6.9",
+  "version": "0.6.11",
   "author": {
@@ -5,0 +5,0 @@ "name": "John Leider",

src/components/grid/index.js

@@ -23,2 +23,3 @@ import { createSimpleFunctional } from '../../util/helpers'
       staticClass += ' container--fluid'
+      data.attrs.fluid = undefined
     }
@@ -35,2 +36,3 @@
 const ColSpacer = createSimpleFunctional('col--spacer')
+const Spacer = createSimpleFunctional('spacer')
 
@@ -42,3 +44,4 @@ export default {
   Content,
+  Spacer,
   Row
 }

src/components/tabs/index.js

@@ -6,13 +6,13 @@ import {
 import Tab from './Tab.vue'
-import TabContent from './TabContent.vue'
+import TabsItem from './TabsItem.vue'
 const Tabs = createSimpleFunctional('tabs')
-const TabsContainer = createSimpleFunctional('tabs__container')
-const TabsContentContainer = createSimpleFunctional('tabs__content-container')
+const TabsTabs = createSimpleFunctional('tabs__tabs')
+const TabsItems = createSimpleFunctional('tabs__items')
 
 export default {
   Tab,
-  TabsContainer,
-  TabContent,
-  TabsContentContainer,
-  Tabs
+  Tabs,
+  TabsItem,
+  TabsItems,
+  TabsTabs
 }

src/directives/badge.js

@@ -24,14 +24,5 @@ import {
 export default {
-  bind: (el, binding) => {
-    directive(el, binding)
-  },
-
-  updated: (el, binding) => {
-    directive(el, binding)
-  },
-
-  componentUpdated: (el, binding) => {
-    directive(el, binding)
-  },
-
+  bind: directive,
+  updated: directive,
+  componentUpdated: directive,
   unbind: (el) => {
@@ -38,0 +29,0 @@ el.removeAttribute('data-badge')

src/directives/dropdown.js

@@ -1,9 +0,10 @@
-import {
-  directiveConfig
-} from '../util/helpers'
-
-function dropdown (e, el, config, bus) {
+function dropdown (e, el, binding, bus, hover) {
   e.preventDefault()
 
-  const component = document.getElementById(config.value)
+  const component = document.getElementById(binding.arg)
+
+  if (!component.dataset.hover && hover) {
+    return
+  }
+
   let width = 0
@@ -13,3 +14,3 @@ let height = 0
   if (component.clientWidth > el.clientWidth
-      && component.hasAttribute('data-right')
+      && Boolean(component.dataset.right)
   ) {
@@ -19,3 +20,3 @@ width = component.clientWidth - el.clientWidth
 
-  if (config.bottom) {
+  if (component.dataset.bottom == true) {
     height = el.clientHeight
@@ -27,40 +28,20 @@ }
   component.style.top = `${el.offsetTop + height}px`
-  
-  bus.pub(`dropdown:open:${config.value}`)
+
+  bus.pub(`dropdown:open:${binding.arg}`)
 }
 
 function directive (el, binding, v) {
-  const config = directiveConfig(
-    binding,
-    {
-      hover: false
-    }
-  )
+  el.dataset.dropdown = binding.arg
 
-  el.dataset.dropdown = config.value
-
-  if (!config.hover) {
-    el.onclick = e => {
-      dropdown(e, el, config, v.context.$vuetify.bus)
-    }
-  } else {
-    el.onmouseenter = e => {
-      dropdown(e, el, config, v.context.$vuetify.bus)
-    }
-  }
+  // Directive binding happens before all components are rendered
+  // When changing routes, dropdown element may not be ready
+  // Do hover check within dropdown function
+  el.onclick = e => dropdown(e, el, binding, v.context.$vuetify.bus, false)
+  el.onmouseenter = e => dropdown(e, el, binding, v.context.$vuetify.bus, true)
 }
 
 export default {
-  bind (el, binding, v) {
-    directive(el, binding, v)
-  },
-
-  updated (el, binding, v) {
-    directive(el, binding, v)
-  },
-
-  componentUpdated (el, binding, v) {
-    directive(el, binding, v)
-  },
-
+  bind: directive,
+  updated: directive,
+  componentUpdated: directive,
   unbind (el) {
@@ -67,0 +48,0 @@ el.removeAttribute('onclick')

src/directives/modal.js

@@ -1,14 +0,8 @@
-import {
-  directiveConfig
-} from '../util/helpers'
-
 function directive (el, binding, v) {
-  const config = directiveConfig(binding)
+  el.dataset.modal = binding.arg
 
-  el.dataset.modal = config.value
-
   el.onclick = e => {
     e.preventDefault()
     
-    v.context.$vuetify.bus.pub(`modal:open:${config.value}`)
+    v.context.$vuetify.bus.pub(`modal:open:${binding.arg}`)
   }
@@ -18,14 +12,5 @@ }
 export default {
-  bind (el, binding, v) {
-    directive(el, binding, v)
-  },
-
-  updated (el, binding, v) {
-    directive(el, binding, v)
-  },
-
-  componentUpdated (el, binding, v) {
-    directive(el, binding, v)
-  },
-
+  bind: directive,
+  updated: directive,
+  componentUpdated: directive,
   unbind (el) {
@@ -32,0 +17,0 @@ el.removeAttribute('onclick')

src/directives/sidebar.js

@@ -1,14 +0,8 @@
-import {
-  directiveConfig
-} from '../util/helpers'
-
 function directive (el, binding, v) {
-  const config = directiveConfig(binding)
+  el.dataset.sidebar = binding.arg
 
-  el.dataset.sidebar = config.value
-
   el.onclick = e => {
     e.preventDefault()
     
-    v.context.$vuetify.bus.pub(`sidebar:toggle:${config.value}`)
+    v.context.$vuetify.bus.pub(`sidebar:toggle:${binding.arg}`)
   }
@@ -18,18 +12,9 @@ }
 export default {
-  bind (el, binding, v) {
-    directive(el, binding, v)
-  },
-
-  updated (el, binding, v) {
-    directive(el, binding, v)
-  },
-
-  componentUpdated (el, binding, v) {
-    directive(el, binding, v)
-  },
-
+  bind: directive,
+  updated: directive,
+  componentUpdated: directive,
   unbind (el) {
+    el.removeAttribute('onclick')
     el.removeAttribute('data-sidebar')
-    el.removeAttribute('onclick')
   }
 }

src/directives/tooltip.js

@@ -17,14 +17,5 @@ import {
 export default {
-  bind (el, binding) {
-    directive(el, binding)
-  },
-
-  updated (el, binding, v) {
-    directive(el, binding)
-  },
-
-  componentUpdated (el, binding) {
-    directive(el, binding)
-  },
-
+  bind: directive,
+  updated: directive,
+  componentUpdated: directive,
   unbind (el, binding) {
@@ -31,0 +22,0 @@ const config = directiveConfig(

src/index.js

@@ -32,5 +32,5 @@ import Bus from './util/bus'
 if (typeof window !== 'undefined' && window.Vue) {
-    window.Vue.use(plugin);
+  window.Vue.use(plugin);
 }
 
 module.exports = plugin

src/util/bus.js

@@ -6,3 +6,3 @@ import EventEmitter from 'events'
     super()
-    this.setMaxListeners(50)
+    this.setMaxListeners(500)
   }
@@ -13,7 +13,7 @@
     
-    if (type === 'object' || type === 'array') {
-      event.forEach(i => this.on(...i))
-    } else {
-      this.on(event, cb)
+    if (type !== 'object' && type !== 'array') {
+      return this.on(event, cb)
     }
+
+    event.forEach(i => this.on.apply(null, i))
   }
@@ -24,11 +24,11 @@
 
-    if (type === 'object' || type === 'array') {
-      event.forEach(i => this.removeListener(...i))
-    } else {
-      this.removeListener(event, cb)
+    if (type !== 'object' && type !== 'array') {
+      return this.removeListener(event, cb)
     }
+    
+    event.forEach(i => this.removeListener.apply(null, i))
   }
 
   pub () {
-    this.emit(...arguments)
+    this.emit.apply(null, arguments)
   }
@@ -35,0 +35,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

479159

increased by0.1%

Number of package files

127

increased by0.79%

Worsened metrics

Lines of code

5230

decreased by-0.21%

No dependency changes