		package browser

		import (
		"errors"
		"os/exec"
		)

		func openBrowser(url string) error {
		err := runCmd("xdg-open", url)
		if e, ok := err.(*exec.Error); ok && e.Err == exec.ErrNotFound {
		return errors.New("xdg-open: command not found - install xdg-utils from pkgsrc(7)")
		}
		return err
		}

+1

-1

.github/workflows/push.yml

		@@ -8,3 +8,3 @@ on: [push, pull_request]
		matrix:
		go: [ '1.13', '1.15' ]
		go: [ '1.14', '1.20' ]
		os: [ ubuntu-latest, macos-latest, windows-latest ]
		@@ -11,0 +11,0 @@ fail-fast: false

+0

-4

browser_darwin.go

		package browser

		import "os/exec"

		func openBrowser(url string) error {
		return runCmd("open", url)
		}

		func setFlags(cmd *exec.Cmd) {}

+0

-2

browser_freebsd.go

		@@ -16,3 +16,1 @@ package browser
		}

		func setFlags(cmd *exec.Cmd) {}

+0

-2

browser_linux.go

		@@ -22,3 +22,1 @@ package browser
		}

		func setFlags(cmd *exec.Cmd) {}

+0

-2

browser_openbsd.go

		@@ -16,3 +16,1 @@ package browser
		}

		func setFlags(cmd *exec.Cmd) {}

+1

-4

browser_unsupported.go

		@@ -1,2 +0,2 @@
		// +build !linux,!windows,!darwin,!openbsd,!freebsd
		// +build !linux,!windows,!darwin,!openbsd,!freebsd,!netbsd

		@@ -7,3 +7,2 @@ package browser
		"fmt"
		"os/exec"
		"runtime"
		@@ -15,3 +14,1 @@ )
		}

		func setFlags(cmd *exec.Cmd) {}

+2

-9

browser_windows.go

		@@ -1,14 +0,7 @@
		//go:generate mkwinsyscall -output zbrowser_windows.go browser_windows.go
		//sys shellExecute(hwnd int, verb string, file string, args string, cwd string, showCmd int) (err error) = shell32.ShellExecuteW
		package browser

		import "os/exec"
		import "golang.org/x/sys/windows"

		const sW_SHOWNORMAL = 1

		func openBrowser(url string) error {
		return shellExecute(0, "", url, "", "", sW_SHOWNORMAL)
		return windows.ShellExecute(0, nil, windows.StringToUTF16Ptr(url), nil, nil, windows.SW_SHOWNORMAL)
		}

		func setFlags(cmd *exec.Cmd) {
		}

+3

-9

browser.go

		// Package browser provides helpers to open files, readers, and urls in a browser window.
		//
		// The choice of which browser is started is entirely client dependant.
		// The choice of which browser is started is entirely client dependent.
		package browser
		@@ -33,3 +33,3 @@
		func OpenReader(r io.Reader) error {
		f, err := ioutil.TempFile("", "browser")
		f, err := ioutil.TempFile("", "browser.*.html")
		if err != nil {
		@@ -45,8 +45,3 @@ return fmt.Errorf("browser: could not create temporary file: %w", err)
		}
		oldname := f.Name()
		newname := oldname + ".html"
		if err := os.Rename(oldname, newname); err != nil {
		return fmt.Errorf("browser: renaming temporary file failed: %w", err)
		}
		return OpenFile(newname)
		return OpenFile(f.Name())
		}
		@@ -63,4 +58,3 @@
		cmd.Stderr = Stderr
		setFlags(cmd)
		return cmd.Run()
		}

+2

-2

go.mod

		module github.com/cli/browser

		go 1.13
		go 1.14

		require golang.org/x/sys v0.0.0-20210319071255-635bc2c9138d
		require golang.org/x/sys v0.0.0-20210616045830-e2b7044e8c71

+2

-2

go.sum

		@@ -1,2 +0,2 @@
		golang.org/x/sys v0.0.0-20210319071255-635bc2c9138d h1:jbzgAvDZn8aEnytae+4ou0J0GwFZoHR0hOrTg4qH8GA=
		golang.org/x/sys v0.0.0-20210319071255-635bc2c9138d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
		golang.org/x/sys v0.0.0-20210616045830-e2b7044e8c71 h1:X/2sJAybVknnUnV7AD2HdT6rm2p5BP6eH2j+igduWgk=
		golang.org/x/sys v0.0.0-20210616045830-e2b7044e8c71/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=

-76

zbrowser_windows.go

		// Code generated by 'go generate'; DO NOT EDIT.

		package browser

		import (
		"syscall"
		"unsafe"

		"golang.org/x/sys/windows"
		)

		var _ unsafe.Pointer

		// Do the interface allocations only once for common
		// Errno values.
		const (
		errnoERROR_IO_PENDING = 997
		)

		var (
		errERROR_IO_PENDING error = syscall.Errno(errnoERROR_IO_PENDING)
		errERROR_EINVAL error = syscall.EINVAL
		)

		// errnoErr returns common boxed Errno values, to prevent
		// allocations at runtime.
		func errnoErr(e syscall.Errno) error {
		switch e {
		case 0:
		return errERROR_EINVAL
		case errnoERROR_IO_PENDING:
		return errERROR_IO_PENDING
		}
		// TODO: add more here, after collecting data on the common
		// error values see on Windows. (perhaps when running
		// all.bat?)
		return e
		}

		var (
		modshell32 = windows.NewLazySystemDLL("shell32.dll")

		procShellExecuteW = modshell32.NewProc("ShellExecuteW")
		)

		func shellExecute(hwnd int, verb string, file string, args string, cwd string, showCmd int) (err error) {
		var _p0 *uint16
		_p0, err = syscall.UTF16PtrFromString(verb)
		if err != nil {
		return
		}
		var _p1 *uint16
		_p1, err = syscall.UTF16PtrFromString(file)
		if err != nil {
		return
		}
		var _p2 *uint16
		_p2, err = syscall.UTF16PtrFromString(args)
		if err != nil {
		return
		}
		var _p3 *uint16
		_p3, err = syscall.UTF16PtrFromString(cwd)
		if err != nil {
		return
		}
		return _shellExecute(hwnd, _p0, _p1, _p2, _p3, showCmd)
		}

		func _shellExecute(hwnd int, verb uint16, file uint16, args uint16, cwd uint16, showCmd int) (err error) {
		r1, _, e1 := syscall.Syscall6(procShellExecuteW.Addr(), 6, uintptr(hwnd), uintptr(unsafe.Pointer(verb)), uintptr(unsafe.Pointer(file)), uintptr(unsafe.Pointer(args)), uintptr(unsafe.Pointer(cwd)), uintptr(showCmd))
		if r1 == 0 {
		err = errnoErr(e1)
		}
		return
		}