@3mo/checkbox-group - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

dist/CheckboxGroup.d.ts

@@ -6,2 +6,4 @@ import { Checkbox } from '@3mo/checkbox';
  *
+ * @ssr true
+ *
  * @attr direction
@@ -14,6 +16,7 @@ */
     private set childrenSelected(value);
-    protected changed: () => CheckboxSelection;
+    protected handleChanged(): void;
     static get styles(): import("@a11d/lit").CSSResult;
     protected get template(): import("lit-html").HTMLTemplateResult;
     private readonly handleSlotChange;
+    private updateValue;
 }
@@ -20,0 +23,0 @@ declare global {

dist/CheckboxGroup.js

@@ -7,2 +7,4 @@ import { __decorate } from "tslib";
  *
+ * @ssr true
+ *
  * @attr direction
@@ -14,14 +16,13 @@ */
         this.direction = 'vertical';
-        this.changed = () => this.childrenSelected = this.selected;
         this.handleSlotChange = () => {
-            const updateValue = () => {
-                const selected = this.childrenSelected;
-                if (selected !== this.selected) {
-                    this.selected = selected;
-                    this.change.dispatch(selected);
-                }
-            };
-            updateValue();
-            this.checkboxes.forEach(checkbox => checkbox.change.subscribe(updateValue));
+            this.updateValue();
+            this.checkboxes.forEach(checkbox => checkbox.change.subscribe(this.updateValue));
         };
+        this.updateValue = () => {
+            const childrenSelected = this.childrenSelected;
+            if (childrenSelected !== this.selected) {
+                this.selected = childrenSelected;
+                this.change.dispatch(childrenSelected);
+            }
+        };
     }
@@ -53,2 +54,7 @@ get checkboxes() {
     }
+    handleChanged() {
+        // Whenever "selected" changes, wether by user interaction or by the children changing
+        // we need to update the childrenSelected state.
+        this.childrenSelected = this.selected;
+    }
     static get styles() {
@@ -83,3 +89,3 @@ return css `
     eventListener('change')
-], CheckboxGroup.prototype, "changed", void 0);
+], CheckboxGroup.prototype, "handleChanged", null);
 CheckboxGroup = __decorate([
@@ -86,0 +92,0 @@ component('mo-checkbox-group')

package.json

 {
 	"name": "@3mo/checkbox-group",
-	"version": "0.1.2",
+	"version": "0.1.3",
 	"description": "A checkbox-group web-component based on Material Web Components.",
@@ -5,0 +5,0 @@ "repository": {

README.md

 # CheckboxGroup
 
 A checkbox-group web-component based on Material Web Components.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

79544

increased by1.84%

Lines of code

115

increased by8.49%

No dependency changes