@applitools/nml-client - npm Package Compare versions

Comparing version 1.5.9 to 1.5.10

CHANGELOG.md

 # Changelog
 
+## [1.5.10](https://github.com/applitools/eyes.sdk.javascript1/compare/js/nml-client@1.5.9...js/nml-client@1.5.10) (2023-09-04)
+
+
+### Dependencies
+
+* @applitools/utils bumped to 1.6.0
+  #### Features
+
+  * add support for fallback in `req` ([#1899](https://github.com/applitools/eyes.sdk.javascript1/issues/1899)) ([d69c4b5](https://github.com/applitools/eyes.sdk.javascript1/commit/d69c4b5830370c471dfc25b6e2caddca8b458df9))
+* @applitools/req bumped to 1.6.0
+  #### Features
+
+  * add support for fallback in `req` ([#1899](https://github.com/applitools/eyes.sdk.javascript1/issues/1899)) ([d69c4b5](https://github.com/applitools/eyes.sdk.javascript1/commit/d69c4b5830370c471dfc25b6e2caddca8b458df9))
+  * update testcafe ([#1884](https://github.com/applitools/eyes.sdk.javascript1/issues/1884)) ([104f1b6](https://github.com/applitools/eyes.sdk.javascript1/commit/104f1b6cc0d4f107ba46404383de2fa11fe99dcf))
+
+
+
+* @applitools/driver bumped to 1.14.0
+  #### Features
+
+  * update testcafe ([#1884](https://github.com/applitools/eyes.sdk.javascript1/issues/1884)) ([104f1b6](https://github.com/applitools/eyes.sdk.javascript1/commit/104f1b6cc0d4f107ba46404383de2fa11fe99dcf))
+
+
+
+* @applitools/logger bumped to 2.0.10
+
+* @applitools/spec-driver-webdriver bumped to 1.0.44
+
+
 ## [1.5.9](https://github.com/applitools/eyes.sdk.javascript1/compare/js/nml-client@1.5.8...js/nml-client@1.5.9) (2023-08-30)
@@ -4,0 +33,0 @@

dist/server/req-broker.js

@@ -28,2 +28,3 @@ "use strict";
 const req_1 = __importStar(require("@applitools/req"));
+const utils = __importStar(require("@applitools/utils"));
 function makeReqBroker({ settings, logger }) {
@@ -86,3 +87,2 @@ return (0, req_1.makeReq)({
         async afterResponse({ response }) {
-            var _a;
             if (response.status !== 200) {
@@ -94,6 +94,11 @@ throw new Error(`Something went wrong when communicating with the mobile application, please try running your test again (error code: ${response.status})`);
                 const result = JSON.parse(body);
-                if ((_a = result === null || result === void 0 ? void 0 : result.payload) === null || _a === void 0 ? void 0 : _a.error) {
-                    const error = new Error(`There was a problem when interacting with the mobile application. The provided error message was "${result.payload.error.message}" and had a stack trace of "${result.payload.error.stack}"`);
-                    error.nextPath = result.nextPath;
-                    throw error;
+                if (result === null || result === void 0 ? void 0 : result.payload) {
+                    const error = utils.types.isArray(result.payload)
+                        ? result.payload.find(payload => payload.error)
+                        : result.payload.error;
+                    if (error) {
+                        const nmlError = new Error(`There was a problem when interacting with the mobile application. The provided error message was "${error.message}" and had a stack trace of "${error.stack}"`);
+                        nmlError.nextPath = result.nextPath;
+                        throw nmlError;
+                    }
                 }
@@ -100,0 +105,0 @@ return { response, body };

dist/server/requests.js

@@ -33,6 +33,6 @@ "use strict";
 const utils = __importStar(require("@applitools/utils"));
-function makeNMLRequests({ settings, logger: defaultLogger, }) {
+function makeNMLRequests({ settings, logger: mainLogger, }) {
     let brokerUrl = settings.brokerUrl;
-    const req = (0, req_broker_1.makeReqBroker)({ settings, logger: defaultLogger });
-    const getSupportedRenderEnvironmentsWithCache = utils.general.cachify(getSupportedRenderEnvironments);
+    const req = (0, req_broker_1.makeReqBroker)({ settings, logger: mainLogger });
+    const getSupportedRenderEnvironmentsWithCache = utils.general.cachify(getSupportedRenderEnvironments, () => 'default');
     return {
@@ -48,3 +48,5 @@ getSupportedRenderEnvironments: getSupportedRenderEnvironmentsWithCache,
     }
-    async function takeScreenshots({ settings, logger = defaultLogger, }) {
+    async function takeScreenshots({ settings, logger = mainLogger, }) {
+        logger = logger.extend(mainLogger, { tags: [`nml-request-${utils.general.shortid()}`] });
+        logger.log('Request "takeScreenshots" called with settings', settings);
         const supportedRenderEnvironments = await getSupportedRenderEnvironmentsWithCache({ logger });
@@ -94,10 +96,9 @@ const { localEnvironment, renderEnvironments, rendererSettings } = settings.renderers.reduce((result, renderer) => {
             brokerUrl = result.nextPath;
-            if (localEnvironment) {
-                return [{ image: result.payload.result.screenshotUrl, renderEnvironment: localEnvironment }];
-            }
-            else {
-                return renderEnvironments.map((renderEnvironment, index) => {
+            const screenshots = localEnvironment
+                ? [{ image: result.payload.result.screenshotUrl, renderEnvironment: localEnvironment }]
+                : renderEnvironments.map((renderEnvironment, index) => {
                     return { image: result.payload[index].result.screenshotUrl, renderEnvironment };
                 });
-            }
+            logger.log('Request "takeScreenshots" finished successfully with body', screenshots);
+            return screenshots;
         }
@@ -110,3 +111,3 @@ catch (error) {
     }
-    async function takeSnapshots({ settings, logger = defaultLogger, }) {
+    async function takeSnapshots({ settings, logger = mainLogger, }) {
         try {
@@ -113,0 +114,0 @@ const response = await req(brokerUrl, {

package.json

 {
   "name": "@applitools/nml-client",
-  "version": "1.5.9",
+  "version": "1.5.10",
   "description": "Client to integrate the SDKs to the Native Mobile Library (NML)",
@@ -39,8 +39,8 @@ "homepage": "https://applitools.com",
   "dependencies": {
-    "@applitools/logger": "2.0.9",
-    "@applitools/req": "1.5.4",
-    "@applitools/utils": "1.5.2"
+    "@applitools/logger": "2.0.10",
+    "@applitools/req": "1.6.0",
+    "@applitools/utils": "1.6.0"
   },
   "devDependencies": {
-    "@applitools/spec-driver-webdriver": "^1.0.43",
+    "@applitools/spec-driver-webdriver": "^1.0.44",
     "@applitools/test-server": "^1.2.2",
@@ -47,0 +47,0 @@ "@applitools/test-utils": "^1.5.17",

types/server/requests.d.ts

@@ -16,5 +16,5 @@ import type { BrokerServerSettings, ScreenshotSettings, Screenshot, SnapshotSettings, IOSSnapshot, AndroidSnapshot } from '../types';
 }
-export declare function makeNMLRequests({ settings, logger: defaultLogger, }: {
+export declare function makeNMLRequests({ settings, logger: mainLogger, }: {
     settings: BrokerServerSettings;
     logger: Logger;
 }): NMLRequests;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

47964

increased by3.8%

Lines of code

494

increased by1.23%

Dependency changes

• + Added@applitools/logger@2.0.10(transitive)

• + Added@applitools/req@1.6.0(transitive)

• + Added@applitools/utils@1.6.0(transitive)

• - Removed@applitools/logger@2.0.9(transitive)

• - Removed@applitools/req@1.5.4(transitive)

• - Removed@applitools/utils@1.5.2(transitive)

• Updated@applitools/logger@2.0.10

• Updated@applitools/req@1.6.0

• Updated@applitools/utils@1.6.0