@architect/destroy - npm Package Compare versions

Comparing version 3.0.4-RC.0 to 3.0.4

changelog.md

@@ -11,2 +11,7 @@ # Architect Destroy changelog
 
+
+### Fixed
+
+- Fixed issue where destroying an environment with >9 env vars would fail; fixes #1351, thanks @pgte!
+
 ---
@@ -13,0 +18,0 @@

package.json

 {
   "name": "@architect/destroy",
-  "version": "3.0.4-RC.0",
+  "version": "3.0.4",
   "description": "Destroy projects created with Architect",
@@ -26,4 +26,4 @@ "main": "src/index.js",
   "dependencies": {
-    "@architect/inventory": "~3.2.0-RC.0",
-    "@architect/utils": "~3.1.1",
+    "@architect/inventory": "~3.2.0",
+    "@architect/utils": "~3.1.2",
     "aws-sdk": "2.1001.0",
@@ -35,9 +35,9 @@ "minimist": "~1.2.6",
   "devDependencies": {
-    "@architect/deploy": "~4.1.2",
+    "@architect/deploy": "~4.1.4",
     "@architect/eslint-config": "^2.0.1",
-    "aws-sdk-mock": "~5.6.2",
+    "aws-sdk-mock": "~5.7.0",
     "cross-env": "~7.0.3",
-    "eslint": "^8.15.0",
+    "eslint": "^8.21.0",
     "nyc": "~15.1.0",
-    "tap-arc": "~0.3.4",
+    "tap-arc": "~0.3.5",
     "tape": "~5.5.3"
@@ -44,0 +44,0 @@ },

src/_ssm.js

@@ -51,3 +51,4 @@ let aws = require('aws-sdk')
     // /<app-name>/<env>/* - environment variables via `arc env`
-    parallel([ `/${appname}/${env}`, `/${appname}/deploy` ].map(path => collectByPath.bind(null, path, null)), function paramsCollected (err, res) {
+    let paths = [ `/${appname}/${env}`, `/${appname}/deploy` ]
+    parallel(paths.map(path => collectByPath.bind(null, path, null)), function paramsCollected (err, res) {
       if (err) callback(err)
@@ -57,12 +58,15 @@ else {
         let Names = res.reduce((aggregate, current) => aggregate.concat(current), [])
-        // While unlikely, it's possible for an app to have no SSM params
-        // ... and when that happens, the following call will fail without things to delete
-        if (Names.length) {
-          // byebye
-          ssm.deleteParameters({ Names }, function deleteParameters (err) {
-            if (err) callback(err)
-            else callback()
-          })
+        function deleteThings () {
+          if (Names.length) {
+            // >10 SSM params in a call will fail
+            let chunk = Names.splice(0, 10)
+            ssm.deleteParameters({ Names: chunk }, function deleteParameters (err) {
+              if (err) callback(err)
+              else if (!Names.length) callback()
+              else deleteThings()
+            })
+          }
+          else callback()
         }
-        else callback()
+        deleteThings()
       }
@@ -69,0 +73,0 @@ })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

22042

increased by0.81%

Lines of code

455

increased by0.89%

Number of low quality alerts

1

decreased by-50%

Dependency changes

• Updated@architect/inventory@~3.2.0

• Updated@architect/utils@~3.1.2