@atlaskit/spinner - npm Package Compare versions

Comparing version 12.0.9 to 12.1.0

CHANGELOG.md

 # @atlaskit/spinner
 
+## 12.1.0
+
+### Minor Changes
+
+- [minor][808d37259d](https://bitbucket.org/atlassian/atlaskit-mk-2/commits/808d37259d):
+
+  Adding an optional prop `testId` that will set the attribute value `data-testid`. It will help products to write better integration and end to end tests.
+
 ## 12.0.9
@@ -4,0 +12,0 @@

dist/cjs/Spinner/index.js

@@ -68,3 +68,3 @@ "use strict";
         var phase = this.state.phase;
-        var _a = this.props, delay = _a.delay, invertColor = _a.invertColor, isCompleting = _a.isCompleting;
+        var _a = this.props, delay = _a.delay, invertColor = _a.invertColor, isCompleting = _a.isCompleting, testId = _a.testId;
         var size = this.validateSize();
@@ -77,3 +77,3 @@ var strokeWidth = Math.round(size / 10);
                 } },
-                react_1.default.createElement(styledContainer_1.default, { delay: delay / 1000, phase: phase, size: size },
+                react_1.default.createElement(styledContainer_1.default, { delay: delay / 1000, phase: phase, size: size, "data-testid": testId },
                     react_1.default.createElement(styledSvg_1.default, { focusable: "false", height: size, invertColor: invertColor, phase: phase, size: size, viewBox: "0 0 " + size + " " + size, width: size, xmlns: "http://www.w3.org/2000/svg" },
@@ -80,0 +80,0 @@ react_1.default.createElement("circle", { cx: size / 2, cy: size / 2, r: strokeRadius }))))));

dist/cjs/types.d.ts

@@ -14,2 +14,4 @@ export declare type Func = () => void;
     isCompleting: boolean;
+    /** A `testId` prop is provided for specified elements, which is a unique string that appears as a data attribute `data-testid` in the rendered code, serving as a hook for automated tests */
+    testId?: string;
 };
@@ -16,0 +18,0 @@ export declare type SpinnerPhases = 'DELAY' | 'ENTER' | 'IDLE' | 'LEAVE' | '';

dist/cjs/version.json

 {
 	"name": "@atlaskit/spinner",
-	"version": "12.0.9",
+	"version": "12.1.0",
 	"sideEffects": false
 }

dist/esm/Spinner/index.js

@@ -66,3 +66,3 @@ import { __extends, __makeTemplateObject } from "tslib";
         var phase = this.state.phase;
-        var _a = this.props, delay = _a.delay, invertColor = _a.invertColor, isCompleting = _a.isCompleting;
+        var _a = this.props, delay = _a.delay, invertColor = _a.invertColor, isCompleting = _a.isCompleting, testId = _a.testId;
         var size = this.validateSize();
@@ -75,3 +75,3 @@ var strokeWidth = Math.round(size / 10);
                 } },
-                React.createElement(Container, { delay: delay / 1000, phase: phase, size: size },
+                React.createElement(Container, { delay: delay / 1000, phase: phase, size: size, "data-testid": testId },
                     React.createElement(Svg, { focusable: "false", height: size, invertColor: invertColor, phase: phase, size: size, viewBox: "0 0 " + size + " " + size, width: size, xmlns: "http://www.w3.org/2000/svg" },
@@ -78,0 +78,0 @@ React.createElement("circle", { cx: size / 2, cy: size / 2, r: strokeRadius }))))));

dist/esm/types.d.ts

@@ -14,2 +14,4 @@ export declare type Func = () => void;
     isCompleting: boolean;
+    /** A `testId` prop is provided for specified elements, which is a unique string that appears as a data attribute `data-testid` in the rendered code, serving as a hook for automated tests */
+    testId?: string;
 };
@@ -16,0 +18,0 @@ export declare type SpinnerPhases = 'DELAY' | 'ENTER' | 'IDLE' | 'LEAVE' | '';

dist/esm/version.json

 {
 	"name": "@atlaskit/spinner",
-	"version": "12.0.9",
+	"version": "12.1.0",
 	"sideEffects": false
 }

package.json

 {
   "name": "@atlaskit/spinner",
-  "version": "12.0.9",
+  "version": "12.1.0",
   "description": "A React component that displays a spinning icon to show a loading state",
@@ -40,6 +40,10 @@ "license": "Apache-2.0",
     "@atlaskit/ssr": "^0.1.1",
+    "@atlaskit/webdriver-runner": "^0.1.0",
+    "@testing-library/react": "^8.0.1",
+    "jest-in-case": "^1.0.2",
     "enzyme": "^3.7.0",
     "react-dom": "^16.8.0",
-    "sinon": "^2.2.0"
+    "sinon": "^2.2.0",
+    "wait-for-expect": "^1.2.0"
   }
 }

No alert changes

Improved metrics

Total package byte prevSize

74226

1.24%

Lines of code

653

0.62%

Worsened metrics

Dev dependency count

11

57.14%

Number of package files

46

-2.13%

No dependency changes