@bitovi/objection-querystring-parser - npm Package Compare versions

Comparing version 0.1.4 to 0.1.5

helpers/validation.js

 function isNotValidInteger(number) {
-  return typeof number !== "number" || isNaN(number);
+  return !Number.isInteger(number) || number < 1;
 }
@@ -4,0 +4,0 @@

lib/parse-page.js

@@ -13,7 +13,9 @@ const {
       let { number, size } = page;
-      if (number) {
+      if (number != null) {
         //default size to 10 if undefined
         size = size ?? 10;
         if (isNotValidInteger(number) || isNotValidInteger(size)) {
-          errors.push("page[number] and page[size] should be integers");
+          errors.push(
+            "page[number] and page[size] should be positive integers"
+          );
         } else {
@@ -20,0 +22,0 @@ const offset = getOffsetByPageNumber(number, size);

package.json

 {
   "name": "@bitovi/objection-querystring-parser",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "",
@@ -20,3 +20,3 @@ "main": "index.js",
   "dependencies": {
-    "@bitovi/querystring-parser": "^0.6.4"
+    "@bitovi/querystring-parser": "^0.6.5"
   },
@@ -34,3 +34,3 @@ "devDependencies": {
   },
-  "gitHead": "acb488bc82bfa070edd6876b4ab82949e44e00cc"
+  "gitHead": "e6c78d07257affc6352a304eced33991e5688071"
 }

README.md

@@ -66,3 +66,3 @@ # objection-querystring-parser
 ```js
-const result = querystringParser.parse("page[number]=0&page[size]=10");
+const result = querystringParser.parse("page[number]=1&page[size]=10");
 console.log(result);
@@ -69,0 +69,0 @@ // {

test/parse-page.test.js

@@ -51,3 +51,3 @@ const parsePage = require("../lib/parse-page");
         results: [],
-        errors: ["page[number] and page[size] should be integers"],
+        errors: ["page[number] and page[size] should be positive integers"],
       },
@@ -62,3 +62,3 @@ },
         results: [],
-        errors: ["page[number] and page[size] should be integers"],
+        errors: ["page[number] and page[size] should be positive integers"],
       },
@@ -68,2 +68,20 @@ },
     {
+      title: "should return an error if a zero is passed as the page size",
+      parameters: [{ number: 0, size: 0 }, []],
+      expectedResults: {
+        results: [],
+        errors: ["page[number] and page[size] should be positive integers"],
+      },
+    },
+
+    {
+      title: "should return an error if a float is passed as the page size",
+      parameters: [{ number: 1.1, size: 1.2 }, []],
+      expectedResults: {
+        results: [],
+        errors: ["page[number] and page[size] should be positive integers"],
+      },
+    },
+
+    {
       title: "should return valid results for valid parameters",
@@ -70,0 +88,0 @@ parameters: [{ number: 3, size: 5 }, []],

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Lines of code

858

increased by2.14%

Worsened metrics

Total package byte prevSize

28977

decreased by-1.68%

Number of package files

16

decreased by-5.88%

Number of medium supply chain risk alerts

1

increased byInfinity%

Dependency changes

• Updated@bitovi/querystring-parser@^0.6.5