@ckeditor/ckeditor5-theme-lark - npm Package Compare versions

Comparing version 0.8.0 to 0.9.0

CHANGELOG.md

 Changelog
 =========
 
+## [0.9.0](https://github.com/ckeditor/ckeditor5-theme/compare/v0.8.0...v0.9.0) (2017-09-03)
+
+### Bug fixes
+
+* Disabled buttons should have a different look. Closes [#98](https://github.com/ckeditor/ckeditor5-theme/issues/98). ([afe111d](https://github.com/ckeditor/ckeditor5-theme/commit/afe111d))
+* The `.ck-reset` class should set `word-wrap` to `break-word` to make sure long words do not overflow. Closes [#105](https://github.com/ckeditor/ckeditor5-theme/issues/105). Closes ckeditor/ckeditor5[#462](https://github.com/ckeditor/ckeditor5-theme/issues/462). ([327c188](https://github.com/ckeditor/ckeditor5-theme/commit/327c188))
+* Toolbar items should not collapse when the toolbar is floating. Closes [#93](https://github.com/ckeditor/ckeditor5-theme/issues/93). ([b263d5f](https://github.com/ckeditor/ckeditor5-theme/commit/b263d5f))
+* Tooltips for disabled buttons should not be dimmed. Closes [#70](https://github.com/ckeditor/ckeditor5-theme/issues/70). ([d36bbe7](https://github.com/ckeditor/ckeditor5-theme/commit/d36bbe7))
+
+### Features
+
+* Added styles for UI components in read–only state. Closes [#100](https://github.com/ckeditor/ckeditor5-theme/issues/100). ([ddf3102](https://github.com/ckeditor/ckeditor5-theme/commit/ddf3102))
+
+### Other changes
+
+* Implemented `.ck-editor-toolbar-container` class to control balloon panels containing editor toolbars. Closes [#89](https://github.com/ckeditor/ckeditor5-theme/issues/89). ([cd7442b](https://github.com/ckeditor/ckeditor5-theme/commit/cd7442b))
+* Refactored tooltip styles to allow tooltips which are no longer pseudo-elements. Closes [#103](https://github.com/ckeditor/ckeditor5-theme/issues/103). ([c29246a](https://github.com/ckeditor/ckeditor5-theme/commit/c29246a))
+* The `.ck-balloon-panel` arrow styles need an update after recent `BalloonPanelView` refactoring. Closes [#95](https://github.com/ckeditor/ckeditor5-theme/issues/95). ([f95af00](https://github.com/ckeditor/ckeditor5-theme/commit/f95af00))
+
+### BREAKING CHANGES
+
+* The (`.ck-balloon-panel_arrow_nw`–`.ck-balloon-panel_arrow_ne`) and (`.ck-balloon-panel_arrow_sw`–`.ck-balloon-panel_arrow_se`) class pairs have been swapped to reflect the actual placement of the arrow with respect to the balloon.
+* `.ck-disabled` is no longer available as a standalone class due to differences in the implementation of the disabled state among the UI components. Use a mixin instead `.your-class.ck-disabled { [@include](https://github.com/include) ck-disabled; }` to keep the previous functionality (reduced `opacity`) or provide a custom implementation of the state.
+
+
 ## [0.8.0](https://github.com/ckeditor/ckeditor5-theme/compare/v0.7.0...v0.8.0) (2017-05-07)
@@ -5,0 +30,0 @@

gulpfile.js

@@ -6,3 +6,3 @@ /**
 
-/* jshint browser: false, node: true, strict: true */
+/* eslint-env node */
 
@@ -12,3 +12,4 @@ 'use strict';
 const gulp = require( 'gulp' );
-const ckeditor5Lint = require( '@ckeditor/ckeditor5-dev-lint' )( {
+const ckeditor5Lint = require( '@ckeditor/ckeditor5-dev-lint' );
+const options = {
 	// Files ignored by `gulp lint` task.
@@ -19,6 +20,6 @@ // Files from .gitignore will be added automatically during task execution.
 	]
-} );
+};
 
-gulp.task( 'lint', ckeditor5Lint.lint );
-gulp.task( 'lint-staged', ckeditor5Lint.lintStaged );
+gulp.task( 'lint', () => ckeditor5Lint.lint( options ) );
+gulp.task( 'lint-staged', () => ckeditor5Lint.lintStaged( options ) );
 gulp.task( 'pre-commit', [ 'lint-staged' ] );

package.json

 {
   "name": "@ckeditor/ckeditor5-theme-lark",
-  "version": "0.8.0",
+  "version": "0.9.0",
   "description": "A bright theme for CKEditor 5.",
   "keywords": [],
   "dependencies": {
-    "@ckeditor/ckeditor5-ui": "^0.9.0"
+    "@ckeditor/ckeditor5-ui": "^0.10.0"
   },
   "devDependencies": {
-    "@ckeditor/ckeditor5-basic-styles": "^0.8.1",
-    "@ckeditor/ckeditor5-dev-lint": "^2.0.2",
-    "@ckeditor/ckeditor5-utils": "^0.9.1",
-    "gulp": "^3.9.0",
+    "@ckeditor/ckeditor5-basic-styles": "^0.9.0",
+    "@ckeditor/ckeditor5-dev-lint": "^3.1.0",
+    "@ckeditor/ckeditor5-utils": "^0.10.0",
+    "eslint-config-ckeditor5": "^1.0.5",
+    "gulp": "^3.9.1",
     "guppy-pre-commit": "^0.4.0"
@@ -15,0 +16,0 @@ },

README.md

@@ -1,4 +0,5 @@
-Lark
+CKEditor 5 lark theme
 ========================================
 
+[![Join the chat at https://gitter.im/ckeditor/ckeditor5](https://badges.gitter.im/ckeditor/ckeditor5.svg)](https://gitter.im/ckeditor/ckeditor5?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![npm version](https://badge.fury.io/js/%40ckeditor%2Fckeditor5-theme-lark.svg)](https://www.npmjs.com/package/@ckeditor/ckeditor5-theme-lark)
@@ -5,0 +6,0 @@ [![Build Status](https://travis-ci.org/ckeditor/ckeditor5-theme-lark.svg?branch=master)](https://travis-ci.org/ckeditor/ckeditor5-theme-lark)

tests/manual/theme.js

@@ -20,2 +20,4 @@ /**
 import ToolbarSeparatorView from '@ckeditor/ckeditor5-ui/src/toolbar/toolbarseparatorview';
+import InputTextView from '@ckeditor/ckeditor5-ui/src/inputtext/inputtextview';
+import LabeledInputView from '@ckeditor/ckeditor5-ui/src/labeledinput/labeledinputview';
 
@@ -27,34 +29,60 @@ import boldIcon from '@ckeditor/ckeditor5-basic-styles/theme/icons/bold.svg';
 
-testUtils.createTestUIView( {
-	'iconPlain1':					'#icon-plain-1',
-	'iconPlain2':					'#icon-plain-2',
-	'iconColor1':					'#icon-color-1',
-	'iconColor2':					'#icon-color-2',
+class TextView extends View {
+	constructor() {
+		super();
 
-	'buttonStates':					'#button-states',
-	'buttonTypes':					'#button-types',
-	'buttonIcon':					'#button-icon',
-	'buttonCustom':					'#button-custom',
-	'buttonIconCustom':				'#button-icon-custom',
-	'buttonIconStates':				'#button-icon-states',
-	'buttonResponsive1':			'#button-responsive-1',
-	'buttonResponsive2':			'#button-responsive-2',
-	'buttonResponsive3':			'#button-responsive-3',
+		this.element = document.createTextNode( 'Sample text' );
+	}
+}
 
-	dropdown:						'#dropdown',
+class ToolbarNewlineView extends View {
+	constructor() {
+		super();
 
-	'toolbarText':					'#toolbar-text',
-	'toolbarButton':				'#toolbar-button',
-	'toolbarRounded':				'#toolbar-rounded',
-	'toolbarWrap':					'#toolbar-wrap',
-	'toolbarSeparator':				'#toolbar-separator',
-	'toolbarMultiRow':				'#toolbar-multi-row'
-} ).then( ui => {
-	renderIcon( ui );
-	renderButton( ui );
-	renderDropdown( ui );
-	renderToolbar( ui );
+		this.template = new Template( {
+			tag: 'span',
+			attributes: {
+				class: 'ck-toolbar__newline'
+			}
+		} );
+	}
+}
+
+const ui = testUtils.createTestUIView( {
+	'iconPlain1': '#icon-plain-1',
+	'iconPlain2': '#icon-plain-2',
+	'iconColor1': '#icon-color-1',
+	'iconColor2': '#icon-color-2',
+
+	'buttonStates': '#button-states',
+	'buttonTypes': '#button-types',
+	'buttonIcon': '#button-icon',
+	'buttonCustom': '#button-custom',
+	'buttonIconCustom': '#button-icon-custom',
+	'buttonIconStates': '#button-icon-states',
+	'buttonResponsive1': '#button-responsive-1',
+	'buttonResponsive2': '#button-responsive-2',
+	'buttonResponsive3': '#button-responsive-3',
+	'buttonTooltip': '#button-tooltip',
+
+	dropdown: '#dropdown',
+
+	'toolbarText': '#toolbar-text',
+	'toolbarButton': '#toolbar-button',
+	'toolbarRounded': '#toolbar-rounded',
+	'toolbarWrap': '#toolbar-wrap',
+	'toolbarSeparator': '#toolbar-separator',
+	'toolbarMultiRow': '#toolbar-multi-row',
+
+	'inputLabeled': '#input-labeled',
+	'inputReadOnly': '#input-read-only'
 } );
 
-function renderIcon( ui ) {
+renderIcon();
+renderButton();
+renderDropdown();
+renderToolbar();
+renderInput();
+
+function renderIcon() {
 	// --- In-text ------------------------------------------------------------
@@ -68,3 +96,3 @@
 
-function renderButton( ui ) {
+function renderButton() {
 	// --- States ------------------------------------------------------------
@@ -172,5 +200,21 @@
 	}
+
+	// --- Tooltip ------------------------------------------------------------
+
+	ui.buttonTooltip.add( button( {
+		label: 'This button has a tooltip (south)',
+		withText: true,
+		tooltip: 'The content of the tooltip',
+	} ) );
+
+	ui.buttonTooltip.add( button( {
+		label: 'This one too – north',
+		withText: true,
+		keystroke: 'Ctrl+N',
+		tooltip: true,
+		tooltipPosition: 'n'
+	} ) );
 }
 
-function renderDropdown( ui ) {
+function renderDropdown() {
 	// --- ListDropdown ------------------------------------------------------------
@@ -204,3 +248,3 @@
 
-function renderToolbar( ui ) {
+function renderToolbar() {
 	// --- Text ------------------------------------------------------------
@@ -288,10 +332,11 @@
 
-const TextView = class extends View {
-	constructor() {
-		super();
+function renderInput() {
+	ui.inputLabeled.add( input() );
+	ui.inputReadOnly.add( input( {
+		label: 'A read–only input',
+		isReadOnly: true,
+		value: 'Read–only input value'
+	} ) );
+}
 
-		this.element = document.createTextNode( 'Sample text' );
-	}
-};
-
 function text() {
@@ -313,3 +358,5 @@ return new TextView();
 	withText = true,
+	keystroke = null,
 	tooltip,
+	tooltipPosition = 's',
 	icon
@@ -319,3 +366,3 @@ } = {} ) {
 
-	button.set( { label, isEnabled, isOn, withText, icon, tooltip } );
+	button.set( { label, isEnabled, isOn, withText, icon, keystroke, tooltip, tooltipPosition } );
 
@@ -350,17 +397,16 @@ return button;
 
-const ToolbarNewlineView = class extends View {
-	constructor() {
-		super();
-
-		this.template = new Template( {
-			tag: 'span',
-			attributes: {
-				class: 'ck-toolbar__newline'
-			}
-		} );
-	}
-};
-
 function toolbarNewLine() {
 	return new ToolbarNewlineView();
 }
+
+function input( {
+	label = 'Labeled input',
+	isReadOnly = false,
+	value = 'The value of the input'
+} = {} ) {
+	const labeledInput = new LabeledInputView( {}, InputTextView );
+
+	labeledInput.set( { isReadOnly, label, value } );
+
+	return labeledInput;
+}

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

42696

increased by7.03%

Lines of code

355

increased by15.26%

Number of lines in readme file

16

increased by6.67%

Worsened metrics

Dev dependency count

6

increased by20%

Number of package files

35

decreased by-5.41%

Dependency changes

• + Added@ckeditor/ckeditor5-ui@0.10.0(transitive)

• + Added@ckeditor/ckeditor5-utils@0.10.0(transitive)

• - Removed@ckeditor/ckeditor5-ui@0.9.0(transitive)

• - Removed@ckeditor/ckeditor5-utils@0.9.1(transitive)

• Updated@ckeditor/ckeditor5-ui@^0.10.0