@cloudflare/component-listener - npm Package Compare versions

Comparing version 1.1.166 to 1.1.167

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [1.1.167](http://stash.cfops.it:7999/fe/stratus/compare/@cloudflare/component-listener@1.1.166...@cloudflare/component-listener@1.1.167) (2020-07-01)
+
+
+### Bug Fixes
+
+* **component-listener:** EW-3440 bail on keydown if not a KeyboardEvent ([6dddff0](http://stash.cfops.it:7999/fe/stratus/commits/6dddff0))
+
+
+
+
+
 ## [1.1.166](http://stash.cfops.it:7999/fe/stratus/compare/@cloudflare/component-listener@1.1.165...@cloudflare/component-listener@1.1.166) (2020-06-30)
@@ -8,0 +19,0 @@

es/useKeyListener.js

@@ -35,2 +35,9 @@ import { useCallback, useMemo } from 'react';
   var handler = useCallback(function (e) {
+    if (!(e instanceof KeyboardEvent)) {
+      // If Chrome autofills an input, it fires a "keydown" event of type Event
+      // instead of KeyboardEvent, so e.key will be undefined.
+      // https://bugs.chromium.org/p/chromium/issues/detail?id=739792
+      return;
+    }
+
     if (keyName.toLowerCase() === e.key.toLowerCase() && shiftKey === e.shiftKey && altKey === e.altKey && ctrlKey === e.ctrlKey && metaKey === e.metaKey) {
@@ -37,0 +44,0 @@ if (!passive) {

lib/useKeyListener.js

@@ -47,2 +47,9 @@ "use strict";
   var handler = (0, _react.useCallback)(function (e) {
+    if (!(e instanceof KeyboardEvent)) {
+      // If Chrome autofills an input, it fires a "keydown" event of type Event
+      // instead of KeyboardEvent, so e.key will be undefined.
+      // https://bugs.chromium.org/p/chromium/issues/detail?id=739792
+      return;
+    }
+
     if (keyName.toLowerCase() === e.key.toLowerCase() && shiftKey === e.shiftKey && altKey === e.altKey && ctrlKey === e.ctrlKey && metaKey === e.metaKey) {
@@ -49,0 +56,0 @@ if (!passive) {

package.json

 {
   "name": "@cloudflare/component-listener",
   "description": "",
-  "version": "1.1.166",
+  "version": "1.1.167",
   "types": "./dist/index.d.ts",
@@ -40,3 +40,3 @@ "main": "lib/index.js",
   },
-  "gitHead": "8ec91a3eb4520384b989d73f41c21ca9624baeb2"
+  "gitHead": "3b1aa22e14c287020685e182527214a8795cbf43"
 }

No alert changes

Improved metrics

Total package byte prevSize

71709

1.22%

Lines of code

930

1.31%

No dependency changes