@cloudflare/eslint-plugin-sparrow - npm Package Compare versions

Comparing version 0.2.2 to 0.3.0

CHANGELOG.md

@@ -6,3 +6,14 @@ # Change Log
 
-  <a name="0.2.2"></a>
+      <a name="0.3.0"></a>
+# [0.3.0](http://stash.cfops.it:7999/fe/stratus/compare/@cloudflare/eslint-plugin-sparrow@0.2.2...@cloudflare/eslint-plugin-sparrow@0.3.0) (2018-10-30)
+
+
+### Features
+
+* **eslint-plugin-sparrow:** PINT-108:Add support for spread syntax ([719aaed](http://stash.cfops.it:7999/fe/stratus/commits/719aaed))
+
+
+
+
+      <a name="0.2.2"></a>
 ## [0.2.2](http://stash.cfops.it:7999/fe/stratus/compare/@cloudflare/eslint-plugin-sparrow@0.2.1...@cloudflare/eslint-plugin-sparrow@0.2.2) (2018-10-29)
@@ -15,3 +26,3 @@
 
-  <a name="0.2.1"></a>
+<a name="0.2.1"></a>
 ## [0.2.1](http://stash.cfops.it:7999/fe/stratus/compare/@cloudflare/eslint-plugin-sparrow@0.2.0...@cloudflare/eslint-plugin-sparrow@0.2.1) (2018-10-26)
@@ -18,0 +29,0 @@

es/rules/no-missing-category.js

@@ -17,3 +17,5 @@ /**
   return object.properties.some(function (property) {
-    return property.key.name === keyToFind || property.key.value;
+    // We check for property.key to avoid failures on spread syntax
+    // i.e. spread syntax has no property.key
+    return property.key && (property.key.name === keyToFind || property.key.value === keyToFind);
   });
@@ -20,0 +22,0 @@ }

lib/rules/no-missing-category.js

@@ -17,3 +17,5 @@ /**
   return object.properties.some(function (property) {
-    return property.key.name === keyToFind || property.key.value;
+    // We check for property.key to avoid failures on spread syntax
+    // i.e. spread syntax has no property.key
+    return property.key && (property.key.name === keyToFind || property.key.value === keyToFind);
   });
@@ -20,0 +22,0 @@ }

package.json

 {
   "name": "@cloudflare/eslint-plugin-sparrow",
   "description": "A list of recommended rules for @cloudflare/util-sparrow",
-  "version": "0.2.2",
+  "version": "0.3.0",
   "keywords": [
@@ -6,0 +6,0 @@ "eslint",

src/rules/no-missing-category.js

@@ -18,3 +18,8 @@ /**
   return object.properties.some(function(property) {
-    return property.key.name === keyToFind || property.key.value;
+    // We check for property.key to avoid failures on spread syntax
+    // i.e. spread syntax has no property.key
+    return (
+      property.key &&
+      (property.key.name === keyToFind || property.key.value === keyToFind)
+    );
   });
@@ -21,0 +26,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

12816

6.6%

Lines of code

229

4.09%

No dependency changes