@creamery/socket.io-rpc - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

lib/common.d.ts

@@ -25,5 +25,6 @@ /// <reference types="socket.io-client" />
 export interface ResponseError {
-    code: number;
+    code?: number;
+    name?: string;
     message: string;
     data?: any;
 }

lib/rpc-server.d.ts

 import SocketIO from 'socket.io';
 import { Vendor } from './common';
-export declare function NotFoundResponse(id: string): {
+export declare function NotFoundResponse(id: string, method: string): {
     id: string;
+    method: string;
     error: {
@@ -10,11 +11,14 @@ code: number;
 };
-export declare function ErrorResponse(id: string, err: Error): {
+export declare function ErrorResponse(id: string, method: string, err: Error): {
     id: string;
+    method: string;
     error: {
-        code: number;
+        code: any;
+        name: string;
         message: string;
     };
 };
-export declare function SuccessResponse(id: string, result: any): {
+export declare function SuccessResponse(id: string, method: string, result: any): {
     id: string;
+    method: string;
     result: any;
@@ -21,0 +25,0 @@ };

lib/rpc-server.js

@@ -7,5 +7,6 @@ "use strict";
 const socket_io_1 = __importDefault(require("socket.io"));
-function NotFoundResponse(id) {
+function NotFoundResponse(id, method) {
     return {
         id,
+        method,
         error: {
@@ -18,7 +19,9 @@ code: -32601,
 exports.NotFoundResponse = NotFoundResponse;
-function ErrorResponse(id, err) {
+function ErrorResponse(id, method, err) {
     return {
         id,
+        method,
         error: {
-            code: 1,
+            code: err.code || -32000,
+            name: err.name,
             message: err.message,
@@ -29,5 +32,6 @@ },
 exports.ErrorResponse = ErrorResponse;
-function SuccessResponse(id, result) {
+function SuccessResponse(id, method, result) {
     return {
         id,
+        method,
         result,
@@ -86,12 +90,16 @@ };
         if (typeof vendor[method] === 'function') {
-            vendor[method](...params)
-                .then((result) => {
-                callback(SuccessResponse(id, result));
-            })
-                .catch((err) => {
-                callback(ErrorResponse(id, err));
-            });
+            const p = vendor[method](...params);
+            if (typeof p.then === 'function' && typeof p.catch === 'function') {
+                p.then((result) => {
+                    callback(SuccessResponse(id, method, result));
+                }).catch((err) => {
+                    callback(ErrorResponse(id, method, err));
+                });
+            }
+            else {
+                callback(ErrorResponse(id, method, new Error(`faild: the method must return a promise.`)));
+            }
             return;
         }
-        callback(NotFoundResponse(id));
+        callback(NotFoundResponse(id, method));
     }
@@ -98,0 +106,0 @@ }

package.json

 {
   "name": "@creamery/socket.io-rpc",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "RPC for SocketIO",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

README.md

 # socket-io-rpc
 RPC for SocketIO
 
-
-send 427 
-receive 437
+基于 SocketIO 编写的 RPC 框架，主要功能是提供类似本地函数调用的编码体验。

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

16028

increased by6.5%

Lines of code

276

increased by4.94%

Worsened metrics

Number of lines in readme file

4

decreased by-33.33%

No dependency changes