@embroider/shared-internals - npm Package Compare versions

Comparing version 2.5.3-unstable.f30e685 to 2.6.0

package.json

 {
   "name": "@embroider/shared-internals",
-  "version": "2.5.3-unstable.f30e685",
+  "version": "2.6.0",
   "private": false,
@@ -27,5 +27,2 @@ "description": "Utilities shared among the other embroider packages",
   ],
-  "scripts": {
-    "test": "jest"
-  },
   "dependencies": {
@@ -40,2 +37,3 @@ "babel-import-util": "^2.0.0",
     "lodash": "^4.17.21",
+    "minimatch": "^3.0.4",
     "semver": "^7.3.5"
@@ -45,3 +43,2 @@ },
     "broccoli-node-api": "^1.7.0",
-    "@embroider/test-support": "workspace:*",
     "@types/babel__core": "^7.1.14",
@@ -53,2 +50,3 @@ "@types/babel__traverse": "^7.18.5",
     "@types/js-string-escape": "^1.0.0",
+    "@types/minimatch": "^3.0.4",
     "@types/semver": "^7.3.6",
@@ -58,7 +56,11 @@ "@types/tmp": "^0.1.0",
     "tmp": "^0.1.0",
-    "typescript": "^5.1.6"
+    "typescript": "^5.1.6",
+    "@embroider/test-support": "0.36.0"
   },
   "engines": {
     "node": "12.* || 14.* || >= 16"
+  },
+  "scripts": {
+    "test": "jest"
   }
-}
+}

src/ember-standard-modules.js

@@ -51,4 +51,2 @@ "use strict";
 exports.emberVirtualPackages.add('@glimmer/manager');
-// ember-data pre 4.12 failed to declare this as a peer dependency of @ember-data/debug
-exports.emberVirtualPeerDeps.add('@ember-data/store');
 // These are the known names that people use to import template precomiplation
@@ -55,0 +53,0 @@ // macros from.

src/index.d.ts

 export { AppMeta, AddonMeta, PackageInfo } from './metadata';
-export { explicitRelative, extensionsPattern, unrelativize, cleanUrl } from './paths';
+export { explicitRelative, extensionsPattern, unrelativize, cleanUrl, correspondingTemplate } from './paths';
 export { getOrCreate } from './get-or-create';
@@ -4,0 +4,0 @@ export { default as Package, V2AddonPackage as AddonPackage, V2AppPackage as AppPackage, V2Package } from './package';

src/index.js

@@ -20,3 +20,3 @@ "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.locateEmbroiderWorkingDir = exports.cacheBustingPluginVersion = exports.cacheBustingPluginPath = exports.cacheBustingPlugin = exports.templateColocationPluginPath = exports.templateColocationPlugin = exports.hbsToJS = exports.tmpdir = exports.packageName = exports.babelFilter = exports.RewrittenPackageCache = exports.PackageCache = exports.Package = exports.getOrCreate = exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
+exports.locateEmbroiderWorkingDir = exports.cacheBustingPluginVersion = exports.cacheBustingPluginPath = exports.cacheBustingPlugin = exports.templateColocationPluginPath = exports.templateColocationPlugin = exports.hbsToJS = exports.tmpdir = exports.packageName = exports.babelFilter = exports.RewrittenPackageCache = exports.PackageCache = exports.Package = exports.getOrCreate = exports.correspondingTemplate = exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
 var paths_1 = require("./paths");
@@ -27,2 +27,3 @@ Object.defineProperty(exports, "explicitRelative", { enumerable: true, get: function () { return paths_1.explicitRelative; } });
 Object.defineProperty(exports, "cleanUrl", { enumerable: true, get: function () { return paths_1.cleanUrl; } });
+Object.defineProperty(exports, "correspondingTemplate", { enumerable: true, get: function () { return paths_1.correspondingTemplate; } });
 var get_or_create_1 = require("./get-or-create");
@@ -29,0 +30,0 @@ Object.defineProperty(exports, "getOrCreate", { enumerable: true, get: function () { return get_or_create_1.getOrCreate; } });

src/package-cache.js

@@ -66,3 +66,3 @@ "use strict";
     ownerOfFile(filename) {
-        let segments = filename.replace(/\\/g, '/').split(path_1.posix.sep);
+        let segments = filename.split(path_1.sep);
         // first we look through our cached packages for any that are rooted right
@@ -77,7 +77,7 @@ // at or above the file.
             let usedSegments = segments.slice(0, length);
-            let candidate = usedSegments.join(path_1.posix.sep);
+            let candidate = usedSegments.join(path_1.sep);
             if (this.rootCache.has(candidate)) {
                 return this.rootCache.get(candidate);
             }
-            if (getCachedExists([...usedSegments, 'package.json'].join(path_1.posix.sep))) {
+            if (getCachedExists([...usedSegments, 'package.json'].join(path_1.sep))) {
                 return this.get(candidate);
@@ -84,0 +84,0 @@ }

src/paths.d.ts

@@ -6,1 +6,2 @@ import type Package from './package';
 export declare function cleanUrl(url: string): string;
+export declare function correspondingTemplate(filename: string): string;

src/paths.js

 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
+exports.correspondingTemplate = exports.cleanUrl = exports.unrelativize = exports.extensionsPattern = exports.explicitRelative = void 0;
 const path_1 = require("path");
@@ -52,2 +52,9 @@ // by "explicit", I mean that we want "./local/thing" instead of "local/thing"
 exports.cleanUrl = cleanUrl;
+// given a filename, returns it with the hbs extension
+// for instance, passing filename.js returns filename.hbs
+function correspondingTemplate(filename) {
+    let { ext } = (0, path_1.parse)(filename);
+    return filename.slice(0, filename.length - ext.length) + '.hbs';
+}
+exports.correspondingTemplate = correspondingTemplate;
 //# sourceMappingURL=paths.js.map

src/template-colocation-plugin.d.ts

@@ -10,2 +10,3 @@ import type { NodePath } from '@babel/traverse';
     templateExtensions?: string[];
+    exclude?: string[];
 }
@@ -12,0 +13,0 @@ interface State {

src/template-colocation-plugin.js

@@ -12,2 +12,3 @@ "use strict";
 const debug_1 = __importDefault(require("debug"));
+const minimatch_1 = __importDefault(require("minimatch"));
 const paths_1 = require("./paths");
@@ -25,3 +26,3 @@ const debug = (0, debug_1.default)('embroider:template-colocation-plugin');
                 enter(path, state) {
-                    var _a;
+                    var _a, _b;
                     state.adder = new babel_import_util_1.ImportUtil(t, path);
@@ -36,4 +37,8 @@ let filename = (0, paths_1.cleanUrl)(path.hub.file.opts.filename);
                     }
+                    if ((_a = state.opts.exclude) === null || _a === void 0 ? void 0 : _a.some(glob => (0, minimatch_1.default)((0, paths_1.correspondingTemplate)(filename), glob))) {
+                        debug('not handling colocation for %s', filename);
+                        return;
+                    }
                     debug('handling colocation for %s', filename);
-                    let extensions = (_a = state.opts.templateExtensions) !== null && _a !== void 0 ? _a : ['.hbs'];
+                    let extensions = (_b = state.opts.templateExtensions) !== null && _b !== void 0 ? _b : ['.hbs'];
                     for (let ext of extensions) {
@@ -40,0 +45,0 @@ let hbsFilename = filename.replace(/\.\w{1,3}$/, '') + ext;

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

154361

1.97%

Number of package files

59

1.72%

Lines of code

1556

0.84%

Number of low quality alerts

1

-50%

Worsened metrics

Dependency count

10

11.11%

Dev dependency count

14

7.69%

Published versions last year

241

-0.82%

Dependency changes

• + Added

  minimatch@^3.0.4

• + Added

  balanced-match@1.0.2
  (transitive)

• + Added

  brace-expansion@1.1.11
  (transitive)

• + Added

  concat-map@0.0.1
  (transitive)

• + Added

  minimatch@3.1.2
  (transitive)