@feathersjs/authentication-local - npm Package Compare versions

Comparing version 4.3.1 to 4.3.2

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [4.3.2](https://github.com/feathersjs/feathers/compare/v4.3.1...v4.3.2) (2019-09-16)
+
+
+### Bug Fixes
+
+* LocalStrategy authenticates without username ([#1560](https://github.com/feathersjs/feathers/issues/1560)) ([2b258fd](https://github.com/feathersjs/feathers/commit/2b258fd)), closes [#1559](https://github.com/feathersjs/feathers/issues/1559)
+
+
+
+
+
 ## [4.3.1](https://github.com/feathersjs/feathers/compare/v4.3.0...v4.3.1) (2019-09-09)
@@ -8,0 +19,0 @@

lib/strategy.js

@@ -43,2 +43,5 @@ "use strict";
             const { entityUsernameField, service, errorMessage } = this.configuration;
+            if (!username) { // don't query for users without any condition set.
+                throw new errors_1.NotAuthenticated(errorMessage);
+            }
             const query = yield this.getEntityQuery({
@@ -45,0 +48,0 @@ [entityUsernameField]: username

package.json

 {
   "name": "@feathersjs/authentication-local",
   "description": "Local authentication strategy for @feathers/authentication",
-  "version": "4.3.1",
+  "version": "4.3.2",
   "homepage": "https://feathersjs.com",
@@ -42,3 +42,3 @@ "main": "lib/",
   "dependencies": {
-    "@feathersjs/errors": "^4.3.1",
+    "@feathersjs/errors": "^4.3.2",
     "bcryptjs": "^2.4.3",
@@ -49,4 +49,4 @@ "debug": "^4.1.1",
   "devDependencies": {
-    "@feathersjs/authentication": "^4.3.1",
-    "@feathersjs/feathers": "^4.3.1",
+    "@feathersjs/authentication": "^4.3.2",
+    "@feathersjs/feathers": "^4.3.2",
     "@types/bcryptjs": "^2.4.2",
@@ -62,3 +62,3 @@ "@types/debug": "^4.1.5",
   },
-  "gitHead": "64c73ba6b783c511449abb5fd7bf093fac71a462"
+  "gitHead": "31c8e752298f725e3be9965ce1550e94e09ec871"
 }

src/strategy.ts

@@ -48,2 +48,6 @@ import bcrypt from 'bcryptjs';
     const { entityUsernameField, service, errorMessage } = this.configuration;
+    if (!username) { // don't query for users without any condition set.
+      throw new NotAuthenticated(errorMessage);
+    }
+
     const query = await this.getEntityQuery({
@@ -50,0 +54,0 @@ [entityUsernameField]: username

No alert changes

Improved metrics

Total package byte prevSize

282280

increased by0.26%

Lines of code

1420

increased by0.42%

Dependency changes

• Updated@feathersjs/errors@^4.3.2