@internetarchive/lazy-loader-service - npm Package Compare versions

Comparing version 0.0.0-alpha.1 to 0.0.0-alpha.2

lib/lazy-loader-service.js

@@ -58,7 +58,17 @@ export var BundleType;
         return new Promise((resolve, reject) => {
+            // if multiple requests get made for this script, just stack the onloads
+            // and onerrors and all the callbacks will be called in-order of being received
+            const originalOnLoad = script.onload;
             script.onload = (e) => {
+                if (originalOnLoad) {
+                    originalOnLoad(e);
+                }
                 script.setAttribute('dynamicImportLoaded', 'true');
                 resolve(e);
             };
+            const originalOnError = script.onerror;
             script.onerror = (e) => {
+                if (originalOnError) {
+                    originalOnError(e);
+                }
                 /* istanbul ignore else */
@@ -65,0 +75,0 @@ if (script.parentNode) {

package.json

 {
   "name": "@internetarchive/lazy-loader-service",
-  "version": "0.0.0-alpha.1",
+  "version": "0.0.0-alpha.2",
   "description": "A small library to lazy load javascript with a Promise",
@@ -5,0 +5,0 @@ "license": "AGPL-3.0-only",

README.md

@@ -1,2 +0,2 @@
-[![Build Status](https://travis-ci.com/internetarchive/iaux-lazy-loader-service.svg?branch=master)](https://travis-ci.com/internetarchive/iaux) [![codecov](https://codecov.io/gh/internetarchive/iaux-lazy-loader-service/branch/master/graph/badge.svg)](https://codecov.io/gh/internetarchive/iaux-lazy-loader-service)
+[![Build Status](https://travis-ci.com/internetarchive/iaux-lazy-loader-service.svg?branch=master)](https://travis-ci.com/internetarchive/iaux-lazy-loader-service) [![codecov](https://codecov.io/gh/internetarchive/iaux-lazy-loader-service/branch/master/graph/badge.svg)](https://codecov.io/gh/internetarchive/iaux-lazy-loader-service)
 
@@ -3,0 +3,0 @@ # Lazy Loader Service

src/lazy-loader-service.ts

@@ -116,3 +116,9 @@ export enum BundleType {
     return new Promise((resolve, reject) => {
+      // if multiple requests get made for this script, just stack the onloads
+      // and onerrors and all the callbacks will be called in-order of being received
+      const originalOnLoad: ((ev: Event) => any) | null = script.onload;
       script.onload = (e) => {
+        if (originalOnLoad) {
+          originalOnLoad(e);
+        }
         script.setAttribute('dynamicImportLoaded', 'true');
@@ -122,3 +128,8 @@ resolve(e);
 
+      const originalOnError: ((error: string | Event) => any) | null = script.onerror;
       script.onerror = (e) => {
+        if (originalOnError) {
+          originalOnError(e);
+        }
+
         /* istanbul ignore else */
@@ -125,0 +136,0 @@ if (script.parentNode) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

50692

increased by2.4%

Lines of code

280

increased by7.69%

No dependency changes