@jupyterlab/ui-components - npm Package Compare versions

Comparing version 4.5.1 to 4.6.0-alpha.0

lib/components/toolbar.d.ts

@@ -261,3 +261,3 @@ import { ITranslator } from '@jupyterlab/translation';
         tooltip?: string;
-        onClick?: () => void;
+        onClick?: (event?: React.SyntheticEvent) => void;
         enabled?: boolean;
@@ -264,0 +264,0 @@ pressed?: boolean;

lib/components/toolbar.js

@@ -666,3 +666,3 @@ // Copyright (c) Jupyter Development Team.
             if (event.button === 0) {
-                (_a = props.onClick) === null || _a === void 0 ? void 0 : _a.call(props);
+                (_a = props.onClick) === null || _a === void 0 ? void 0 : _a.call(props, event);
                 // In safari, the focus do not move to the button on click (see
@@ -683,3 +683,3 @@ // https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#Clicking_and_focus).
                 event.preventDefault();
-                (_a = props.onClick) === null || _a === void 0 ? void 0 : _a.call(props);
+                (_a = props.onClick) === null || _a === void 0 ? void 0 : _a.call(props, event);
             }
@@ -692,3 +692,3 @@ }
         if (key === 'Enter' || key === ' ') {
-            (_a = props.onClick) === null || _a === void 0 ? void 0 : _a.call(props);
+            (_a = props.onClick) === null || _a === void 0 ? void 0 : _a.call(props, event);
         }
@@ -949,3 +949,4 @@ };
             icon: ellipsesIcon,
-            onClick: () => {
+            onClick: event => {
+                event === null || event === void 0 ? void 0 : event.preventDefault();
                 this.handleClick();
@@ -952,0 +953,0 @@ },

package.json

 {
   "name": "@jupyterlab/ui-components",
-  "version": "4.5.1",
+  "version": "4.6.0-alpha.0",
   "description": "JupyterLab - UI components written in React",
@@ -45,6 +45,6 @@ "homepage": "https://github.com/jupyterlab/jupyterlab",
     "@jupyter/web-components": "^0.16.6",
-    "@jupyterlab/coreutils": "^6.5.1",
-    "@jupyterlab/observables": "^5.5.1",
-    "@jupyterlab/rendermime-interfaces": "^3.13.1",
-    "@jupyterlab/translation": "^4.5.1",
+    "@jupyterlab/coreutils": "^6.6.0-alpha.0",
+    "@jupyterlab/observables": "^5.6.0-alpha.0",
+    "@jupyterlab/rendermime-interfaces": "^3.14.0-alpha.0",
+    "@jupyterlab/translation": "^4.6.0-alpha.0",
     "@lumino/algorithm": "^2.0.4",
@@ -67,3 +67,3 @@ "@lumino/commands": "^2.3.3",
   "devDependencies": {
-    "@jupyterlab/testing": "^4.5.1",
+    "@jupyterlab/testing": "^4.6.0-alpha.0",
     "@types/jest": "^29.2.0",
@@ -70,0 +70,0 @@ "@types/react": "^18.0.26",

src/components/toolbar.tsx

@@ -793,3 +793,3 @@ // Copyright (c) Jupyter Development Team.
     tooltip?: string;
-    onClick?: () => void;
+    onClick?: (event?: React.SyntheticEvent) => void;
     enabled?: boolean;
@@ -829,3 +829,3 @@ pressed?: boolean;
           if (event.button === 0) {
-            props.onClick?.();
+            props.onClick?.(event);
             // In safari, the focus do not move to the button on click (see
@@ -847,3 +847,3 @@ // https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#Clicking_and_focus).
             event.preventDefault();
-            props.onClick?.();
+            props.onClick?.(event);
           }
@@ -856,3 +856,3 @@ }
     if (key === 'Enter' || key === ' ') {
-      props.onClick?.();
+      props.onClick?.(event);
     }
@@ -1234,3 +1234,4 @@ };
       icon: ellipsesIcon,
-      onClick: () => {
+      onClick: event => {
+        event?.preventDefault();
         this.handleClick();
@@ -1237,0 +1238,0 @@ },

New alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

Long strings

Supply chain risk

Contains long string literals, which may be a sign of obfuscated or packed code.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

987492

0.04%

Lines of code

21048

0.01%

Worsened metrics

Number of low quality alerts

1

Infinity%

Dependency changes

• + Added

  @jupyterlab/coreutils@6.6.0-alpha.3
  (transitive)

• + Added

  @jupyterlab/nbformat@4.6.0-alpha.3
  (transitive)

• + Added

  @jupyterlab/observables@5.6.0-alpha.3
  (transitive)

• + Added

  @jupyterlab/rendermime-interfaces@3.14.0-alpha.3
  (transitive)

• + Added

  @jupyterlab/services@7.6.0-alpha.3
  (transitive)

• + Added

  @jupyterlab/settingregistry@4.6.0-alpha.3
  (transitive)

• + Added

  @jupyterlab/statedb@4.6.0-alpha.3
  (transitive)

• + Added

  @jupyterlab/translation@4.6.0-alpha.3
  (transitive)

• - Removed

  @jupyterlab/coreutils@6.5.5
  (transitive)

• - Removed

  @jupyterlab/observables@5.5.5
  (transitive)

• - Removed

  @jupyterlab/rendermime-interfaces@3.13.5
  (transitive)

• - Removed

  @jupyterlab/services@7.5.5
  (transitive)

• - Removed

  @jupyterlab/settingregistry@4.5.5
  (transitive)

• - Removed

  @jupyterlab/statedb@4.5.5
  (transitive)

• - Removed

  @jupyterlab/translation@4.5.5
  (transitive)

• Updated

  @jupyterlab/coreutils@^6.6.0-alpha.0

• Updated

  @jupyterlab/observables@^5.6.0-alpha.0

• Updated

  @jupyterlab/rendermime-interfaces@^3.14.0-alpha.0

• Updated

  @jupyterlab/translation@^4.6.0-alpha.0