@khanacademy/wonder-blocks-core - npm Package Compare versions

Comparing version 2.0.0 to 2.0.1

components/with-ssr-placeholder.js

@@ -132,2 +132,27 @@ // @flow
         switch (renderState) {
+            // There are edge cases where for some reason, we get an unknown
+            // context value here. So far it seems to be when we're nested in a
+            // v1 WithSSRPlaceholder equivalent component, or in some older
+            // React v16 situations where we're nested in the provider of a
+            // different context.
+            //
+            // We ignore this from coverage. It's a maintenance case to help
+            // us catch code changes that affect the control flow unexpectedly,
+            // but it's not something we need to write a test case for.
+            //
+            /* istanbul ignore next */
+            default:
+                // Let's log this case so we can debug it easily.
+                // Then fall through to the root case.
+                /* eslint-disable-next-line no-console */
+                console.log(
+                    `We got a render state we don't understand: "${JSON.stringify(
+                        renderState,
+                    )}"`,
+                );
+                // We "fallthrough" to the root case. This is more obvious
+                // and maintainable code than just ignoring the no-fallthrough
+                // lint rule.
+                return this._maybeRender("root");
+
             case "root":
@@ -150,9 +175,2 @@ return this._renderAsRootComponent();
                 return children();
-
-            // We ignore this from coverage. It's a maintenance case to help
-            // us catch code changes that affect the control flow unexpectedly,
-            // but it's not something we need to write a test case for.
-            /* istanbul ignore next */
-            default:
-                throw new Error("We got a render state we don't understand");
         }
@@ -159,0 +177,0 @@ }

dist/es/index.js

@@ -1306,2 +1306,25 @@ import React__default, { createElement, Component, Fragment, createContext } from 'react';
       switch (renderState) {
+        // There are edge cases where for some reason, we get an unknown
+        // context value here. So far it seems to be when we're nested in a
+        // v1 WithSSRPlaceholder equivalent component, or in some older
+        // React v16 situations where we're nested in the provider of a
+        // different context.
+        //
+        // We ignore this from coverage. It's a maintenance case to help
+        // us catch code changes that affect the control flow unexpectedly,
+        // but it's not something we need to write a test case for.
+        //
+
+        /* istanbul ignore next */
+        default:
+          // Let's log this case so we can debug it easily.
+          // Then fall through to the root case.
+
+          /* eslint-disable-next-line no-console */
+          console.log("We got a render state we don't understand: \"".concat(JSON.stringify(renderState), "\"")); // We "fallthrough" to the root case. This is more obvious
+          // and maintainable code than just ignoring the no-fallthrough
+          // lint rule.
+
+          return this._maybeRender("root");
+
         case "root":
@@ -1325,10 +1348,2 @@ return this._renderAsRootComponent();
           return children();
-        // We ignore this from coverage. It's a maintenance case to help
-        // us catch code changes that affect the control flow unexpectedly,
-        // but it's not something we need to write a test case for.
-
-        /* istanbul ignore next */
-
-        default:
-          throw new Error("We got a render state we don't understand");
       }
@@ -1335,0 +1350,0 @@ }

package.json

 {
   "name": "@khanacademy/wonder-blocks-core",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "design": "v1",
@@ -16,3 +16,3 @@ "publishConfig": {
   "dependencies": {
-    "@khanacademy/wonder-blocks-spacing": "^2.0.13"
+    "@khanacademy/wonder-blocks-spacing": "^2.0.14"
   },
@@ -19,0 +19,0 @@ "peerDependencies": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

319580

increased by0.76%

Lines of code

6880

increased by0.64%

Dependency changes

• Updated@khanacademy/wonder-blocks-spacing@^2.0.14