@ledgerhq/hw-app-btc - npm Package Compare versions

Comparing version 4.11.1 to 4.12.0-beta.a9ddcef0

flow-typed/npm/@ledgerhq/hw-transport_vx.x.x.js

@@ -1,2 +0,2 @@
-// flow-typed signature: de76e43b7f594cd142bb9865fb4eb16a
+// flow-typed signature: f6daf2211427d50e92ed6170713459e9
 // flow-typed version: <<STUB>>/@ledgerhq/hw-transport_v^4.7.3/flow_v0.68.0
@@ -25,14 +25,2 @@
  */
-declare module '@ledgerhq/hw-transport/flow-typed/npm/events_vx.x.x' {
-  declare module.exports: any;
-}
-
-declare module '@ledgerhq/hw-transport/flow-typed/npm/flow-bin_v0.x.x' {
-  declare module.exports: any;
-}
-
-declare module '@ledgerhq/hw-transport/flow-typed/npm/flow-typed_vx.x.x' {
-  declare module.exports: any;
-}
-
 declare module '@ledgerhq/hw-transport/src/Transport' {
@@ -43,13 +31,4 @@ declare module.exports: any;
 // Filename aliases
-declare module '@ledgerhq/hw-transport/flow-typed/npm/events_vx.x.x.js' {
-  declare module.exports: $Exports<'@ledgerhq/hw-transport/flow-typed/npm/events_vx.x.x'>;
-}
-declare module '@ledgerhq/hw-transport/flow-typed/npm/flow-bin_v0.x.x.js' {
-  declare module.exports: $Exports<'@ledgerhq/hw-transport/flow-typed/npm/flow-bin_v0.x.x'>;
-}
-declare module '@ledgerhq/hw-transport/flow-typed/npm/flow-typed_vx.x.x.js' {
-  declare module.exports: $Exports<'@ledgerhq/hw-transport/flow-typed/npm/flow-typed_vx.x.x'>;
-}
 declare module '@ledgerhq/hw-transport/src/Transport.js' {
   declare module.exports: $Exports<'@ledgerhq/hw-transport/src/Transport'>;
 }

lib/Btc.js

@@ -461,2 +461,3 @@ "use strict";
      * @param initialTimestamp is the timestamp when the function is called, not the one that the tx will include
+     * @param additionals list of additionnal options ("abc" for bch, "gold" for btg, "bipxxx" for using BIPxxx)
      * @return the signed transaction ready to be broadcast
@@ -477,7 +478,8 @@ * @example
       var sigHashType = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : SIGHASH_ALL;
+      var segwit = arguments.length > 6 && arguments[6] !== undefined ? arguments[6] : false;
 
       var _this5 = this;
 
-      var segwit = arguments.length > 6 && arguments[6] !== undefined ? arguments[6] : false;
       var initialTimestamp = arguments[7];
+      var additionals = arguments[8];
 
@@ -554,3 +556,3 @@ var hasTimestamp = initialTimestamp !== undefined;
       }).then(function () {
-        return (0, _utils.doIf)(segwit, function () {
+        return (0, _utils.doIf)(segwit || !!additionals && (additionals.includes("abc") || additionals.includes("gold")), function () {
           return (
@@ -560,2 +562,3 @@ // Do the first run with all inputs
               return (0, _utils.doIf)(!resuming && typeof changePath != "undefined", function () {
+                // $FlowFixMe
                 return _this5.provideOutputFullChangePath(changePath);
@@ -580,5 +583,6 @@ }).then(function () {
             }
-            return _this5.startUntrustedHashTransactionInput(!segwit && firstRun, pseudoTX, pseudoTrustedInputs, segwit).then(function () {
-              return (0, _utils.doIf)(!segwit, function () {
+            return _this5.startUntrustedHashTransactionInput(!segwit && !!additionals && (additionals.includes("abc") || additionals.includes("gold")) && firstRun, pseudoTX, pseudoTrustedInputs, segwit).then(function () {
+              return (0, _utils.doIf)(!segwit && !!additionals && (additionals.includes("abc") || additionals.includes("gold")), function () {
                 return (0, _utils.doIf)(!resuming && typeof changePath != "undefined", function () {
+                  // $FlowFixMe
                   return _this5.provideOutputFullChangePath(changePath);
@@ -585,0 +589,0 @@ }).then(function () {

package.json

 {
   "name": "@ledgerhq/hw-app-btc",
-  "version": "4.11.1",
+  "version": "4.12.0-beta.a9ddcef0",
   "description": "Ledger Hardware Wallet Bitcoin Application API",
@@ -28,3 +28,3 @@ "keywords": [
   "dependencies": {
-    "@ledgerhq/hw-transport": "^4.7.3",
+    "@ledgerhq/hw-transport": "^4.12.0-beta.a9ddcef0",
     "create-hash": "^1.1.3"
@@ -31,0 +31,0 @@ },

src/Btc.js

@@ -484,2 +484,3 @@ //@flow
    * @param initialTimestamp is the timestamp when the function is called, not the one that the tx will include
+   * @param additionals list of additionnal options ("abc" for bch, "gold" for btg, "bipxxx" for using BIPxxx)
    * @return the signed transaction ready to be broadcast
@@ -502,3 +503,4 @@ * @example
     segwit?: boolean = false,
-    initialTimestamp?: number
+    initialTimestamp?: number,
+    additionals?: Array<string>
   ) {
@@ -595,3 +597,3 @@ const hasTimestamp = initialTimestamp !== undefined;
       .then(() =>
-        doIf(segwit, () =>
+        doIf(segwit || (!!additionals && (additionals.includes("abc") || additionals.includes("gold"))), () =>
           // Do the first run with all inputs
@@ -605,2 +607,3 @@ this.startUntrustedHashTransactionInput(
             doIf(!resuming && typeof changePath != "undefined", () => {
+              // $FlowFixMe
               return this.provideOutputFullChangePath(changePath);
@@ -632,3 +635,3 @@ }).then(() => this.hashOutputFull(outputScript))
           return this.startUntrustedHashTransactionInput(
-            !segwit && firstRun,
+            (!segwit && (!!additionals && (additionals.includes("abc") || additionals.includes("gold")))) && firstRun,
             pseudoTX,
@@ -639,4 +642,5 @@ pseudoTrustedInputs,
             .then(() =>
-              doIf(!segwit, () =>
+              doIf(!segwit && (!!additionals && (additionals.includes("abc") || additionals.includes("gold"))), () =>
                 doIf(!resuming && typeof changePath != "undefined", () => {
+                  // $FlowFixMe
                   return this.provideOutputFullChangePath(changePath);
@@ -643,0 +647,0 @@ }).then(() => this.hashOutputFull(outputScript))

New alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

198395

0.72%

Worsened metrics

Lines of code

2275

-0.44%

Number of low quality alerts

1

Infinity%

Dependency changes

• Updated

  @ledgerhq/hw-transport@^4.12.0-beta.a9ddcef0