@lightningjs/solid - npm Package Compare versions

Comparing version 0.14.2 to 0.14.3

dist/esm/index.js

@@ -97,2 +97,3 @@ import { createSignal, mergeProps as mergeProps$1, createRoot, createRenderEffect, createMemo, createComponent as createComponent$1, untrack, splitProps } from 'solid-js';
       this.splice(nodeIndexToRemove, 1);
+      node.parent = undefined;
     }
@@ -650,3 +651,5 @@ }
   destroy() {
-    this.lng && renderer.destroyNode(this.lng);
+    if (this.lng && !this.parent) {
+      this.lng.destroy();
+    }
   }
@@ -1223,5 +1226,8 @@ set style(values) {
       if (config.enableRecursiveRemoval) {
-        removeChildrenNode(node);
+        queueMicrotask(() => removeChildrenNode(node));
       } else {
-        node.destroy();
+        // Solid replacesNodes to move them (via insert and remove),
+        // so we need to wait for the next microtask to destroy the node
+        // in the event it gets a new parent.
+        queueMicrotask(() => node.destroy());
       }
@@ -1228,0 +1234,0 @@ }

dist/source/core/node/children.js

@@ -48,4 +48,5 @@ /*
             this.splice(nodeIndexToRemove, 1);
+            node.parent = undefined;
         }
     }
 }

dist/source/core/node/index.js

@@ -336,3 +336,5 @@ /*
     destroy() {
-        this.lng && renderer.destroyNode(this.lng);
+        if (this.lng && !this.parent) {
+            this.lng.destroy();
+        }
     }
@@ -339,0 +341,0 @@ set style(values) {

dist/source/core/universal/lightning.js

@@ -79,6 +79,9 @@ /*
             if (config.enableRecursiveRemoval) {
-                removeChildrenNode(node);
+                queueMicrotask(() => removeChildrenNode(node));
             }
             else {
-                node.destroy();
+                // Solid replacesNodes to move them (via insert and remove),
+                // so we need to wait for the next microtask to destroy the node
+                // in the event it gets a new parent.
+                queueMicrotask(() => node.destroy());
             }
@@ -85,0 +88,0 @@ }

package.json

 {
   "name": "@lightningjs/solid",
-  "version": "0.14.2",
+  "version": "0.14.3",
   "description": "Lightning renderer for solid universal",
@@ -5,0 +5,0 @@ "type": "module",

src/core/node/children.ts

@@ -56,4 +56,5 @@ /*
       this.splice(nodeIndexToRemove, 1);
+      node.parent = undefined;
     }
   }
 }

src/core/node/index.ts

@@ -428,3 +428,5 @@ /*
   destroy() {
-    this.lng && renderer.destroyNode(this.lng);
+    if (this.lng && !this.parent) {
+      this.lng.destroy();
+    }
   }
@@ -431,0 +433,0 @@

src/core/universal/lightning.ts

@@ -88,5 +88,8 @@ /*
       if (config.enableRecursiveRemoval) {
-        removeChildrenNode(node);
+        queueMicrotask(() => removeChildrenNode(node));
       } else {
-        node.destroy();
+        // Solid replacesNodes to move them (via insert and remove),
+        // so we need to wait for the next microtask to destroy the node
+        // in the event it gets a new parent.
+        queueMicrotask(() => node.destroy());
       }
@@ -93,0 +96,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

270703

increased by0.49%

Lines of code

4395

increased by0.41%

No dependency changes