@lion/tooltip - npm Package Compare versions

Comparing version 0.18.2 to 0.19.0

CHANGELOG.md

 # Change Log
 
+## 0.19.0
+
+### Minor Changes
+
+- 43e4bb81: Type fixes and enhancements:
+
+  - all protected/private entries added to form-core type definitions, and their dependents were fixed
+  - a lot @ts-expect-error and @ts-ignore (all `get slots()` and `get modelValue()` issues are fixed)
+  - categorized @ts-expect-error / @ts-ignore into:
+    - [external]: when a 3rd party didn't ship types (could also be browser specs)
+    - [allow-protected]: when we are allowed to know about protected methods. For instance when code
+      resides in the same package
+    - [allow-private]: when we need to check a private value inside a test
+    - [allow]: miscellaneous allows
+    - [editor]: when the editor complains, but the cli/ci doesn't
+
+### Patch Changes
+
+- 77a04245: add protected and private type info
+- Updated dependencies [77a04245]
+- Updated dependencies [43e4bb81]
+  - @lion/core@0.16.0
+  - @lion/overlays@0.26.0
+
 ## 0.18.2
@@ -4,0 +28,0 @@

custom-elements.json

@@ -79,3 +79,3 @@ {
               "name": "_mouseActive",
-              "privacy": "public",
+              "privacy": "protected",
               "type": {
@@ -88,3 +88,3 @@ "text": "boolean"
               "name": "_keyActive",
-              "privacy": "public",
+              "privacy": "protected",
               "type": {
@@ -97,3 +97,3 @@ "text": "boolean"
               "name": "_hasDisabledInvoker",
-              "privacy": "public",
+              "privacy": "protected",
               "return": {
@@ -106,10 +106,5 @@ "type": {
             {
-              "kind": "method",
+              "kind": "field",
               "name": "__resetActive",
-              "privacy": "public",
-              "return": {
-                "type": {
-                  "text": "void"
-                }
-              }
+              "privacy": "private"
             },
@@ -119,3 +114,3 @@ {
               "name": "_showKey",
-              "privacy": "public",
+              "privacy": "protected",
               "return": {
@@ -130,3 +125,3 @@ "type": {
               "name": "_hideKey",
-              "privacy": "public",
+              "privacy": "protected",
               "return": {
@@ -141,3 +136,3 @@ "type": {
               "name": "_showMouse",
-              "privacy": "public",
+              "privacy": "protected",
               "return": {
@@ -152,3 +147,3 @@ "type": {
               "name": "_hideMouse",
-              "privacy": "public",
+              "privacy": "protected",
               "return": {
@@ -199,3 +194,3 @@ "type": {
               "name": "_defineOverlayConfig",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -205,3 +200,3 @@ {
               "name": "_hasDisabledInvoker",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -211,3 +206,3 @@ {
               "name": "_setupOpenCloseListeners",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -217,3 +212,3 @@ {
               "name": "_teardownOpenCloseListeners",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -223,3 +218,3 @@ {
               "name": "__resetActive",
-              "privacy": "public"
+              "privacy": "private"
             },
@@ -229,3 +224,3 @@ {
               "name": "_showMouse",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -235,3 +230,3 @@ {
               "name": "_hideMouse",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -241,3 +236,3 @@ {
               "name": "_showKey",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -247,3 +242,3 @@ {
               "name": "_hideKey",
-              "privacy": "public"
+              "privacy": "protected"
             },
@@ -250,0 +245,0 @@ {

package.json

 {
   "name": "@lion/tooltip",
-  "version": "0.18.2",
+  "version": "0.19.0",
   "description": "Show relative overlay content on hover",
@@ -39,4 +39,4 @@ "license": "MIT",
   "dependencies": {
-    "@lion/core": "0.15.0",
-    "@lion/overlays": "0.25.2"
+    "@lion/core": "0.16.0",
+    "@lion/overlays": "0.26.0"
   },
@@ -43,0 +43,0 @@ "keywords": [

src/LionTooltip.d.ts

@@ -20,10 +20,18 @@ declare const LionTooltip_base: typeof LitElement & import("@open-wc/dedupe-mixin").Constructor<import("@lion/overlays/types/OverlayMixinTypes").OverlayHost> & Pick<typeof import("@lion/overlays/types/OverlayMixinTypes").OverlayHost, "prototype"> & Pick<typeof LitElement, "prototype" | "render" | "styles" | "getStyles" | "properties" | "observedAttributes" | "createProperty"> & import("@open-wc/dedupe-mixin").Constructor<import("@lion/overlays/types/ArrowMixinTypes").ArrowHost> & Pick<typeof import("@lion/overlays/types/ArrowMixinTypes").ArrowHost, "prototype" | "styles" | "properties">;
     invokerRelation: 'label' | 'description';
-    _mouseActive: boolean;
-    _keyActive: boolean;
-    _hasDisabledInvoker(): boolean;
-    __resetActive(): void;
-    _showKey(): void;
-    _hideKey(): void;
-    _showMouse(): void;
-    _hideMouse(): void;
+    /** @protected */
+    protected _mouseActive: boolean;
+    /** @protected */
+    protected _keyActive: boolean;
+    /** @protected */
+    protected _hasDisabledInvoker(): boolean;
+    /** @private */
+    private __resetActive;
+    /** @protected */
+    protected _showKey(): void;
+    /** @protected */
+    protected _hideKey(): void;
+    /** @protected */
+    protected _showMouse(): void;
+    /** @protected */
+    protected _hideMouse(): void;
 }
@@ -30,0 +38,0 @@ export type OverlayConfig = import("@lion/overlays/types/OverlayConfig").OverlayConfig;

src/LionTooltip.js

@@ -52,6 +52,9 @@ import { css, LitElement } from '@lion/core';
     this.invokerRelation = 'description';
+    /** @protected */
     this._mouseActive = false;
+    /** @protected */
     this._keyActive = false;
   }
 
+  /** @protected */
   // eslint-disable-next-line class-methods-use-this
@@ -71,2 +74,3 @@ _defineOverlayConfig() {
 
+  /** @protected */
   _hasDisabledInvoker() {
@@ -82,2 +86,3 @@ if (this._overlayCtrl && this._overlayCtrl.invoker) {
 
+  /** @protected */
   _setupOpenCloseListeners() {
@@ -98,2 +103,3 @@ super._setupOpenCloseListeners();
 
+  /** @protected */
   _teardownOpenCloseListeners() {
@@ -108,2 +114,3 @@ super._teardownOpenCloseListeners();
 
+  /** @private */
   __resetActive() {
@@ -114,2 +121,3 @@ this._mouseActive = false;
 
+  /** @protected */
   _showMouse() {
@@ -124,2 +132,3 @@ if (!this._keyActive) {
 
+  /** @protected */
   _hideMouse() {
@@ -131,2 +140,3 @@ if (!this._keyActive) {
 
+  /** @protected */
   _showKey() {
@@ -141,2 +151,3 @@ if (!this._mouseActive) {
 
+  /** @protected */
   _hideKey() {
@@ -143,0 +154,0 @@ if (!this._mouseActive) {

No alert changes

Improved metrics

Total package byte prevSize

72433

increased by1.83%

Lines of code

742

increased by1.92%

Dependency changes

• + Added@lion/core@0.16.0(transitive)

• + Added@lion/overlays@0.26.0(transitive)

• + Addedsingleton-manager@1.4.1(transitive)

• - Removed@lion/core@0.15.0(transitive)

• - Removed@lion/overlays@0.25.2(transitive)

• - Removedsingleton-manager@1.4.0(transitive)

• Updated@lion/core@0.16.0

• Updated@lion/overlays@0.26.0