@polkadot-api/metadata-builders - npm Package Compare versions

Comparing version 0.10.0 to 0.10.1

dist/index.js

@@ -372,3 +372,3 @@ 'use strict';
         len,
-        fallback: storageEntry.modifier === 1 ? value2.dec(storageEntry.fallback) : void 0
+        fallback: storageEntry.modifier === 1 ? value2.dec(storageEntry.fallback) : undefined
       };
@@ -574,3 +574,3 @@ };
       } while (poppedNode !== v);
-      if (component.size > 1) result.push(component);
+      result.push(component);
     }
@@ -697,3 +697,3 @@ }
     return getChecksum(
-      length !== void 0 ? [shapeIds.vector, innerChecksum, BigInt(length)] : [shapeIds.vector, innerChecksum]
+      length !== undefined ? [shapeIds.vector, innerChecksum, BigInt(length)] : [shapeIds.vector, innerChecksum]
     );
@@ -810,3 +810,3 @@ };
     const checksum = resultingChecksums.get(id);
-    if (checksum == void 0) throw new Error("Unreachable");
+    if (checksum == undefined) throw new Error("Unreachable");
     if (!checksumToNodes.has(checksum)) {
@@ -829,3 +829,6 @@ checksumToNodes.set(checksum, []);
   const subGraph = getSubgraph(entry.id, graph);
-  const cycles = getStronglyConnectedComponents(subGraph);
+  const cycles = getStronglyConnectedComponents(subGraph).filter(
+    // SCCs can be of length=1, but for those we're only interested with those that are circular with themselves
+    (group) => group.size > 1 || isSelfCircular(group, subGraph)
+  );
   const cyclicGroups = mergeSCCsWithCommonNodes(cycles).filter((group) => {
@@ -835,6 +838,3 @@ return !cache.has(group.values().next().value);
   const mirrored = getMirroredNodes(cyclicGroups, subGraph);
-  const sortedCyclicGroups = sortCyclicGroups(
-    cyclicGroups.filter((group) => group.size > 1),
-    subGraph
-  );
+  const sortedCyclicGroups = sortCyclicGroups(cyclicGroups, subGraph);
   sortedCyclicGroups.forEach((group) => {
@@ -860,2 +860,7 @@ if (cache.has(group.values().next().value)) {
 };
+const isSelfCircular = (group, graph) => {
+  if (group.size !== 1) return false;
+  const [id] = group;
+  return graph.get(id).refs.has(id);
+};
 const getChecksumBuilder = (getLookupEntryDef) => {
@@ -862,0 +867,0 @@ const { metadata } = getLookupEntryDef;

package.json

 {
   "name": "@polkadot-api/metadata-builders",
-  "version": "0.10.0",
+  "version": "0.10.1",
   "author": "Josep M Sobrepere (https://github.com/josepot)",
@@ -38,4 +38,4 @@ "repository": {
   "dependencies": {
-    "@polkadot-api/substrate-bindings": "0.11.0",
-    "@polkadot-api/utils": "0.1.2"
+    "@polkadot-api/utils": "0.1.2",
+    "@polkadot-api/substrate-bindings": "0.11.0"
   },
@@ -42,0 +42,0 @@ "devDependencies": {

No alert changes

Improved metrics

Total package byte prevSize

238097

0.65%

Lines of code

2041

0.49%

No dependency changes