@polymer/paper-dialog-scrollable - npm Package Compare versions

Comparing version 3.0.0-pre.12 to 3.0.0-pre.13

package.json

@@ -19,13 +19,15 @@ {
     "bower": "^1.8.0",
-    "@polymer/iron-component-page": "3.0.0-pre.12",
-    "@polymer/iron-demo-helpers": "3.0.0-pre.12",
-    "@polymer/paper-button": "3.0.0-pre.12",
-    "@polymer/paper-dialog": "3.0.0-pre.12",
-    "wct-browser-legacy": "0.0.1-pre.11",
-    "@webcomponents/webcomponentsjs": "^1.0.0"
+    "webmat": "^0.2.0",
+    "@polymer/iron-component-page": "^3.0.0-pre.13",
+    "@polymer/iron-demo-helpers": "^3.0.0-pre.13",
+    "@polymer/paper-button": "^3.0.0-pre.13",
+    "@polymer/paper-dialog": "^3.0.0-pre.13",
+    "wct-browser-legacy": "^0.0.1-pre.11",
+    "@webcomponents/webcomponentsjs": "^2.0.0-0"
   },
   "scripts": {
-    "update-types": "bower install && gen-typescript-declarations --deleteExisting --outDir ."
+    "update-types": "bower install && gen-typescript-declarations --deleteExisting --outDir .",
+    "format": "webmat && npm run update-types"
   },
-  "version": "3.0.0-pre.12",
+  "version": "3.0.0-pre.13",
   "resolutions": {
@@ -40,7 +42,7 @@ "inherits": "2.0.3",
   "dependencies": {
-    "@polymer/iron-flex-layout": "3.0.0-pre.12",
-    "@polymer/paper-dialog-behavior": "3.0.0-pre.12",
-    "@polymer/paper-styles": "3.0.0-pre.12",
-    "@polymer/polymer": "3.0.0-pre.12"
+    "@polymer/iron-flex-layout": "^3.0.0-pre.13",
+    "@polymer/paper-dialog-behavior": "^3.0.0-pre.13",
+    "@polymer/paper-styles": "^3.0.0-pre.13",
+    "@polymer/polymer": "^3.0.0-pre.13"
   }
 }

paper-dialog-scrollable.js

@@ -1,8 +0,1 @@
-import '@polymer/polymer/polymer-legacy.js';
-import '@polymer/iron-flex-layout/iron-flex-layout.js';
-import { PaperDialogBehaviorImpl } from '@polymer/paper-dialog-behavior/paper-dialog-behavior.js';
-import '@polymer/paper-styles/default-theme.js';
-import { Polymer } from '@polymer/polymer/lib/legacy/polymer-fn.js';
-import { html } from '@polymer/polymer/lib/utils/html-tag.js';
-
 /**
@@ -72,2 +65,14 @@ @license
 */
+/*
+  FIXME(polymer-modulizer): the above comments were extracted
+  from HTML and may be out of place here. Review them and
+  then delete this comment!
+*/
+import '../polymer/polymer-legacy.js';
+
+import '../iron-flex-layout/iron-flex-layout.js';
+import { PaperDialogBehaviorImpl } from '../paper-dialog-behavior/paper-dialog-behavior.js';
+import '../paper-styles/default-theme.js';
+import { Polymer } from '../polymer/lib/legacy/polymer-fn.js';
+import { html } from '../polymer/lib/utils/html-tag.js';
 Polymer({
@@ -124,8 +129,7 @@ _template: html`
     /**
-     * The dialog element that implements `Polymer.PaperDialogBehavior` containing this element.
+     * The dialog element that implements `Polymer.PaperDialogBehavior`
+     * containing this element.
      * @type {?Node}
      */
-    dialogElement: {
-      type: Object
-    }
+    dialogElement: {type: Object}
 
@@ -141,3 +145,3 @@ },
 
-  ready: function () {
+  ready: function() {
     this._ensureTarget();
@@ -154,13 +158,19 @@ this.classList.add('no-padding');
     this.toggleClass('is-scrolled', this.scrollTarget.scrollTop > 0);
-    this.toggleClass('can-scroll', this.scrollTarget.offsetHeight < this.scrollTarget.scrollHeight);
-    this.toggleClass('scrolled-to-bottom',
-      this.scrollTarget.scrollTop + this.scrollTarget.offsetHeight >= this.scrollTarget.scrollHeight);
+    this.toggleClass(
+        'can-scroll',
+        this.scrollTarget.offsetHeight < this.scrollTarget.scrollHeight);
+    this.toggleClass(
+        'scrolled-to-bottom',
+        this.scrollTarget.scrollTop + this.scrollTarget.offsetHeight >=
+            this.scrollTarget.scrollHeight);
   },
 
-  _ensureTarget: function () {
+  _ensureTarget: function() {
     // Read parentElement instead of parentNode in order to skip shadowRoots.
     this.dialogElement = this.dialogElement || this.parentElement;
-    // Check if dialog implements paper-dialog-behavior. If not, fit scrollTarget to host.
+    // Check if dialog implements paper-dialog-behavior. If not, fit
+    // scrollTarget to host.
     if (this.dialogElement && this.dialogElement.behaviors &&
-        this.dialogElement.behaviors.indexOf(PaperDialogBehaviorImpl) >= 0) {
+        this.dialogElement.behaviors.indexOf(PaperDialogBehaviorImpl) >=
+            0) {
       this.dialogElement.sizingTarget = this.scrollTarget;
@@ -167,0 +177,0 @@ this.scrollTarget.classList.remove('fit');

test/test-dialog.js

@@ -1,4 +0,1 @@
-import { PaperDialogBehavior } from '@polymer/paper-dialog-behavior/paper-dialog-behavior.js';
-import { Polymer } from '@polymer/polymer/lib/legacy/polymer-fn.js';
-import { html } from '@polymer/polymer/lib/utils/html-tag.js';
 /**
@@ -13,2 +10,6 @@ @license
 */
+import { PaperDialogBehavior } from '../../paper-dialog-behavior/paper-dialog-behavior.js';
+
+import { Polymer } from '../../polymer/lib/legacy/polymer-fn.js';
+import { html } from '../../polymer/lib/utils/html-tag.js';
 Polymer({
@@ -15,0 +16,0 @@ _template: html`

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

57860

increased by1.73%

Lines of code

202

increased by5.21%

Worsened metrics

Dev dependency count

9

increased by12.5%

Dependency changes

• + Added@polymer/font-roboto@3.0.2(transitive)

• + Added@polymer/iron-a11y-keys-behavior@3.0.1(transitive)

• + Added@polymer/iron-fit-behavior@3.1.0(transitive)

• + Added@polymer/iron-flex-layout@3.0.1(transitive)

• + Added@polymer/iron-overlay-behavior@3.0.3(transitive)

• + Added@polymer/iron-resizable-behavior@3.0.1(transitive)

• + Added@polymer/paper-dialog-behavior@3.0.1(transitive)

• + Added@polymer/paper-styles@3.0.1(transitive)

• + Added@polymer/polymer@3.5.2(transitive)

• - Removed@polymer/font-roboto@3.0.0-pre.12(transitive)

• - Removed@polymer/iron-a11y-keys-behavior@3.0.0-pre.12(transitive)

• - Removed@polymer/iron-fit-behavior@3.0.0-pre.12(transitive)

• - Removed@polymer/iron-flex-layout@3.0.0-pre.12(transitive)

• - Removed@polymer/iron-overlay-behavior@3.0.0-pre.12(transitive)

• - Removed@polymer/iron-resizable-behavior@3.0.0-pre.12(transitive)

• - Removed@polymer/paper-dialog-behavior@3.0.0-pre.12(transitive)

• - Removed@polymer/paper-styles@3.0.0-pre.12(transitive)

• - Removed@polymer/polymer@3.0.0-pre.12(transitive)

• - Removed@webcomponents/webcomponentsjs@1.3.3(transitive)

• Updated@polymer/iron-flex-layout@^3.0.0-pre.13

• Updated@polymer/paper-dialog-behavior@^3.0.0-pre.13

• Updated@polymer/paper-styles@^3.0.0-pre.13

• Updated@polymer/polymer@^3.0.0-pre.13