@rocket.chat/apps-engine - npm Package Compare versions

Comparing version 0.6.3 to 0.6.4

package.json

 {
   "name": "@rocket.chat/apps-engine",
-  "version": "0.6.3",
+  "version": "0.6.4",
   "description": "The engine code for the Rocket.Chat Apps which manages, runs, translates, coordinates and all of that.",
@@ -5,0 +5,0 @@ "main": "index.js",

server/AppManager.js

@@ -496,3 +496,3 @@ "use strict";
             }
-            if (sett.value || sett.packageValue) {
+            if (sett.value !== 'undefined' || sett.packageValue !== 'undefined') {
                 continue;
@@ -499,0 +499,0 @@ }

server/managers/AppSlashCommand.js

@@ -42,2 +42,6 @@ "use strict";
             const command = this.slashCommand.command;
+            // Ensure the slash command has the property before going on
+            if (typeof this.slashCommand[method] !== 'function') {
+                return;
+            }
             const runContext = this.app.makeContext({
@@ -44,0 +48,0 @@ slashCommand: this.slashCommand,

server/managers/AppSlashCommandManager.js

@@ -264,3 +264,3 @@ "use strict";
             const app = this.manager.getOneById(this.touchedCommandsToApps.get(cmd));
-            if (!app) {
+            if (!app || AppStatus_1.AppStatusUtils.isDisabled(app.getStatus())) {
                 // Just in case someone decides to do something they shouldn't
@@ -270,8 +270,2 @@ // let's ensure the app actually exists
             }
-            if (AppStatus_1.AppStatusUtils.isDisabled(app.getStatus())) {
-                return;
-            }
-            if (!app.hasMethod(metadata_1.AppMethod._COMMAND_EXECUTOR)) {
-                return;
-            }
             const appCmd = this.retrieveCommandInfo(cmd, app.getID());
@@ -289,3 +283,3 @@ yield appCmd.runExecutorOrPreviewer(metadata_1.AppMethod._COMMAND_EXECUTOR, context, this.manager.getLogStorage(), this.accessors);
             const app = this.manager.getOneById(this.touchedCommandsToApps.get(cmd));
-            if (!app) {
+            if (!app || AppStatus_1.AppStatusUtils.isDisabled(app.getStatus())) {
                 // Just in case someone decides to do something they shouldn't
@@ -295,8 +289,2 @@ // let's ensure the app actually exists
             }
-            if (AppStatus_1.AppStatusUtils.isDisabled(app.getStatus())) {
-                return;
-            }
-            if (!app.hasMethod(metadata_1.AppMethod._COMMAND_PREVIEWER)) {
-                return;
-            }
             const appCmd = this.retrieveCommandInfo(cmd, app.getID());
@@ -318,3 +306,3 @@ const result = yield appCmd.runExecutorOrPreviewer(metadata_1.AppMethod._COMMAND_EXECUTOR, context, this.manager.getLogStorage(), this.accessors);
             const app = this.manager.getOneById(this.touchedCommandsToApps.get(cmd));
-            if (!app) {
+            if (!app || AppStatus_1.AppStatusUtils.isDisabled(app.getStatus())) {
                 // Just in case someone decides to do something they shouldn't
@@ -324,8 +312,2 @@ // let's ensure the app actually exists
             }
-            if (AppStatus_1.AppStatusUtils.isDisabled(app.getStatus())) {
-                return;
-            }
-            if (!app.hasMethod(metadata_1.AppMethod._COMMAND_PREVIEWER)) {
-                return;
-            }
             const appCmd = this.retrieveCommandInfo(cmd, app.getID());
@@ -332,0 +314,0 @@ yield appCmd.runPreviewExecutor(previewItem, context, this.manager.getLogStorage(), this.accessors);

No alert changes

Worsened metrics

Total package byte prevSize

488525

decreased by-0.15%

Lines of code

4850

decreased by-0.29%

No dependency changes