@segment/analytics.js-core - npm Package Compare versions

Comparing version 3.5.1 to 3.5.2

HISTORY.md

 
+3.5.2 / 2018-05-01
+==================
+
+  * Fix metrics payload, send `Counter` in titlecase, and send `value`.
+
 3.5.1 / 2018-05-01
 ==================
 
-  * Fix Metrics Client Payload
+  * Fix Metrics Client Payload, send `series` instead of `metrics`.
 
@@ -7,0 +12,0 @@ 3.5.0 / 2018-04-25

lib/metrics.js

@@ -53,3 +53,3 @@ 'use strict';
 
-  this.queue.push({ type: 'counter', metric: metric, tags: tags });
+  this.queue.push({ type: 'Counter', metric: metric, value: 1, tags: tags });
 
@@ -56,0 +56,0 @@ // Trigger a flush if this is an error metric.

package.json

 {
   "name": "@segment/analytics.js-core",
   "author": "Segment <[e-mail]>",
-  "version": "3.5.1",
+  "version": "3.5.2",
   "description": "The hassle-free way to integrate analytics into any web application.",
@@ -6,0 +6,0 @@ "keywords": [

test/metrics.test.js

@@ -37,3 +37,3 @@ 'use strict';
 
-      assert.deepEqual(metrics.queue, [ { type: 'counter', metric: 'test', tags: [] } ]);
+      assert.deepEqual(metrics.queue, [ { type: 'Counter', metric: 'test', value: 1, tags: [] } ]);
     });
@@ -63,3 +63,3 @@ });
       assert.strictEqual(req.url, 'https://api.segment.io/v1/m');
-      assert.strictEqual(req.requestBody, '{"series":[{"type":"counter","metric":"foo","tags":{}}]}');
+      assert.strictEqual(req.requestBody, '{"series":[{"type":"Counter","metric":"foo","value":1,"tags":{}}]}');
     });
@@ -78,3 +78,3 @@
       assert.strictEqual(req.url, 'https://api.segment.io/v1/m');
-      assert.strictEqual(req.requestBody, '{"series":[{"type":"counter","metric":"test1","tags":{"foo":"bar"}},{"type":"counter","metric":"test2","tags":{}}]}');
+      assert.strictEqual(req.requestBody, '{"series":[{"type":"Counter","metric":"test1","value":1,"tags":{"foo":"bar"}},{"type":"Counter","metric":"test2","value":1,"tags":{}}]}');
     });
@@ -147,3 +147,3 @@
         assert.strictEqual(req.url, 'https://api.segment.io/v1/m');
-        assert.strictEqual(req.requestBody, '{"series":[{"type":"counter","metric":"test1","tags":{"foo":"bar"}}]}');
+        assert.strictEqual(req.requestBody, '{"series":[{"type":"Counter","metric":"test1","value":1,"tags":{"foo":"bar"}}]}');
 
@@ -150,0 +150,0 @@ assert.deepEqual(metrics.queue, []);

No alert changes

Improved metrics

Total package byte prevSize

186985

increased by0.11%

No dependency changes