@spectrum-web-components/accordion - npm Package Compare versions

Comparing version 0.1.1 to 0.1.2

CHANGELOG.md

@@ -6,2 +6,6 @@ # Change Log
 
+## [0.1.2](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/accordion@0.1.1...@spectrum-web-components/accordion@0.1.2) (2020-09-25)
+
+**Note:** Version bump only for package @spectrum-web-components/accordion
+
 ## [0.1.1](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/accordion@0.1.0...@spectrum-web-components/accordion@0.1.1) (2020-09-14)
@@ -8,0 +12,0 @@

custom-elements.json

@@ -33,4 +33,3 @@ {
           "description": "The tab index to apply to this control. See general documentation about\nthe tabindex HTML property",
-          "type": "number",
-          "default": "0"
+          "type": "number"
         }
@@ -69,4 +68,3 @@ ],
           "description": "The tab index to apply to this control. See general documentation about\nthe tabindex HTML property",
-          "type": "number",
-          "default": "0"
+          "type": "number"
         },
@@ -122,4 +120,3 @@ {
           "description": "The tab index to apply to this control. See general documentation about\nthe tabindex HTML property",
-          "type": "number",
-          "default": "0"
+          "type": "number"
         }
@@ -172,4 +169,3 @@ ],
           "description": "The tab index to apply to this control. See general documentation about\nthe tabindex HTML property",
-          "type": "number",
-          "default": "0"
+          "type": "number"
         },
@@ -176,0 +172,0 @@ {

package.json

@@ -21,3 +21,3 @@ {
     ],
-    "version": "0.1.1",
+    "version": "0.1.2",
     "description": "",
@@ -56,8 +56,8 @@ "main": "src/index.js",
     "dependencies": {
-        "@spectrum-web-components/base": "^0.1.0",
-        "@spectrum-web-components/icons-ui": "^0.3.0",
-        "@spectrum-web-components/shared": "^0.7.1",
+        "@spectrum-web-components/base": "^0.1.1",
+        "@spectrum-web-components/icons-ui": "^0.3.1",
+        "@spectrum-web-components/shared": "^0.7.2",
         "tslib": "^2.0.0"
     },
-    "gitHead": "b82af30ab0e46950f01e03c78714bb0c20229001"
+    "gitHead": "7ce968fced1870613e7ed4a9023eef6265a60154"
 }

src/Accordion.d.ts

@@ -1,2 +0,2 @@
-import { CSSResultArray, TemplateResult, PropertyValues } from '@spectrum-web-components/base';
+import { CSSResultArray, TemplateResult } from '@spectrum-web-components/base';
 import { AccordionItem } from './AccordionItem.js';
@@ -26,3 +26,2 @@ import { Focusable } from '@spectrum-web-components/shared';
     private onToggle;
-    protected firstUpdated(changes: PropertyValues): void;
 }

src/Accordion.js

@@ -43,3 +43,3 @@ /*
         }
-        this.focusElement.focus();
+        super.focus();
     }
@@ -55,7 +55,6 @@ get focusElement() {
         }
-        /* istanbul ignore else */
         if (items[index]) {
             return items[index];
         }
-        /* istanbul ignore next */
+        /* c8 ignore next */
         return this;
@@ -65,3 +64,3 @@ }
         const accordionItems = this.querySelectorAll('sp-accordion-item');
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (accordionItems.length === 0) {
@@ -77,3 +76,3 @@ return;
         const { code } = event;
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (code !== 'ArrowDown' && code !== 'ArrowUp') {
@@ -120,3 +119,3 @@ return;
         const accordionItems = this.querySelectorAll('sp-accordion-item');
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (!accordionItems) {
@@ -135,6 +134,2 @@ return;
     }
-    firstUpdated(changes) {
-        super.firstUpdated(changes);
-        this.tabIndex = 0;
-    }
 }
@@ -141,0 +136,0 @@ __decorate([

src/Accordion.ts

@@ -18,3 +18,2 @@ /*
     property,
-    PropertyValues,
 } from '@spectrum-web-components/base';
@@ -63,3 +62,3 @@
 
-        this.focusElement.focus();
+        super.focus();
     }
@@ -76,7 +75,6 @@
         }
-        /* istanbul ignore else */
         if (items[index]) {
             return items[index];
         }
-        /* istanbul ignore next */
+        /* c8 ignore next */
         return this;
@@ -87,3 +85,3 @@ }
         const accordionItems = this.querySelectorAll('sp-accordion-item');
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (accordionItems.length === 0) {
@@ -101,3 +99,3 @@ return;
         const { code } = event;
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (code !== 'ArrowDown' && code !== 'ArrowUp') {
@@ -154,3 +152,3 @@ return;
         const accordionItems = this.querySelectorAll('sp-accordion-item');
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (!accordionItems) {
@@ -170,7 +168,2 @@ return;
     }
-
-    protected firstUpdated(changes: PropertyValues): void {
-        super.firstUpdated(changes);
-        this.tabIndex = 0;
-    }
 }

src/AccordionItem.js

@@ -48,3 +48,3 @@ /*
     onClick() {
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (this.disabled) {
@@ -51,0 +51,0 @@ return;

src/AccordionItem.ts

@@ -71,3 +71,3 @@ /*
     private onClick(): void {
-        /* istanbul ignore if */
+        /* c8 ignore next 3 */
         if (this.disabled) {
@@ -74,0 +74,0 @@ return;

No alert changes

Worsened metrics

Total package byte prevSize

113431

-0.58%

Lines of code

1348

-1.17%

Dependency changes

• Updated

  @spectrum-web-components/base@^0.1.1

• Updated

  @spectrum-web-components/icons-ui@^0.3.1

• Updated

  @spectrum-web-components/shared@^0.7.2