@surma/rollup-plugin-off-main-thread - npm Package Compare versions

Comparing version 2.2.1 to 2.2.2

index.js

@@ -150,7 +150,24 @@ /**
           if (!/^\.{1,2}\//.test(workerFile)) {
-            this.warn(
-              `Paths passed to the Worker constructor must be relative to the current file, i.e. start with ./ or ../ (just like dynamic import!). Ignoring "${workerFile}".`,
-              matchIndex
-            );
-            continue;
+            let isError = false;
+            if (directWorkerFile) {
+              // If direct worker file, it must be in `./something` form.
+              isError = true;
+            } else {
+              // If `new URL(...)` it can be in `new URL('something', import.meta.url)` form too,
+              // so just check it's not absolute.
+              if (/^(\/|https?:)/.test(workerFile)) {
+                isError = true;
+              } else {
+                // If it does turn out to be `new URL('something', import.meta.url)` form,
+                // prepend `./` so that it becomes valid module specifier.
+                workerFile = `./${workerFile}`;
+              }
+            }
+            if (isError) {
+              this.warn(
+                `Paths passed to the Worker constructor must be relative to the current file, i.e. start with ./ or ../ (just like dynamic import!). Ignoring "${workerFile}".`,
+                matchIndex
+              );
+              continue;
+            }
           }
@@ -157,0 +174,0 @@

karma.conf.js

@@ -0,0 +0,0 @@ /**

package.json

 {
   "name": "@surma/rollup-plugin-off-main-thread",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "Use Rollup with workers and ES6 modules today.",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -40,6 +40,8 @@ # rollup-plugin-off-main-thread
 
-In your project's code:
+In your project's code use a module-relative path via `new URL` to include a Worker:
 
 ```js
-const worker = new Worker("./worker.js", { type: "module" });
+const worker = new Worker(new URL("worker.js", import.meta.url), {
+  type: "module"
+});
 ```
@@ -49,10 +51,14 @@
 
-If required, the plugin also supports explicitly module-relative paths:
+If required, the plugin also supports plain literal paths:
 
 ```js
-const worker = new Worker(new URL("./worker.js", import.meta.url), {
-  type: "module"
-});
+const worker = new Worker("./worker.js", { type: "module" });
 ```
 
+However, those are less portable: in Rollup they would result in module-relative
+path, but if used directly in the browser, they'll be relative to the document
+URL instead.
+
+Hence, they're deprecated and `new URL` pattern is encouraged instead for portability.
+
 ### Importing workers as URLs
@@ -59,0 +65,0 @@

renovate.json

 {
   "extends": ["config:base"]
 }

run_tests.js

@@ -0,0 +0,0 @@ /**

tests/amd-function-name.test.js

@@ -0,0 +0,0 @@ /**

tests/asset-in-worker.test.js

@@ -0,0 +0,0 @@ /**

tests/dynamic-import.test.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/amd-function-name/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/amd-function-name/config.json

 {
   "amdFunctionName": "foo"
 }

tests/fixtures/amd-function-name/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/assets-in-worker/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/assets-in-worker/rollup.config.js

@@ -0,0 +0,0 @@ const MARKER = "my-special-import";

tests/fixtures/assets-in-worker/worker.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/dynamic-import/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/dynamic-import/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-meta-worker/a.js

@@ -0,0 +0,0 @@ let worker;

tests/fixtures/import-meta-worker/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-meta/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-meta/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url-custom-scheme/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url-custom-scheme/b.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url-custom-scheme/config.json

 {
   "urlLoaderScheme": "fancy-custom-scheme"
 }

tests/fixtures/import-worker-url-custom-scheme/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url-custom-scheme/worker.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url/b.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/import-worker-url/worker.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/module-worker/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/module-worker/b.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/module-worker/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/module-worker/rollup.config.js

@@ -0,0 +0,0 @@ module.exports = (config, outputOptions, omt) => {

tests/fixtures/module-worker/worker.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/more-workers/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/more-workers/b.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/more-workers/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/more-workers/worker_a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/more-workers/worker_b.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/public-path/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/public-path/config.json

 {
   "publicPath": "/base/tests/fixtures/public-path/build"
 }

tests/fixtures/public-path/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/simple-bundle/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/simple-bundle/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/single-default/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/single-default/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/url-import-meta-worker/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/url-import-meta-worker/b.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/url-import-meta-worker/entry.js

@@ -15,3 +15,3 @@ /**
 // The type module should get removed for AMD format!
-const w = new Worker(new URL("./worker.js", import.meta.url), {
+const w = new Worker(new URL("worker.js", import.meta.url), {
   type: "module"
@@ -18,0 +18,0 @@ });

tests/fixtures/url-import-meta-worker/worker.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/worker/a.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/worker/b.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/worker/entry.js

@@ -0,0 +0,0 @@ /**

tests/fixtures/worker/worker.js

@@ -0,0 +0,0 @@ /**

tests/import-meta-worker.test.js

@@ -0,0 +0,0 @@ /**

tests/import-meta.test.js

@@ -0,0 +0,0 @@ /**

tests/import-worker-url-custom-scheme.test.js

@@ -0,0 +0,0 @@ /**

tests/import-worker-url.test.js

@@ -0,0 +0,0 @@ /**

tests/module-worker.test.js

@@ -0,0 +0,0 @@ /**

tests/more-workers.test.js

@@ -0,0 +0,0 @@ /**

tests/public-path.test.js

@@ -0,0 +0,0 @@ /**

tests/simple-bundle.test.js

@@ -0,0 +0,0 @@ /**

tests/single-default.test.js

@@ -0,0 +0,0 @@ /**

tests/url-import-meta-worker.test.js

@@ -0,0 +0,0 @@ /**

tests/worker.test.js

@@ -0,0 +0,0 @@ /**

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

1559

increased by1.1%

Number of lines in readme file

98

increased by6.52%

Worsened metrics

Total package byte prevSize

91305

decreased by-1.43%

No dependency changes