@syncfusion/ej2-lists - npm Package Compare versions

Comparing version 16.4.42 to 16.4.44

CHANGELOG.md

@@ -5,2 +5,10 @@ # Changelog
 
+### ListView
+
+#### Bug Fixes
+
+- Fixed multiple CSS class not added properly while using `template` property in `UI Virtualization`.
+
+- Fixed height calculation in `UI Virtualization` with sample level border inclusion.
+
 ## 16.3.33 (2018-11-20)
@@ -7,0 +15,0 @@

dist/global/index.d.ts

 /*!
 *  filename: index.d.ts
-*  version : 16.4.42
+*  version : 16.4.44
 *  Copyright Syncfusion Inc. 2001 - 2018. All rights reserved.
@@ -5,0 +5,0 @@ *  Use of this code is subject to the terms of our license.

package.json

 {
   "name": "@syncfusion/ej2-lists",
-  "version": "16.4.42",
+  "version": "16.4.44",
   "description": "The listview control allows you to select an item or multiple items from a list-like interface and represents the data in interactive hierarchical structure across different layouts or views.",
@@ -5,0 +5,0 @@ "author": "Syncfusion Inc.",

src/list-view/virtualization.d.ts

@@ -18,3 +18,2 @@ import { ListView, ItemCreatedArgs, Fields, UISelectedItem } from './list-view';
     listItemHeight: number;
-    private startingHeight;
     private domItemCount;
@@ -21,0 +20,0 @@ private expectedDomItemCount;

src/list-view/virtualization.js

 import { classNames } from './list-view';
-import { EventHandler, append, isNullOrUndefined, detach } from '@syncfusion/ej2-base';
+import { EventHandler, append, isNullOrUndefined, detach, removeClass, addClass } from '@syncfusion/ej2-base';
 import { ListBase } from '../common/list-base';
@@ -98,20 +98,19 @@ var Virtualization = /** @class */ (function () {
     };
-    Virtualization.prototype.getscrollerHeight = function () {
-        return this.listViewInstance.isWindow ? (((pageYOffset - this.startingHeight) <= 0) ? 0 :
-            (pageYOffset - this.startingHeight)) : ((this.listViewInstance.element.scrollTop - this.startingHeight) <= 0) ? 0 :
-            (this.listViewInstance.element.scrollTop - this.startingHeight);
+    Virtualization.prototype.getscrollerHeight = function (startingHeight) {
+        return this.listViewInstance.isWindow ? (((pageYOffset - startingHeight) <= 0) ? 0 :
+            (pageYOffset - startingHeight)) : ((this.listViewInstance.element.scrollTop - startingHeight) <= 0) ? 0 :
+            (this.listViewInstance.element.scrollTop - startingHeight);
     };
     Virtualization.prototype.onVirtualUiScroll = function () {
         var _a;
-        if (isNullOrUndefined(this.startingHeight)) {
-            if (this.listViewInstance.isWindow) {
-                this.startingHeight = document.documentElement.getBoundingClientRect().height -
-                    this.listViewInstance.ulElement.getBoundingClientRect().height;
-            }
-            else {
-                this.startingHeight = this.listViewInstance.headerEle ? this.listViewInstance.headerEle.getBoundingClientRect().height : 0;
-            }
-            this.scrollPosition = 0;
+        var startingHeight;
+        if (this.listViewInstance.isWindow) {
+            startingHeight = this.listViewInstance.ulElement.getBoundingClientRect().top -
+                document.documentElement.getBoundingClientRect().top;
         }
-        var scroll = this.getscrollerHeight();
+        else {
+            startingHeight = this.listViewInstance.headerEle ? this.listViewInstance.headerEle.getBoundingClientRect().height : 0;
+        }
+        this.scrollPosition = isNullOrUndefined(this.scrollPosition) ? 0 : this.scrollPosition;
+        var scroll = this.getscrollerHeight(startingHeight);
         this.topElementHeight = this.listItemHeight * Math.floor(scroll / this.listItemHeight);
@@ -404,2 +403,3 @@ this.bottomElementHeight = this.totalHeight - this.topElementHeight;
                 else if (!isSelected) {
+                    this.listViewInstance.removeSelect();
                     this.listViewInstance.trigger('select', eventArgs);
@@ -730,5 +730,10 @@ }
                 subNode.onChange = function (value) {
-                    element.classList.remove(subNode.bindedvalue);
-                    element.classList.add(classFunction(value));
-                    subNode.bindedvalue = classFunction(value);
+                    if (subNode.bindedvalue) {
+                        removeClass([element], subNode.bindedvalue.split(' ').filter(function (css) { return css; }));
+                    }
+                    var newCss = classFunction(value);
+                    if (newCss) {
+                        addClass([element], (newCss).split(' ').filter(function (css) { return css; }));
+                    }
+                    subNode.bindedvalue = newCss;
                 };
@@ -738,3 +743,5 @@ classNameMatch[0].split(' ').forEach(function (className) {
                 });
-                element.classList.add(subNode.bindedvalue);
+                if (subNode.bindedvalue) {
+                    addClass([element], subNode.bindedvalue.split(' ').filter(function (css) { return css; }));
+                }
                 _this.updateContextData(listElement, subNode, isHeader);
@@ -741,0 +748,0 @@ });

New alerts

Uses eval

Supply chain risk

Package uses dynamic code execution (e.g., eval()), which is a dangerous practice. This can prevent the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1883850

increased by0.23%

Lines of code

17153

increased by0.12%

No dependency changes