@twilio/webrtc - npm Package Compare versions

Comparing version 2.1.3 to 2.1.4

CHANGELOG.md

@@ -0,1 +1,11 @@
+2.1.4 (December 5, 2018)
+=========================
+
+Bug Fixes
+---------
+
+- Fixed a bug in SafariRTCPeerConnection where `remoteDescription`,
+  when accessed in an RTCTrackEvent listener returned pending remote description
+  even though a new RTCSessionDescription had already been applied. (JSDK-2224)
+
 2.1.3 (August 28, 2018)
@@ -2,0 +12,0 @@ =======================

lib/rtcpeerconnection/safari.js

@@ -21,2 +21,3 @@ /* globals RTCPeerConnection, RTCSessionDescription */
   util.interceptEvent(this, 'signalingstatechange');
+  util.interceptEvent(this, 'track');
 
@@ -132,2 +133,11 @@ var peerConnection = new RTCPeerConnection(configuration);
 
+  // NOTE(syerrapragada): This ensures that SafariRTCPeerConnection's "remoteDescription", when accessed
+  // in an RTCTrackEvent listener, will point to the underlying RTCPeerConnection's
+  // "remoteDescription". Before this fix, this was still pointing to "_pendingRemoteOffer"
+  // even though a new remote RTCSessionDescription had already been applied.
+  peerConnection.addEventListener('track', function ontrack(event) {
+    self._pendingRemoteOffer = null;
+    self.dispatchEvent(event);
+  });
+
   util.proxyProperties(RTCPeerConnection.prototype, this, peerConnection);
@@ -134,0 +144,0 @@ }

package.json

 {
   "name": "@twilio/webrtc",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "description": "WebRTC-related APIs and shims used by twilio-video.js",
@@ -5,0 +5,0 @@ "scripts": {

No alert changes

Improved metrics

Total package byte prevSize

109636

increased by0.78%

Lines of code

2541

increased by0.36%

No dependency changes