@vaadin/component-base - npm Package Compare versions

Comparing version 23.3.0-alpha1 to 23.3.0-alpha2

package.json

 {
   "name": "@vaadin/component-base",
-  "version": "23.3.0-alpha1",
+  "version": "23.3.0-alpha2",
   "publishConfig": {
@@ -45,3 +45,3 @@ "access": "public"
   },
-  "gitHead": "beabc527d4b1274eb798ff701d406fed45cfe638"
+  "gitHead": "ae61027c62ffa7f7d70cfc50e43f333addfc74b6"
 }

src/dom-utils.d.ts

@@ -26,1 +26,6 @@ /**
 export function removeValueFromAttribute(element: HTMLElement, attr: string, value: string): void;
+
+/**
+ * Returns true if the given node is an empty text node, false otherwise.
+ */
+export function isEmptyTextNode(node: Node): boolean;

src/dom-utils.js

@@ -93,1 +93,11 @@ /**
 }
+
+/**
+ * Returns true if the given node is an empty text node, false otherwise.
+ *
+ * @param {Node} node
+ * @return {boolean}
+ */
+export function isEmptyTextNode(node) {
+  return node.nodeType === Node.TEXT_NODE && node.textContent.trim() === '';
+}

src/element-mixin.js

@@ -42,3 +42,3 @@ /**
     static get version() {
-      return '23.3.0-alpha1';
+      return '23.3.0-alpha2';
     }
@@ -45,0 +45,0 @@

src/tooltip-controller.d.ts

@@ -27,3 +27,3 @@ /**
   /**
-   * Object with properties passed to `textGenerator`
+   * Object with properties passed to `generator`
    * function to be used for generating tooltip text.
@@ -56,3 +56,3 @@ */
   /**
-   * Set a context object to be used by text generator.
+   * Set a context object to be used by generator.
    */
@@ -59,0 +59,0 @@ setContext(context: Record<string, unknown>): void;

src/tooltip-controller.js

@@ -42,3 +42,3 @@ /**
     if (this.position !== undefined) {
-      tooltipNode.position = this.position;
+      this.__updatePosition(tooltipNode, this.position);
     }
@@ -52,3 +52,3 @@
   /**
-   * Set a context object to be used by text generator.
+   * Set a context object to be used by generator.
    * @param {object} context
@@ -98,6 +98,3 @@ */
 
-    const tooltipNode = this.node;
-    if (tooltipNode) {
-      tooltipNode.position = position;
-    }
+    this.__updatePosition(this.node, position);
   }
@@ -131,2 +128,9 @@
   }
+
+  /** @private */
+  __updatePosition(node, position) {
+    if (node && !node.hasAttribute('position')) {
+      node.position = position;
+    }
+  }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

193694

increased by0.25%

Lines of code

5645

increased by0.28%

No dependency changes