@vaadin/field-base - npm Package Compare versions

Comparing version 23.1.0-alpha1 to 23.1.0-alpha2

package.json

 {
   "name": "@vaadin/field-base",
-  "version": "23.1.0-alpha1",
+  "version": "23.1.0-alpha2",
   "publishConfig": {
@@ -35,3 +35,3 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "23.1.0-alpha1",
+    "@vaadin/component-base": "23.1.0-alpha2",
     "lit": "^2.0.0"
@@ -44,3 +44,3 @@ },
   },
-  "gitHead": "5d0cdee069f866037c507265fafb4d0476795333"
+  "gitHead": "6842dcb8b163d4512fae8d3d12a6559077a4aee6"
 }

src/delegate-focus-mixin.js

@@ -36,2 +36,4 @@ /**
            *
+           * Toggling `tabindex` attribute on the host element propagates its value to `focusElement`.
+           *
            * @protected
@@ -47,12 +49,11 @@ * @type {!HTMLElement}
           /**
-           * Indicates whether the element can be focused and where it participates in sequential keyboard navigation.
+           * Override the property from `TabIndexMixin`
+           * to ensure the `tabindex` attribute of the focus element
+           * will be restored to `0` after re-enabling the element.
            *
-           * By default, the host element does not have tabindex attribute. Instead, `focusElement` should have it.
-           * Toggling `tabindex` attribute on the host element propagates its value to `focusElement`.
-           *
            * @protected
+           * @override
            */
-          tabindex: {
-            type: Number,
-            value: undefined
+          _lastTabIndex: {
+            value: 0
           }
@@ -223,3 +224,3 @@ };
           if (tabindex !== -1) {
-            this.__lastTabIndex = tabindex;
+            this._lastTabIndex = tabindex;
           }
@@ -226,0 +227,0 @@ this.tabindex = undefined;

src/shadow-focus-mixin.js

@@ -23,2 +23,3 @@ /**
          *
+         * @override
          * @protected
@@ -92,3 +93,3 @@ */
         if (tabindex !== -1) {
-          this.__lastTabIndex = tabindex;
+          this._lastTabIndex = tabindex;
         }
@@ -95,0 +96,0 @@ this.tabindex = undefined;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

3172

increased by0.06%

Worsened metrics

Total package byte prevSize

114266

decreased by-0.03%

Dependency changes

• + Added@vaadin/component-base@23.1.0-alpha2(transitive)

• - Removed@vaadin/component-base@23.1.0-alpha1(transitive)

• Updated@vaadin/component-base@23.1.0-alpha2