@vaadin/field-base - npm Package Compare versions

Comparing version 24.7.0-alpha2 to 24.7.0-alpha3

package.json

 {
   "name": "@vaadin/field-base",
-  "version": "24.7.0-alpha2",
+  "version": "24.7.0-alpha3",
   "publishConfig": {
@@ -35,12 +35,12 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/a11y-base": "24.7.0-alpha2",
-    "@vaadin/component-base": "24.7.0-alpha2",
+    "@vaadin/a11y-base": "24.7.0-alpha3",
+    "@vaadin/component-base": "24.7.0-alpha3",
     "lit": "^3.0.0"
   },
   "devDependencies": {
-    "@vaadin/chai-plugins": "24.7.0-alpha2",
-    "@vaadin/testing-helpers": "^1.0.0",
+    "@vaadin/chai-plugins": "24.7.0-alpha3",
+    "@vaadin/testing-helpers": "^1.1.0",
     "sinon": "^18.0.0"
   },
-  "gitHead": "e2523f9b4abc5a9586fb758166f823dc40c399dd"
+  "gitHead": "dd5cfad6c9b54e676f5b10dffba2233775378f40"
 }

src/error-controller.js

@@ -6,2 +6,3 @@ /**
  */
+import { announce } from '@vaadin/a11y-base/src/announce.js';
 import { SlotChildObserveController } from '@vaadin/component-base/src/slot-child-observe-controller.js';
@@ -112,8 +113,6 @@
 
-      // Role alert will make the error message announce immediately
-      // as the field becomes invalid
       if (hasError) {
-        errorNode.setAttribute('role', 'alert');
-      } else {
-        errorNode.removeAttribute('role');
+        // Assertive mode ensures VoiceOver reads
+        // the error message on commit with Enter.
+        announce(errorMessage, { mode: 'assertive' });
       }
@@ -120,0 +119,0 @@ }

src/input-mixin.d.ts

@@ -71,4 +71,2 @@ /**
   protected _valueChanged(value?: string, oldValue?: string): void;
-
-  protected _setHasInputValue(event: InputEvent): void;
 }

src/input-mixin.js

@@ -209,3 +209,3 @@ /**
       __onInput(event) {
-        this._setHasInputValue(event);
+        this._hasInputValue = !!this._inputElementValue;
         this._onInput(event);
@@ -271,17 +271,3 @@ }
       }
-
-      /**
-       * Sets the `_hasInputValue` property based on the `input` event.
-       *
-       * @param {InputEvent} event
-       * @protected
-       */
-      _setHasInputValue(event) {
-        // In the case a custom web component is passed as `inputElement`,
-        // the actual native input element, on which the event occurred,
-        // can be inside shadow trees.
-        const target = event.composedPath()[0];
-        this._hasInputValue = target.value.length > 0;
-      }
     },
 );

No alert changes

Worsened metrics

Total package byte prevSize

89227

decreased by-0.58%

Lines of code

2307

decreased by-0.65%

Dependency changes

• + Added@vaadin/a11y-base@24.7.0-alpha3(transitive)

• + Added@vaadin/component-base@24.7.0-alpha3(transitive)

• - Removed@vaadin/a11y-base@24.7.0-alpha2(transitive)

• - Removed@vaadin/component-base@24.7.0-alpha2(transitive)

• Updated@vaadin/a11y-base@24.7.0-alpha3

• Updated@vaadin/component-base@24.7.0-alpha3