@vaadin/popover - npm Package Compare versions

Comparing version 24.7.0-alpha1 to 24.7.0-alpha2

package.json

 {
   "name": "@vaadin/popover",
-  "version": "24.7.0-alpha1",
+  "version": "24.7.0-alpha2",
   "publishConfig": {
@@ -40,13 +40,13 @@ "access": "public"
     "@open-wc/dedupe-mixin": "^1.3.0",
-    "@vaadin/a11y-base": "24.7.0-alpha1",
-    "@vaadin/component-base": "24.7.0-alpha1",
-    "@vaadin/lit-renderer": "24.7.0-alpha1",
-    "@vaadin/overlay": "24.7.0-alpha1",
-    "@vaadin/vaadin-lumo-styles": "24.7.0-alpha1",
-    "@vaadin/vaadin-material-styles": "24.7.0-alpha1",
-    "@vaadin/vaadin-themable-mixin": "24.7.0-alpha1",
+    "@vaadin/a11y-base": "24.7.0-alpha2",
+    "@vaadin/component-base": "24.7.0-alpha2",
+    "@vaadin/lit-renderer": "24.7.0-alpha2",
+    "@vaadin/overlay": "24.7.0-alpha2",
+    "@vaadin/vaadin-lumo-styles": "24.7.0-alpha2",
+    "@vaadin/vaadin-material-styles": "24.7.0-alpha2",
+    "@vaadin/vaadin-themable-mixin": "24.7.0-alpha2",
     "lit": "^3.0.0"
   },
   "devDependencies": {
-    "@vaadin/chai-plugins": "24.7.0-alpha1",
+    "@vaadin/chai-plugins": "24.7.0-alpha2",
     "@vaadin/testing-helpers": "^1.0.0",
@@ -59,3 +59,3 @@ "sinon": "^18.0.0"
   ],
-  "gitHead": "04be941c9a7b659871c97f31b9cc3ffd7528087b"
+  "gitHead": "e2523f9b4abc5a9586fb758166f823dc40c399dd"
 }

src/vaadin-popover-target-mixin.js

@@ -37,7 +37,16 @@ /**
           type: Object,
-          observer: '__targetChanged',
         },
+
+        /** @private */
+        __isConnected: {
+          type: Boolean,
+          sync: true,
+        },
       };
     }
 
+    static get observers() {
+      return ['__targetOrConnectedChanged(target, __isConnected)'];
+    }
+
     /** @protected */
@@ -47,5 +56,3 @@ connectedCallback() {
 
-      if (this.target) {
-        this._addTargetListeners(this.target);
-      }
+      this.__isConnected = true;
     }
@@ -57,5 +64,3 @@
 
-      if (this.target) {
-        this._removeTargetListeners(this.target);
-      }
+      this.__isConnected = false;
     }
@@ -88,10 +93,12 @@
     /** @private */
-    __targetChanged(target, oldTarget) {
-      if (oldTarget) {
-        this._removeTargetListeners(oldTarget);
+    __targetOrConnectedChanged(target, isConnected) {
+      if (this.__previousTarget && (this.__previousTarget !== target || !isConnected)) {
+        this._removeTargetListeners(this.__previousTarget);
       }
 
-      if (target) {
+      if (target && isConnected) {
         this._addTargetListeners(target);
       }
+
+      this.__previousTarget = target;
     }
@@ -98,0 +105,0 @@

src/vaadin-popover.js

@@ -519,3 +519,3 @@ /**
 
-    this._overlayElement = this.shadowRoot.querySelector('vaadin-popover-overlay');
+    this._overlayElement = this.$[this.__overlayId];
   }
@@ -522,0 +522,0 @@

web-types.json

 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/popover",
-  "version": "24.7.0-alpha1",
+  "version": "24.7.0-alpha2",
   "description-markup": "markdown",
@@ -11,3 +11,3 @@ "contributions": {
           "name": "vaadin-popover",
-          "description": "`<vaadin-popover>` is a Web Component for creating overlays\nthat are positioned next to specified DOM element (target).\n\nUnlike `<vaadin-tooltip>`, the popover supports rich content\nthat can be provided by using `renderer` function.\n\n### Styling\n\n`<vaadin-popover>` uses `<vaadin-popover-overlay>` internal\nthemable component as the actual visible overlay.\n\nSee [`<vaadin-overlay>`](https://cdn.vaadin.com/vaadin-web-components/24.7.0-alpha1/#/elements/vaadin-overlay) documentation\nfor `<vaadin-popover-overlay>` parts.\n\nIn addition to `<vaadin-overlay>` parts, the following parts are available for styling:\n\nPart name        | Description\n-----------------|-------------------------------------------\n`arrow`          | Optional arrow pointing to the target when using `theme=\"arrow\"`\n\nThe following state attributes are available for styling:\n\nAttribute        | Description\n-----------------|----------------------------------------\n`position`       | Reflects the `position` property value.\n\nNote: the `theme` attribute value set on `<vaadin-popover>` is\npropagated to the internal `<vaadin-popover-overlay>` component.\n\n### Custom CSS Properties\n\nThe following custom CSS properties are available on the `<vaadin-popover>` element:\n\nCustom CSS property              | Description\n---------------------------------|-------------\n`--vaadin-popover-offset-top`    | Used as an offset when the popover is aligned vertically below the target\n`--vaadin-popover-offset-bottom` | Used as an offset when the popover is aligned vertically above the target\n`--vaadin-popover-offset-start`  | Used as an offset when the popover is aligned horizontally after the target\n`--vaadin-popover-offset-end`    | Used as an offset when the popover is aligned horizontally before the target\n\nSee [Styling Components](https://vaadin.com/docs/latest/styling/styling-components) documentation.",
+          "description": "`<vaadin-popover>` is a Web Component for creating overlays\nthat are positioned next to specified DOM element (target).\n\nUnlike `<vaadin-tooltip>`, the popover supports rich content\nthat can be provided by using `renderer` function.\n\n### Styling\n\n`<vaadin-popover>` uses `<vaadin-popover-overlay>` internal\nthemable component as the actual visible overlay.\n\nSee [`<vaadin-overlay>`](https://cdn.vaadin.com/vaadin-web-components/24.7.0-alpha2/#/elements/vaadin-overlay) documentation\nfor `<vaadin-popover-overlay>` parts.\n\nIn addition to `<vaadin-overlay>` parts, the following parts are available for styling:\n\nPart name        | Description\n-----------------|-------------------------------------------\n`arrow`          | Optional arrow pointing to the target when using `theme=\"arrow\"`\n\nThe following state attributes are available for styling:\n\nAttribute        | Description\n-----------------|----------------------------------------\n`position`       | Reflects the `position` property value.\n\nNote: the `theme` attribute value set on `<vaadin-popover>` is\npropagated to the internal `<vaadin-popover-overlay>` component.\n\n### Custom CSS Properties\n\nThe following custom CSS properties are available on the `<vaadin-popover>` element:\n\nCustom CSS property              | Description\n---------------------------------|-------------\n`--vaadin-popover-offset-top`    | Used as an offset when the popover is aligned vertically below the target\n`--vaadin-popover-offset-bottom` | Used as an offset when the popover is aligned vertically above the target\n`--vaadin-popover-offset-start`  | Used as an offset when the popover is aligned horizontally after the target\n`--vaadin-popover-offset-end`    | Used as an offset when the popover is aligned horizontally before the target\n\nSee [Styling Components](https://vaadin.com/docs/latest/styling/styling-components) documentation.",
           "attributes": [
@@ -14,0 +14,0 @@ {

web-types.lit.json

 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/popover",
-  "version": "24.7.0-alpha1",
+  "version": "24.7.0-alpha2",
   "description-markup": "markdown",
@@ -19,3 +19,3 @@ "framework": "lit",
           "name": "vaadin-popover",
-          "description": "`<vaadin-popover>` is a Web Component for creating overlays\nthat are positioned next to specified DOM element (target).\n\nUnlike `<vaadin-tooltip>`, the popover supports rich content\nthat can be provided by using `renderer` function.\n\n### Styling\n\n`<vaadin-popover>` uses `<vaadin-popover-overlay>` internal\nthemable component as the actual visible overlay.\n\nSee [`<vaadin-overlay>`](https://cdn.vaadin.com/vaadin-web-components/24.7.0-alpha1/#/elements/vaadin-overlay) documentation\nfor `<vaadin-popover-overlay>` parts.\n\nIn addition to `<vaadin-overlay>` parts, the following parts are available for styling:\n\nPart name        | Description\n-----------------|-------------------------------------------\n`arrow`          | Optional arrow pointing to the target when using `theme=\"arrow\"`\n\nThe following state attributes are available for styling:\n\nAttribute        | Description\n-----------------|----------------------------------------\n`position`       | Reflects the `position` property value.\n\nNote: the `theme` attribute value set on `<vaadin-popover>` is\npropagated to the internal `<vaadin-popover-overlay>` component.\n\n### Custom CSS Properties\n\nThe following custom CSS properties are available on the `<vaadin-popover>` element:\n\nCustom CSS property              | Description\n---------------------------------|-------------\n`--vaadin-popover-offset-top`    | Used as an offset when the popover is aligned vertically below the target\n`--vaadin-popover-offset-bottom` | Used as an offset when the popover is aligned vertically above the target\n`--vaadin-popover-offset-start`  | Used as an offset when the popover is aligned horizontally after the target\n`--vaadin-popover-offset-end`    | Used as an offset when the popover is aligned horizontally before the target\n\nSee [Styling Components](https://vaadin.com/docs/latest/styling/styling-components) documentation.",
+          "description": "`<vaadin-popover>` is a Web Component for creating overlays\nthat are positioned next to specified DOM element (target).\n\nUnlike `<vaadin-tooltip>`, the popover supports rich content\nthat can be provided by using `renderer` function.\n\n### Styling\n\n`<vaadin-popover>` uses `<vaadin-popover-overlay>` internal\nthemable component as the actual visible overlay.\n\nSee [`<vaadin-overlay>`](https://cdn.vaadin.com/vaadin-web-components/24.7.0-alpha2/#/elements/vaadin-overlay) documentation\nfor `<vaadin-popover-overlay>` parts.\n\nIn addition to `<vaadin-overlay>` parts, the following parts are available for styling:\n\nPart name        | Description\n-----------------|-------------------------------------------\n`arrow`          | Optional arrow pointing to the target when using `theme=\"arrow\"`\n\nThe following state attributes are available for styling:\n\nAttribute        | Description\n-----------------|----------------------------------------\n`position`       | Reflects the `position` property value.\n\nNote: the `theme` attribute value set on `<vaadin-popover>` is\npropagated to the internal `<vaadin-popover-overlay>` component.\n\n### Custom CSS Properties\n\nThe following custom CSS properties are available on the `<vaadin-popover>` element:\n\nCustom CSS property              | Description\n---------------------------------|-------------\n`--vaadin-popover-offset-top`    | Used as an offset when the popover is aligned vertically below the target\n`--vaadin-popover-offset-bottom` | Used as an offset when the popover is aligned vertically above the target\n`--vaadin-popover-offset-start`  | Used as an offset when the popover is aligned horizontally after the target\n`--vaadin-popover-offset-end`    | Used as an offset when the popover is aligned horizontally before the target\n\nSee [Styling Components](https://vaadin.com/docs/latest/styling/styling-components) documentation.",
           "extension": true,
@@ -22,0 +22,0 @@ "attributes": [

No alert changes

Improved metrics

Total package byte prevSize

109029

increased by0.18%

Lines of code

2492

increased by0.16%

Dependency changes

• + Added@vaadin/a11y-base@24.7.0-alpha2(transitive)

• + Added@vaadin/component-base@24.7.0-alpha2(transitive)

• + Added@vaadin/icon@24.7.0-alpha2(transitive)

• + Added@vaadin/lit-renderer@24.7.0-alpha2(transitive)

• + Added@vaadin/overlay@24.7.0-alpha2(transitive)

• + Added@vaadin/vaadin-lumo-styles@24.7.0-alpha2(transitive)

• + Added@vaadin/vaadin-material-styles@24.7.0-alpha2(transitive)

• + Added@vaadin/vaadin-themable-mixin@24.7.0-alpha2(transitive)

• - Removed@vaadin/a11y-base@24.7.0-alpha1(transitive)

• - Removed@vaadin/component-base@24.7.0-alpha1(transitive)

• - Removed@vaadin/icon@24.7.0-alpha1(transitive)

• - Removed@vaadin/lit-renderer@24.7.0-alpha1(transitive)

• - Removed@vaadin/overlay@24.7.0-alpha1(transitive)

• - Removed@vaadin/vaadin-lumo-styles@24.7.0-alpha1(transitive)

• - Removed@vaadin/vaadin-material-styles@24.7.0-alpha1(transitive)

• - Removed@vaadin/vaadin-themable-mixin@24.7.0-alpha1(transitive)

• Updated@vaadin/a11y-base@24.7.0-alpha2

• Updated@vaadin/component-base@24.7.0-alpha2

• Updated@vaadin/lit-renderer@24.7.0-alpha2

• Updated@vaadin/overlay@24.7.0-alpha2

• Updated@vaadin/vaadin-lumo-styles@24.7.0-alpha2

• Updated@vaadin/vaadin-material-styles@24.7.0-alpha2

• Updated@vaadin/vaadin-themable-mixin@24.7.0-alpha2