@whatwg-node/promise-helpers - npm Package Compare versions

Comparing version 1.3.0-alpha-20250309212441-647d37e64b7ad6c4cba6a36fc1dfde8a18d3d5eb to 1.3.0-alpha-20250309213039-06310a2c7700f4ccdf4832aa475b24fa0db42f4a

cjs/index.js

@@ -23,17 +23,3 @@ "use strict";
 function handleMaybePromise(inputFactory, outputSuccessFactory, outputErrorFactory, finallyFactory) {
-    // let result$ = fakePromise().then(inputFactory).then(outputSuccessFactory, outputErrorFactory);
-    let input$;
-    try {
-        input$ = fakePromise(inputFactory());
-    }
-    catch (err) {
-        input$ = fakeRejectPromise(err);
-    }
-    let result$;
-    try {
-        result$ = input$.then(outputSuccessFactory, outputErrorFactory);
-    }
-    catch (err) {
-        result$ = fakeRejectPromise(err);
-    }
+    let result$ = fakePromise().then(inputFactory).then(outputSuccessFactory, outputErrorFactory);
     if (finallyFactory) {
@@ -45,13 +31,16 @@ result$ = result$.finally(finallyFactory);
 function fakePromise(value) {
-    if (value && isActualPromise(value)) {
+    // if (value && isActualPromise(value)) {
+    //   return value;
+    // }
+    // if (isPromise(value)) {
+    //   return {
+    //     then: (resolve, reject) => fakePromise(value.then(resolve, reject)),
+    //     catch: reject => fakePromise(value.then(res => res, reject)),
+    //     finally: cb => fakePromise(cb ? promiseLikeFinally(value, cb) : value),
+    //     [Symbol.toStringTag]: 'Promise',
+    //   };
+    // }
+    if (isPromise(value)) {
         return value;
     }
-    if (isPromise(value)) {
-        return {
-            then: (resolve, reject) => fakePromise(value.then(resolve, reject)),
-            catch: reject => fakePromise(value.then(res => res, reject)),
-            finally: cb => fakePromise(cb ? promiseLikeFinally(value, cb) : value),
-            [Symbol.toStringTag]: 'Promise',
-        };
-    }
     // Write a fake promise to avoid the promise constructor
@@ -66,4 +55,3 @@ // being called with `new Promise` in the browser.
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -82,4 +70,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -148,4 +135,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -161,4 +147,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -174,4 +159,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -178,0 +162,0 @@ }

esm/index.js

@@ -9,17 +9,3 @@ export function isPromise(value) {
 export function handleMaybePromise(inputFactory, outputSuccessFactory, outputErrorFactory, finallyFactory) {
-    // let result$ = fakePromise().then(inputFactory).then(outputSuccessFactory, outputErrorFactory);
-    let input$;
-    try {
-        input$ = fakePromise(inputFactory());
-    }
-    catch (err) {
-        input$ = fakeRejectPromise(err);
-    }
-    let result$;
-    try {
-        result$ = input$.then(outputSuccessFactory, outputErrorFactory);
-    }
-    catch (err) {
-        result$ = fakeRejectPromise(err);
-    }
+    let result$ = fakePromise().then(inputFactory).then(outputSuccessFactory, outputErrorFactory);
     if (finallyFactory) {
@@ -31,13 +17,16 @@ result$ = result$.finally(finallyFactory);
 export function fakePromise(value) {
-    if (value && isActualPromise(value)) {
+    // if (value && isActualPromise(value)) {
+    //   return value;
+    // }
+    // if (isPromise(value)) {
+    //   return {
+    //     then: (resolve, reject) => fakePromise(value.then(resolve, reject)),
+    //     catch: reject => fakePromise(value.then(res => res, reject)),
+    //     finally: cb => fakePromise(cb ? promiseLikeFinally(value, cb) : value),
+    //     [Symbol.toStringTag]: 'Promise',
+    //   };
+    // }
+    if (isPromise(value)) {
         return value;
     }
-    if (isPromise(value)) {
-        return {
-            then: (resolve, reject) => fakePromise(value.then(resolve, reject)),
-            catch: reject => fakePromise(value.then(res => res, reject)),
-            finally: cb => fakePromise(cb ? promiseLikeFinally(value, cb) : value),
-            [Symbol.toStringTag]: 'Promise',
-        };
-    }
     // Write a fake promise to avoid the promise constructor
@@ -52,4 +41,3 @@ // being called with `new Promise` in the browser.
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -68,4 +56,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -135,4 +122,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -148,4 +134,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -161,4 +146,3 @@ }
                 catch (err) {
-                    throw err;
-                    // return fakeRejectPromise(err);
+                    return fakeRejectPromise(err);
                 }
@@ -165,0 +149,0 @@ }

package.json

 {
   "name": "@whatwg-node/promise-helpers",
-  "version": "1.3.0-alpha-20250309212441-647d37e64b7ad6c4cba6a36fc1dfde8a18d3d5eb",
+  "version": "1.3.0-alpha-20250309213039-06310a2c7700f4ccdf4832aa475b24fa0db42f4a",
   "description": "Promise helpers",
@@ -5,0 +5,0 @@ "sideEffects": false,

No alert changes

Worsened metrics

Total package byte prevSize

22580

-3.59%

Lines of code

556

-5.44%

No dependency changes