@wmfs/statelint - npm Package Compare versions

Comparing version 1.6.0 to 1.6.1

lib/statelint/state_node.js

@@ -91,3 +91,3 @@ class StateNode {
 
-    for (const [index, element] of Object.entries(node)) {
+    for (const [index, element] of node.entries()) {
       const ee = element.ErrorEquals
@@ -98,3 +98,3 @@
       if (ee.includes('States.ALL')) {
-        if (index !== (node.length - 1) || ee.size !== 1) {
+        if (index !== (node.length - 1) || ee.length !== 1) {
           problems.push(`${path}[${index}]: States.ALL can only appear in the last element, and by itself.`)
@@ -101,0 +101,0 @@ }

package.json

 {
   "name": "@wmfs/statelint",
-  "version": "1.6.0",
+  "version": "1.6.1",
   "description": "Validator for Amazon States Language JSON files.",
@@ -5,0 +5,0 @@ "author": "West Midlands Fire Service",

test/state_node_test.js

@@ -40,3 +40,3 @@ /* eslint-env mocha */
   verify(
-    'should find States.ALL not in last position',
+    'should find States.ALL not in last position of a Retry',
     {
@@ -52,2 +52,12 @@ Retry: [
   verify(
+    'should find States.ALL not in last position of a Catch',
+    {
+      Catch: [
+        { ErrorEquals: ['States.ALL'], Next: 'Zumba' },
+        { ErrorEquals: ['YET ANOTHER'], Next: 'Insanity' }
+      ]
+    },
+    1
+  )
+  verify(
     'should find States.ALL not by itself',
@@ -54,0 +64,0 @@ {

test/statelint_test.js

@@ -11,3 +11,3 @@ /* eslint-env mocha */
   verify(
-    'allow Fail states to omit optional Cause/Error fields',
+    'Allow Fail states to omit optional Cause/Error fields',
     require('./fixtures/minimal-fail-state.json'),
@@ -223,2 +223,9 @@ 0
   })
+
+  describe('Validate Catch', () => {
+    verify(
+      'Catch States.ALL',
+      require('./fixtures/hello-world-with-caught-failures'),
+      0)
+  })
 })
@@ -231,3 +238,3 @@
 
-    // console.log(problems)
+    console.log(problems)
 
@@ -234,0 +241,0 @@ expect(problems.length).to.eql(count)

No alert changes

Improved metrics

Total package byte prevSize

39576

3.08%

Number of package files

28

3.7%

Lines of code

870

6.49%

No dependency changes