angular-router-loader - npm Package Compare versions

Comparing version 0.8.1 to 0.8.2

CHANGELOG.md

@@ -0,1 +1,6 @@
+<a name="0.8.2"></a>
+## [0.8.2](https://github.com/brandonroberts/angular-router-loader/compare/v0.8.1...v0.8.2) (2018-01-03)
+
+
+
 <a name="0.8.1"></a>
@@ -93,3 +98,3 @@ ## [0.8.1](https://github.com/brandonroberts/angular-router-loader/compare/v0.8.0...v0.8.1) (2017-12-19)
 <a name="0.3.1"></a>
-## [0.3.1](https://github.com/brandonroberts/angular-router-loader/compare/v0.3.0...v0.3.1) (2016-10-07)
+## [0.3.1](https://github.com/brandonroberts/angular-router-loader/compare/v0.2.2...v0.3.1) (2016-10-07)
 
@@ -102,7 +107,2 @@
 
-
-<a name="0.3.0"></a>
-# [0.3.0](https://github.com/brandonroberts/angular-router-loader/compare/v0.2.2...v0.3.0) (2016-10-04)
-
-
 ### Features
@@ -109,0 +109,0 @@

package.json

 {
   "name": "angular-router-loader",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "description": "A webpack loader for Angular that enables string-based module loading with the Angular Router",
@@ -5,0 +5,0 @@ "main": "src/index.js",

spec/index.spec.js

@@ -48,9 +48,9 @@ var should = require('should');
         var result = [
-          'loadChildren: () => new Promise(function (resolve, reject) {',
+          'loadChildren: function() { return new Promise(function (resolve, reject) {',
           '  (require as any).ensure([], function (require: any) {',
           '    resolve(require(\'./path/to/file.module\')[\'FileModule\']);',
-          '  }, function () {',
+          '  }, function() {',
           '    reject({ loadChunkError: true });',
           '  });',
-          '})'
+          '}) }'
         ];
@@ -79,9 +79,9 @@
           var result = [
-            'loadChildren: () => new Promise(function (resolve, reject) {',
+            'loadChildren: function() { return new Promise(function (resolve, reject) {',
             '  (require as any).ensure([], function (require: any) {',
             '    resolve(require(\'./path/to/file.module\')[\'FileModule\']);',
-            '  }, function () {',
+            '  }, function() {',
             '    reject({ loadChunkError: true });',
             '  });',
-            '})'
+            '}) }'
           ];
@@ -104,9 +104,9 @@
     var result = [
-      'loadChildren: () => new Promise(function (resolve, reject) {',
+      'loadChildren: function() { return new Promise(function (resolve, reject) {',
       '  (require as any).ensure([], function (require: any) {',
       '    resolve(require(\'./path/to/file.module\')[\'FileModule\']);',
-      '  }, function () {',
+      '  }, function() {',
       '    reject({ loadChunkError: true });',
       '  });',
-      '})'
+      '}) }'
     ];
@@ -124,9 +124,9 @@
     var result = [
-      'loadChildren: function () { return new Promise(function (resolve, reject) {',
+      'loadChildren: function() { return new Promise(function (resolve, reject) {',
       '  require.ensure([], function (require) {',
       '    resolve(require(\'./path/to/file.module\')[\'FileModule\']);',
-      '  }, function () {',
+      '  }, function() {',
       '    reject({ loadChunkError: true });',
       '  });',
-      '})}'
+      '}) }'
     ];
@@ -159,9 +159,9 @@
     var result = [
-      'loadChildren: () => new Promise(function (resolve, reject) {',
+      'loadChildren: function() { return new Promise(function (resolve, reject) {',
       '  (require as any).ensure([], function (require: any) {',
       '    resolve(require(\'./path/to/file.module\')[\'FileModule\']);',
-      '  }, function () {',
+      '  }, function() {',
       '    reject({ loadChunkError: true });',
       '  }, \'name\');',
-      '})'
+      '}) }'
     ];
@@ -179,4 +179,4 @@
     var result = [
-      'loadChildren: () => System.import(\'./path/to/file.module\')',
-      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); })'
+      'loadChildren: function() { return System.import(\'./path/to/file.module\')',
+      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); }) }'
     ];
@@ -194,4 +194,4 @@
     var result = [
-      'loadChildren: () => System.import(/* webpackChunkName: "name" */ \'./path/to/file.module\')',
-      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); })'
+      'loadChildren: function() { return System.import(/* webpackChunkName: "name" */ \'./path/to/file.module\')',
+      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); }) }'
     ];
@@ -209,4 +209,4 @@
     var result = [
-      'loadChildren: () => import(\'./path/to/file.module\')',
-      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); })'
+      'loadChildren: function() { return import(\'./path/to/file.module\')',
+      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); }) }'
     ];
@@ -224,4 +224,4 @@
     var result = [
-      'loadChildren: () => import(/* webpackChunkName: "name" */ \'./path/to/file.module\')',
-      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); })'
+      'loadChildren: function() { return import(/* webpackChunkName: "name" */ \'./path/to/file.module\')',
+      '  .then(module => module[\'FileModule\'], () => { throw({ loadChunkError: true }); }) }'
     ];
@@ -241,9 +241,9 @@
     var result = [
-      'loadChildren: () => new Promise(function (resolve, reject) {',
+      'loadChildren: function() { return new Promise(function (resolve, reject) {',
       '  (require as any).ensure([], function (require: any) {',
       '    resolve(require(\'./path/to/file.module\')[\'default\']);',
-      '  }, function () {',
+      '  }, function() {',
       '    reject({ loadChunkError: true });',
       '  });',
-      '})'
+      '}) }'
     ];
@@ -261,9 +261,9 @@
     var result = [
-      'loadChildren: () => new Promise(function (resolve, reject) {',
+      'loadChildren: function() { return new Promise(function (resolve, reject) {',
       '  (require as any).ensure([], function (require: any) {',
       '    resolve(require(\'./path/to/file.module\')[\'FileModule\']);',
-      '  }, function () {',
+      '  }, function() {',
       '    reject({ loadChunkError: true });',
       '  });',
-      '})'
+      '}) }'
     ];
@@ -284,9 +284,9 @@
     var result = [
-      'loadChildren: () => new Promise(function (resolve, reject) {',
+      'loadChildren: function() { return new Promise(function (resolve, reject) {',
       '  (require as any).ensure([], function (require: any) {',
       '    resolve(require(\'.\\\\path\\\\to\\\\file.module\')[\'FileModule\']);',
-      '  }, function () {',
+      '  }, function() {',
       '    reject({ loadChunkError: true });',
       '  });',
-      '})'
+      '}) }'
     ];
@@ -306,9 +306,9 @@
     var result = [
-      'loadChildren: () => new Promise(function (resolve, reject) {',
+      'loadChildren: function() { return new Promise(function (resolve, reject) {',
       '  (require as any).ensure([], function (require: any) {',
       '    resolve(require(\'path/to/file.module\')[\'FileModule\']);',
-      '  }, function () {',
+      '  }, function() {',
       '    reject({ loadChunkError: true });',
       '  });',
-      '})'
+      '}) }'
     ];
@@ -331,9 +331,9 @@
       var result = [
-        'loadChildren: () => new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  (require as any).ensure([], function (require: any) {',
         '    resolve(require(\'./path/to/file.module.ngfactory\')[\'FileModuleNgFactory\']);',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  });',  
-        '})'
+        '}) }'
       ];
@@ -366,4 +366,4 @@
       var result = [
-        'loadChildren: () => System.import(\'./path/to/file.module.ngfactory\')',
-        '  .then(module => module[\'FileModuleNgFactory\'], () => { throw({ loadChunkError: true }); })'
+        'loadChildren: function() { return System.import(\'./path/to/file.module.ngfactory\')',
+        '  .then(module => module[\'FileModuleNgFactory\'], () => { throw({ loadChunkError: true }); }) }'
       ];
@@ -381,4 +381,4 @@
       var result = [
-        'loadChildren: () => import(\'./path/to/file.module.ngfactory\')',
-        '  .then(module => module[\'FileModuleNgFactory\'], () => { throw({ loadChunkError: true }); })'
+        'loadChildren: function() { return import(\'./path/to/file.module.ngfactory\')',
+        '  .then(module => module[\'FileModuleNgFactory\'], () => { throw({ loadChunkError: true }); }) }'
       ];
@@ -398,9 +398,9 @@
       var result = [
-        'loadChildren: () => new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  (require as any).ensure([], function (require: any) {',
         '    resolve(require(\'./path/to/file.module' + moduleSuffix + '\')[\'FileModuleNgFactory\']);',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  });',  
-        '})'
+        '}) }'
       ];
@@ -420,9 +420,9 @@
       var result = [
-        'loadChildren: () => new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  (require as any).ensure([], function (require: any) {',
         '    resolve(require(\'./path/to/file.module.ngfactory\')[\'FileModule' + factorySuffix + '\']);',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  });',
-        '})'
+        '}) }'
       ];
@@ -440,9 +440,9 @@
       var result = [
-        'loadChildren: () => new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  (require as any).ensure([], function (require: any) {',
         '    resolve(require(\'path/to/file.module.ngfactory\')[\'FileModuleNgFactory\']);',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  });',  
-        '})'
+        '}) }'
       ];
@@ -463,3 +463,3 @@
 
-    beforeEach(function () {
+    beforeEach(function() {
       query = '?aot=true&genDir=compiled'
@@ -470,9 +470,9 @@ });
       var result = [
-        'loadChildren: () => new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  (require as any).ensure([], function (require: any) {',
         '    resolve(require(\'../../../compiled/src/app/groups/inventory/index.ngfactory\')[\'InventoryModuleNgFactory\']);',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  });',  
-        '})'
+        '}) }'
       ];
@@ -479,0 +479,0 @@

spec/utils.spec.js

@@ -35,9 +35,9 @@ var should = require('should');
       var result = [
-        'loadChildren: () => new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  (require as any).ensure([], function (require: any) {',
         '    resolve(' + getRequireString(path, name) + ');',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  }, \'name\');',  
-        '})'
+        '}) }'
       ];
@@ -49,9 +49,9 @@ getRequireLoader('path', 'name', 'name', true).should.eql(result.join(''));
       var result = [
-        'loadChildren: () => new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  (require as any).ensure([], function (require: any) {',
         '    resolve(' + getRequireString(path, name) + ');',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  });',  
-        '})'
+        '}) }'
       ];
@@ -63,9 +63,9 @@ getRequireLoader('path', undefined, 'name', true).should.eql(result.join(''));
       var result = [
-        'loadChildren: function () { return new Promise(function (resolve, reject) {',
+        'loadChildren: function() { return new Promise(function (resolve, reject) {',
         '  require.ensure([], function (require) {',
         '    resolve(' + getRequireString(path, name) + ');',
-        '  }, function () {',
+        '  }, function() {',
         '    reject({ loadChunkError: true });',
         '  }, \'name\');',  
-        '})}'
+        '}) }'
       ];
@@ -82,4 +82,4 @@ getRequireLoader('path', 'name', 'name', true, true).should.eql(result.join(''));
       var result = [
-        'loadChildren: () => System.import(\'' + path + '\')',
-        '  .then(module => module[\'' + name + '\'], () => { throw({ loadChunkError: true }); })'
+        'loadChildren: function() { return System.import(\'' + path + '\')',
+        '  .then(module => module[\'' + name + '\'], () => { throw({ loadChunkError: true }); }) }'
       ];
@@ -96,4 +96,4 @@
       var result = [
-        'loadChildren: () => import(\'' + path + '\')',
-        '  .then(module => module[\'' + name + '\'], () => { throw({ loadChunkError: true }); })'
+        'loadChildren: function() { return import(\'' + path + '\')',
+        '  .then(module => module[\'' + name + '\'], () => { throw({ loadChunkError: true }); }) }'
       ];
@@ -100,0 +100,0 @@

src/utils.js

@@ -24,9 +24,9 @@ var os = require('os');
   var result = [
-    'loadChildren: '+ (isJs ? 'function () { return' : '() =>') + ' new Promise(function (resolve, reject) {',
+    'loadChildren: function() { return new Promise(function (resolve, reject) {',
     '  ' + (isJs ? 'require' : '(require as any)') + '.ensure([], function (' + (isJs ? 'require' : 'require: any') + ') {',
     '    resolve(' + requireString + ');',
-    '  }, function () {',
+    '  }, function() {',
     '    reject({ loadChunkError: true });',
     '  }' + module.exports.getChunkName('require', chunkName) + ');',
-    '})' + (isJs ? '}' : '')
+    '}) }'
   ];
@@ -39,4 +39,4 @@
   var result = [
-    'loadChildren: () => System.import(' + module.exports.getChunkName('system', chunkName) + '\'' + filePath + '\')',
-    '  .then(module => module[\'' + moduleName + '\'], () => { throw({ loadChunkError: true }); })'
+    'loadChildren: function() { return System.import(' + module.exports.getChunkName('system', chunkName) + '\'' + filePath + '\')',
+    '  .then(module => module[\'' + moduleName + '\'], () => { throw({ loadChunkError: true }); }) }'
   ];
@@ -49,4 +49,4 @@
   var result = [
-    'loadChildren: () => import(' + module.exports.getChunkName('import', chunkName) + '\'' + filePath + '\')',
-    '  .then(module => module[\'' + moduleName + '\'], () => { throw({ loadChunkError: true }); })'
+    'loadChildren: function() { return import(' + module.exports.getChunkName('import', chunkName) + '\'' + filePath + '\')',
+    '  .then(module => module[\'' + moduleName + '\'], () => { throw({ loadChunkError: true }); }) }'
   ];
@@ -53,0 +53,0 @@

No alert changes

Improved metrics

Total package byte prevSize

42925

0.72%

Worsened metrics

Number of package files

8

-11.11%

No dependency changes