angular-smooth-scrollbar - npm Package Compare versions

Comparing version 2.2.2 to 2.3.0

bower.json

 {
   "name": "angular-smooth-scrollbar",
-  "version": "2.2.1",
+  "version": "2.3.0",
   "authors": [
@@ -5,0 +5,0 @@ "Dolphin Wood <[e-mail]>"

dist/angular-smooth-scrollbar.js

@@ -31,10 +31,25 @@
      * @method
-     * Get scrollbar instance
-     * If instance isn't existed,
-     * callback wiil be invoked after instance is created
+     * Generate a scrollbar name with timestamp
      *
-     * @param {String} name: scrollbar name
+     * @return {String}
      */
 
     _createClass(ScrollbarService, [{
+        key: 'generateName',
+        value: function generateName() {
+            return Date.now().toString(32);
+        }
+
+        /**
+         * @method
+         * Get scrollbar instance
+         * If instance isn't existed,
+         * callback wiil be invoked after instance is created
+         *
+         * @param {String} name: scrollbar name
+         *
+         * @return {Promise} resolved with scrollbar<Scrollbar>
+         */
+
+    }, {
         key: 'getInstance',
@@ -126,3 +141,3 @@ value: function getInstance(name) {
 
-            var name = attrs.scrollbar || attrs.name || Date.now().toString(32);
+            var name = attrs.scrollbar || attrs.name || ScrollbarService.generateName();
 
@@ -129,0 +144,0 @@ var scrollbar = ScrollbarService.createInstance(name, elem[0], scope);

gulpfile.js

@@ -49,2 +49,4 @@ var gulp = require('gulp');
 
+gulp.task('release', ['compile']);
+
 gulp.task('default', ['serve']);

index.js

@@ -14,2 +14,12 @@ angular.module('SmoothScrollbar', [])
          * @method
+         * Generate a scrollbar name with timestamp
+         *
+         * @return {String}
+         */
+        generateName() {
+            return Date.now().toString(32);
+        }
+
+        /**
+         * @method
          * Get scrollbar instance
@@ -20,2 +30,4 @@ * If instance isn't existed,
          * @param {String} name: scrollbar name
+         *
+         * @return {Promise} resolved with scrollbar<Scrollbar>
          */
@@ -90,3 +102,3 @@ getInstance(name) {
                 const { speed, stepLength, easingDuration, easingCurve } = scope;
-                const name = attrs.scrollbar || attrs.name || Date.now().toString(32);
+                const name = attrs.scrollbar || attrs.name || ScrollbarService.generateName();
 
@@ -93,0 +105,0 @@ const scrollbar = ScrollbarService.createInstance(name, elem[0], scope);

package.json

 {
   "name": "angular-smooth-scrollbar",
-  "version": "2.2.2",
+  "version": "2.3.0",
   "description": "An angular module that allows you customize smooth scrollbars",
   "main": "dist/angular-smooth-scrollbar.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "gulp compile"
   },
@@ -9,0 +9,0 @@ "repository": {

README.md

 # angular-smooth-scrollbar
 
+[![npm](https://img.shields.io/npm/v/angular-smooth-scrollbar.svg?style=flat-square)](https://www.npmjs.com/package/angular-smooth-scrollbar)
+[![npm](https://img.shields.io/npm/l/angular-smooth-scrollbar.svg?style=flat-square)](https://www.npmjs.com/package/angular-smooth-scrollbar)
+[![devDependency Status](https://img.shields.io/david/dev/idiotWu/angular-smooth-scrollbar.svg?style=flat-square)](https://david-dm.org/idiotWu/angular-smooth-scrollbar#info=devDependencies)
+[![npm](https://img.shields.io/npm/dt/angular-smooth-scrollbar.svg?style=flat-square)](https://www.npmjs.com/package/angular-smooth-scrollbar)
+[![Travis](https://img.shields.io/travis/idiotWu/angular-smooth-scrollbar.svg)](https://travis-ci.org/idiotWu/angular-smooth-scrollbar)
+
 [smooth-scrollbar](https://github.com/idiotWu/smooth-scrollbar) for angular projects.
@@ -78,2 +84,6 @@
 
+## ScrollbarService.generateName()
+
+Return a timestamp string, this will be useful while trying naming scrollbars uniquely.
+
 ### ScrollbarService.getInstance( name )
@@ -80,0 +90,0 @@

test/main.js

@@ -0,0 +0,0 @@ (function(angular) {

Fixed alerts

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

413773

increased by0.3%

Number of package files

14

increased by7.69%

Lines of code

468

increased by5.64%

Number of low quality alerts

0

decreased by-100%

Number of lines in readme file

103

increased by10.75%

No dependency changes