animates - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

lib/animates.js

@@ -1,6 +0,6 @@
-var css = require('./css')
+var applyCss = require('./css')
 var defaults = require('./defaults')
 var transition = require('./transition')
 
-module.exports = function animates (el, end, opts) {
+module.exports = function animates (el, css, opts) {
   opts = defaults(opts)
@@ -11,4 +11,4 @@ setTimeout(start, 1)
   function start () {
-    el.style.transition = transition(opts.speed, opts.easing, opts.delay)
-    css(el, end)
+    el.style.transition = transition(css, opts.speed, opts.easing, opts.delay)
+    applyCss(el, css)
   }
@@ -15,0 +15,0 @@ function finish () {

lib/transition.js

 var seconds = require('./seconds')
+var uncamel = require('./uncamel')
 
-module.exports = function transition (speed, easing, delay) {
-  var str = 'all ' + seconds(speed)
-  if (easing) str += ' ' + easing
-  if (delay) str += ' ' + seconds(delay)
-  return str
+module.exports = function transition (props, speed, easing, delay) {
+  var transitions = []
+  var suffix = seconds(speed)
+  if (easing) suffix += ' ' + easing
+  if (delay) suffix += ' ' + seconds(delay)
+  for (var prop in props) if (props.hasOwnProperty(prop)) transitions.push(uncamel(prop) + ' ' + suffix)
+  return transitions.join(', ')
 }

package.json

 {
   "name": "animates",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "A tiny, performant replacement for jquery/animate using css3",
@@ -5,0 +5,0 @@ "main": "lib/animates.js",

test/test-animates.js

@@ -16,7 +16,7 @@ /* globals describe beforeEach it */
     animates(el, { opacity: 0 }, { speed: 100 })
-    setTimeout(middle, 0)
+    setTimeout(middle, 10)
     setTimeout(end, 200)
 
     function middle () {
-      expect(el.style.transition).to.eql('all 0.1s')
+      expect(el.style.transition).to.eql('opacity 0.1s')
     }
@@ -23,0 +23,0 @@

test/test-transition.js

@@ -7,9 +7,15 @@ /* globals describe it */
   it('should create transition strings', function () {
-    expect(transition(100, 'linear', 1000)).to.eq('all 0.1s linear 1s')
+    expect(transition({ top: 1 }, 100, 'linear', 1000)).to.eq('top 0.1s linear 1s')
   })
+  it('should create a transition string per property', function () {
+    expect(transition({ top: 1, left: 2 }, 100, 'linear', 1000)).to.eq('top 0.1s linear 1s, left 0.1s linear 1s')
+  })
   it('should treat easing and delay as optional', function () {
-    expect(transition(100)).to.eq('all 0.1s')
-    expect(transition(100, 'linear')).to.eq('all 0.1s linear')
-    expect(transition(100, null, 1000)).to.eq('all 0.1s 1s')
+    expect(transition({ opacity: 1 }, 100)).to.eq('opacity 0.1s')
+    expect(transition({ opacity: 1 }, 100, 'linear')).to.eq('opacity 0.1s linear')
+    expect(transition({ opacity: 1 }, 100, null, 1000)).to.eq('opacity 0.1s 1s')
   })
+  it('should uncamel props', function () {
+    expect(transition({ marginLeft: 1 }, 100)).to.eq('margin-left 0.1s')
+  })
 })

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

7955

increased by15.36%

Number of package files

18

increased by12.5%

Lines of code

155

increased by18.32%

No dependency changes